ProfileController::changePassword() - Code Metrics - Inspection of "Finish change_passwd" - et-nik/gameap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( f8f4ab...7498d6 )

by Nikita

created 2018-12-20 15:26 UTC

ProfileController::changePassword() A

↳ Parent: ProfileController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	10
rs	10
c	0
b	0
f	0

<?php

namespace Gameap\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Gameap\Http\Requests\ProfileChangePasswordRequest;
use Hash;

class ProfileController extends AuthController
{
    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        return view('profile', [
            'user' => $user = Auth::user(),

        ]);
    }

    /**
     * @param ProfileChangePasswordRequest $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function changePassword(ProfileChangePasswordRequest $request)
    {
        if (!(Hash::check($request->get('current_password'), Auth::user()->password))) {

            return redirect()->back()->with("error", "Your current password does not matches with the password you provided. Please try again.");
        }

        Auth::user()->update($request->only('password'));
        
        return redirect()->route('profile')
            ->with('success','Password changed successfully');
    }
}


1			<?php
2
3			namespace Gameap\Http\Controllers;
4
5			use Illuminate\Support\Facades\Auth;
6			use Gameap\Http\Requests\ProfileChangePasswordRequest;
7			use Hash;
8
9			class ProfileController extends AuthController
10			{
11			/**
12			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
13			*/
14			public function index()
15			{
16			return view('profile', [
17			'user' => $user = Auth::user(),
			0 ignored issues – show Unused Code introduced 2018-11-21 12:25 UTC by Report Bug Copy Issue Report The assignment to `$user` is dead and can be removed. Loading history...
18			]);
19			}
20
21			/**
22			* @param ProfileChangePasswordRequest $request
23			*
24			* @return \Illuminate\Http\RedirectResponse
25			*/
26			public function changePassword(ProfileChangePasswordRequest $request)
27			{
28			if (!(Hash::check($request->get('current_password'), Auth::user()->password))) {
			0 ignored issues – show Bug introduced 2018-12-20 15:35 UTC by Report Bug Copy Issue Report Accessing `password` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
29			return redirect()->back()->with("error", "Your current password does not matches with the password you provided. Please try again.");
30			}
31
32			Auth::user()->update($request->only('password'));
33
34			return redirect()->route('profile')
35			->with('success','Password changed successfully');
36			}
37			}
38

et-nik / gameap

Push — develop ( f8f4ab...7498d6 )

ProfileController::changePassword() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like