Gameap\Http\Controllers\ProfileController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	changePassword()	0	10	2

<?php

namespace Gameap\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Gameap\Http\Requests\ProfileChangePasswordRequest;
use Hash;

class ProfileController extends AuthController
{
    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        return view('profile', [
            'user' => $user = Auth::user(),

The assignment to $user is dead and can be removed.

        ]);
    }

    /**
     * @param ProfileChangePasswordRequest $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function changePassword(ProfileChangePasswordRequest $request)
    {
        if (!(Hash::check($request->get('current_password'), Auth::user()->password))) {

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return redirect()->back()->with("error", "Your current password does not matches with the password you provided. Please try again.");
        }

        Auth::user()->update($request->only('password'));
        
        return redirect()->route('profile')
            ->with('success','Password changed successfully');
    }
}