Erdemkeren\JetSms\JetSmsService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	sendShortMessage()	0	6	1
A	sendShortMessages()	0	13	2

<?php

namespace Erdemkeren\JetSms;

use Erdemkeren\JetSms\Http\Clients\JetSmsClientInterface;
use Erdemkeren\JetSms\Http\Responses\JetSmsResponseInterface;

/**
 * Class JetSmsService.
 */
final class JetSmsService
{
    /**
     * The jet sms client implementation.
     *
     * @var JetSmsClientInterface
     */
    private $client;

    /**
     * The short message factory implementation.
     *
     * @var ShortMessageFactoryInterface
     */
    private $factory;

    /**
     * The short message collection factory implementation.
     *
     * @var ShortMessageFactoryInterface
     */
    private $collectionFactory;

    /**
     * JetSmsService constructor.
     *
     * @param  JetSmsClientInterface        $jetSmsClient
     * @param  ShortMessageFactoryInterface $shortMessageFactory
     * @param  ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
     */
    public function __construct(
        JetSmsClientInterface $jetSmsClient,
        ShortMessageFactoryInterface $shortMessageFactory,
        ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
    ) {
        $this->client = $jetSmsClient;
        $this->factory = $shortMessageFactory;
        $this->collectionFactory = $shortMessageCollectionFactory;

It seems like $shortMessageCollectionFactory of type object<Erdemkeren\JetSms\ShortMessageCollectionFactoryInterface> is incompatible with the declared type object<Erdemkeren\JetSms\ShortMessageFactoryInterface> of property $collectionFactory.

    }

    /**
     * Send the given body to the given receivers.
     *
     * @param  string       $body      The body of the short message.
     * @param  array|string $receivers The receiver(s) of the message.
     *
     * @return JetSmsResponseInterface The parsed JetSms response object.
     */
    public function sendShortMessage($receivers, $body)
    {
        $shortMessage = $this->factory->create($receivers, $body);

        return $this->client->sendShortMessage($shortMessage);
    }

    /**
     * Send the given short messages.
     *
     * @param  array $messages         An array containing short message arrays.
     *
     * @return JetSmsResponseInterface The parsed JetSms response object.
     */
    public function sendShortMessages(array $messages)
    {
        $collection = $this->collectionFactory->create();

The call to create() misses some required arguments starting with $receivers.

        foreach ($messages as $message) {
            $collection->push($this->factory->create(

The method push() does not seem to exist on object<Erdemkeren\JetSms\ShortMessage>.

                $message['recipient'],
                $message['message']
            ));
        }

        return $this->client->sendShortMessages($collection);

$collection is of type object<Erdemkeren\JetSms\ShortMessage>, but the function expects a object<Erdemkeren\JetSms\ShortMessageCollection>.

    }
}