JetSmsService::sendShortMessages() - Code Metrics - Inspection of "chore: Adds php5.6, 7.0, 7.1 to travis configurati..." - erdemkeren/jet-sms-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4656f5...b898f3 )

by Hilmi Erdem

created 2018-02-16 22:05 UTC

JetSmsService::sendShortMessages() A

↳ Parent: JetSmsService

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php

namespace Erdemkeren\JetSms;

use Erdemkeren\JetSms\Http\Clients\JetSmsClientInterface;
use Erdemkeren\JetSms\Http\Responses\JetSmsResponseInterface;

/**
 * Class JetSmsService.
 */
final class JetSmsService
{
    /**
     * The jet sms client implementation.
     *
     * @var JetSmsClientInterface
     */
    private $client;

    /**
     * The short message factory implementation.
     *
     * @var ShortMessageFactoryInterface
     */
    private $factory;

    /**
     * The short message collection factory implementation.
     *
     * @var ShortMessageFactoryInterface
     */
    private $collectionFactory;

    /**
     * JetSmsService constructor.
     *
     * @param  JetSmsClientInterface        $jetSmsClient
     * @param  ShortMessageFactoryInterface $shortMessageFactory
     * @param  ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
     */
    public function __construct(
        JetSmsClientInterface $jetSmsClient,
        ShortMessageFactoryInterface $shortMessageFactory,
        ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
    ) {
        $this->client = $jetSmsClient;
        $this->factory = $shortMessageFactory;
        $this->collectionFactory = $shortMessageCollectionFactory;

    }

    /**
     * Send the given body to the given receivers.
     *
     * @param  string       $body      The body of the short message.
     * @param  array|string $receivers The receiver(s) of the message.
     *
     * @return JetSmsResponseInterface The parsed JetSms response object.
     */
    public function sendShortMessage($receivers, $body)
    {
        $shortMessage = $this->factory->create($receivers, $body);

        return $this->client->sendShortMessage($shortMessage);
    }

    /**
     * Send the given short messages.
     *
     * @param  array $messages         An array containing short message arrays.
     *
     * @return JetSmsResponseInterface The parsed JetSms response object.
     */
    public function sendShortMessages(array $messages)
    {
        $collection = $this->collectionFactory->create();


        foreach ($messages as $message) {
            $collection->push($this->factory->create(

                $message['recipient'],
                $message['message']
            ));
        }

        return $this->client->sendShortMessages($collection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Erdemkeren\JetSms;
4
5		use Erdemkeren\JetSms\Http\Clients\JetSmsClientInterface;
6		use Erdemkeren\JetSms\Http\Responses\JetSmsResponseInterface;
7
8		/**
9		* Class JetSmsService.
10		*/
11		final class JetSmsService
12		{
13		/**
14		* The jet sms client implementation.
15		*
16		* @var JetSmsClientInterface
17		*/
18		private $client;
19
20		/**
21		* The short message factory implementation.
22		*
23		* @var ShortMessageFactoryInterface
24		*/
25		private $factory;
26
27		/**
28		* The short message collection factory implementation.
29		*
30		* @var ShortMessageFactoryInterface
31		*/
32		private $collectionFactory;
33
34		/**
35		* JetSmsService constructor.
36		*
37		* @param JetSmsClientInterface $jetSmsClient
38		* @param ShortMessageFactoryInterface $shortMessageFactory
39		* @param ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
40		*/
41	3	public function __construct(
42		JetSmsClientInterface $jetSmsClient,
43		ShortMessageFactoryInterface $shortMessageFactory,
44		ShortMessageCollectionFactoryInterface $shortMessageCollectionFactory
45		) {
46	3	$this->client = $jetSmsClient;
47	3	$this->factory = $shortMessageFactory;
48	3	$this->collectionFactory = $shortMessageCollectionFactory;
		0 ignored issues – show Documentation Bug introduced 2018-02-16 21:50 UTC by Report Bug Copy Issue Report It seems like `$shortMessageCollectionFactory` of type `object<Erdemkeren\JetSms...ectionFactoryInterface>` is incompatible with the declared type `object<Erdemkeren\JetSms...essageFactoryInterface>` of property `$collectionFactory`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
49	3	}
50
51		/**
52		* Send the given body to the given receivers.
53		*
54		* @param string $body The body of the short message.
55		* @param array\|string $receivers The receiver(s) of the message.
56		*
57		* @return JetSmsResponseInterface The parsed JetSms response object.
58		*/
59	2	public function sendShortMessage($receivers, $body)
60		{
61	2	$shortMessage = $this->factory->create($receivers, $body);
62
63	2	return $this->client->sendShortMessage($shortMessage);
64		}
65
66		/**
67		* Send the given short messages.
68		*
69		* @param array $messages An array containing short message arrays.
70		*
71		* @return JetSmsResponseInterface The parsed JetSms response object.
72		*/
73	1	public function sendShortMessages(array $messages)
74		{
75	1	$collection = $this->collectionFactory->create();
		0 ignored issues – show Bug introduced 2018-02-16 21:50 UTC by Report Bug Copy Issue Report The call to `create()` misses some required arguments starting with `$receivers`. Loading history...
76
77	1	foreach ($messages as $message) {
78	1	$collection->push($this->factory->create(
		0 ignored issues – show Bug introduced 2018-02-16 21:50 UTC by Report Bug Copy Issue Report The method `push()` does not seem to exist on `object<Erdemkeren\JetSms\ShortMessage>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
79	1	$message['recipient'],
80	1	$message['message']
81	1	));
82	1	}
83
84	1	return $this->client->sendShortMessages($collection);
		0 ignored issues – show Documentation introduced 2018-02-16 21:50 UTC by Report Bug Copy Issue Report `$collection` is of type `object<Erdemkeren\JetSms\ShortMessage>`, but the function expects a `object<Erdemkeren\JetSms\ShortMessageCollection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85		}
86		}
87

erdemkeren / jet-sms-php

Push — master ( 4656f5...b898f3 )

JetSmsService::sendShortMessages() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like