View GitHub Repository waca

Schedule Inspection
Subscribe
Completed
Pull Request — master (#208)
by Matthew
03:23
created
Status
Category
Toggle Patches
tests/includes/IrcColourCodeTest.php 4 patches
Indentation   +52 added lines, -52 removed lines patch added patch discarded remove patch 
@@ -2,7 +2,7 @@  discard block
 
 block discarded – undo
2 2
3 3 
 class IrcColourCodeTest extends PHPUnit_Framework_TestCase
4 4 
 {
5 
-    private $irc;
5 
+	private $irc;
6 6
7 7 
 	public function setUp()
8 8 
 	{
 
@@ -11,62 +11,62 @@  discard block
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->irc = NULL;
15 
-    }
14 
+		$this->irc = NULL;
15 
+	}
16 16
17 
-    public function test_colorCodes() {
17 
+	public function test_colorCodes() {
18 18
19 
-        $i = $this->irc;
19 
+		$i = $this->irc;
20 20
21 
-        $this->assertEquals($i::BOLD,"\x02");
22 
-        $this->assertEquals($i::ITALIC, "\x09");
23 
-        $this->assertEquals($i::STRIKE, "\x13");
24 
-        $this->assertEquals($i::UNDERLINE, "\x15");
25 
-        $this->assertEquals($i::UNDERLINE2, "\x1f");
26 
-        $this->assertEquals($i::REVERSE, "\x16");
27 
-        $this->assertEquals($i::RESET, "\x0f");
21 
+		$this->assertEquals($i::BOLD,"\x02");
22 
+		$this->assertEquals($i::ITALIC, "\x09");
23 
+		$this->assertEquals($i::STRIKE, "\x13");
24 
+		$this->assertEquals($i::UNDERLINE, "\x15");
25 
+		$this->assertEquals($i::UNDERLINE2, "\x1f");
26 
+		$this->assertEquals($i::REVERSE, "\x16");
27 
+		$this->assertEquals($i::RESET, "\x0f");
28 28
29 
-        $this->assertEquals($i::WHITE, "\x0300");
30 
-        $this->assertEquals($i::BLACK, "\x0301");
31 
-        $this->assertEquals($i::DARK_BLUE, "\x0302");
32 
-        $this->assertEquals($i::DARK_GREEN, "\x0303");
33 
-        $this->assertEquals($i::RED, "\x0304");
34 
-        $this->assertEquals($i::DARK_RED, "\x0305");
35 
-        $this->assertEquals($i::DARK_VIOLET, "\x0306");
36 
-        $this->assertEquals($i::ORANGE, "\x0307");
37 
-        $this->assertEquals($i::YELLOW, "\x0308");
38 
-        $this->assertEquals($i::LIGHT_GREEN, "\x0309");
39 
-        $this->assertEquals($i::CYAN, "\x0310");
40 
-        $this->assertEquals($i::LIGHT_CYAN, "\x0311");
41 
-        $this->assertEquals($i::BLUE, "\x0312");
42 
-        $this->assertEquals($i::VIOLET, "\x0313");
43 
-        $this->assertEquals($i::DARK_GREY, "\x0314");
44 
-        $this->assertEquals($i::LIGHT_GREY, "\x0315");
29 
+		$this->assertEquals($i::WHITE, "\x0300");
30 
+		$this->assertEquals($i::BLACK, "\x0301");
31 
+		$this->assertEquals($i::DARK_BLUE, "\x0302");
32 
+		$this->assertEquals($i::DARK_GREEN, "\x0303");
33 
+		$this->assertEquals($i::RED, "\x0304");
34 
+		$this->assertEquals($i::DARK_RED, "\x0305");
35 
+		$this->assertEquals($i::DARK_VIOLET, "\x0306");
36 
+		$this->assertEquals($i::ORANGE, "\x0307");
37 
+		$this->assertEquals($i::YELLOW, "\x0308");
38 
+		$this->assertEquals($i::LIGHT_GREEN, "\x0309");
39 
+		$this->assertEquals($i::CYAN, "\x0310");
40 
+		$this->assertEquals($i::LIGHT_CYAN, "\x0311");
41 
+		$this->assertEquals($i::BLUE, "\x0312");
42 
+		$this->assertEquals($i::VIOLET, "\x0313");
43 
+		$this->assertEquals($i::DARK_GREY, "\x0314");
44 
+		$this->assertEquals($i::LIGHT_GREY, "\x0315");
45 45
46 
-        $this->assertNotEquals($i::BOLD,"\x021");
47 
-        $this->assertNotEquals($i::ITALIC, "\x091");
48 
-        $this->assertNotEquals($i::STRIKE, "\x131");
49 
-        $this->assertNotEquals($i::UNDERLINE, "\x151");
50 
-        $this->assertNotEquals($i::UNDERLINE2, "\x1f1");
51 
-        $this->assertNotEquals($i::REVERSE, "\x161");
52 
-        $this->assertNotEquals($i::RESET, "\x0f1");
46 
+		$this->assertNotEquals($i::BOLD,"\x021");
47 
+		$this->assertNotEquals($i::ITALIC, "\x091");
48 
+		$this->assertNotEquals($i::STRIKE, "\x131");
49 
+		$this->assertNotEquals($i::UNDERLINE, "\x151");
50 
+		$this->assertNotEquals($i::UNDERLINE2, "\x1f1");
51 
+		$this->assertNotEquals($i::REVERSE, "\x161");
52 
+		$this->assertNotEquals($i::RESET, "\x0f1");
53 53
54 
-        $this->assertNotEquals($i::WHITE, "\x03001");
55 
-        $this->assertNotEquals($i::BLACK, "\x03011");
56 
-        $this->assertNotEquals($i::DARK_BLUE, "\x03021");
57 
-        $this->assertNotEquals($i::DARK_GREEN, "\x03031");
58 
-        $this->assertNotEquals($i::RED, "\x03041");
59 
-        $this->assertNotEquals($i::DARK_RED, "\x03051");
60 
-        $this->assertNotEquals($i::DARK_VIOLET, "\x03061");
61 
-        $this->assertNotEquals($i::ORANGE, "\x03071");
62 
-        $this->assertNotEquals($i::YELLOW, "\x03081");
63 
-        $this->assertNotEquals($i::LIGHT_GREEN, "\x03091");
64 
-        $this->assertNotEquals($i::CYAN, "\x03101");
65 
-        $this->assertNotEquals($i::LIGHT_CYAN, "\x03111");
66 
-        $this->assertNotEquals($i::BLUE, "\x03121");
67 
-        $this->assertNotEquals($i::VIOLET, "\x03131");
68 
-        $this->assertNotEquals($i::DARK_GREY, "\x03141");
69 
-        $this->assertNotEquals($i::LIGHT_GREY, "\x03151");
70 
-    }
54 
+		$this->assertNotEquals($i::WHITE, "\x03001");
55 
+		$this->assertNotEquals($i::BLACK, "\x03011");
56 
+		$this->assertNotEquals($i::DARK_BLUE, "\x03021");
57 
+		$this->assertNotEquals($i::DARK_GREEN, "\x03031");
58 
+		$this->assertNotEquals($i::RED, "\x03041");
59 
+		$this->assertNotEquals($i::DARK_RED, "\x03051");
60 
+		$this->assertNotEquals($i::DARK_VIOLET, "\x03061");
61 
+		$this->assertNotEquals($i::ORANGE, "\x03071");
62 
+		$this->assertNotEquals($i::YELLOW, "\x03081");
63 
+		$this->assertNotEquals($i::LIGHT_GREEN, "\x03091");
64 
+		$this->assertNotEquals($i::CYAN, "\x03101");
65 
+		$this->assertNotEquals($i::LIGHT_CYAN, "\x03111");
66 
+		$this->assertNotEquals($i::BLUE, "\x03121");
67 
+		$this->assertNotEquals($i::VIOLET, "\x03131");
68 
+		$this->assertNotEquals($i::DARK_GREY, "\x03141");
69 
+		$this->assertNotEquals($i::LIGHT_GREY, "\x03151");
70 
+	}
71 71
72 72 
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18
19 19 
         $i = $this->irc;
20 20
21 
-        $this->assertEquals($i::BOLD,"\x02");
21 
+        $this->assertEquals($i::BOLD, "\x02");
22 22 
         $this->assertEquals($i::ITALIC, "\x09");
23 23 
         $this->assertEquals($i::STRIKE, "\x13");
24 24 
         $this->assertEquals($i::UNDERLINE, "\x15");
 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
         $this->assertEquals($i::DARK_GREY, "\x0314");
44 44 
         $this->assertEquals($i::LIGHT_GREY, "\x0315");
45 45
46 
-        $this->assertNotEquals($i::BOLD,"\x021");
46 
+        $this->assertNotEquals($i::BOLD, "\x021");
47 47 
         $this->assertNotEquals($i::ITALIC, "\x091");
48 48 
         $this->assertNotEquals($i::STRIKE, "\x131");
49 49 
         $this->assertNotEquals($i::UNDERLINE, "\x151");
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -10,11 +10,13 @@
 
 block discarded – undo
10 10 
 		$this->irc = new IrcColourCode();
11 11 
 	}
12 12
13 
-	public function tearDown() {
13 
+	public function tearDown()
14 
+	{
14 15 
         $this->irc = NULL;
15 16 
     }
16 17
17 
-    public function test_colorCodes() {
18 
+    public function test_colorCodes()
19 
+    {
18 20
19 21 
         $i = $this->irc;
20 22
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->irc = NULL;
14 
+        $this->irc = null;
15 15 
     }
16 16
17 17 
     public function test_colorCodes() {
Please login to merge, or discard this patch.
tests/includes/StringFunctionsTest.php 3 patches
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch 
@@ -2,7 +2,7 @@  discard block
 
 block discarded – undo
2 2
3 3 
 class StringFunctionsTest extends PHPUnit_Framework_TestCase
4 4 
 {
5 
-    private $e;
5 
+	private $e;
6 6
7 7 
 	public function setUp()
8 8 
 	{
 
@@ -11,38 +11,38 @@  discard block
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->e = NULL;
15 
-    }
16 
-
17 
-    public function test_formatAsUsername() {
18 
-        // Happy path
19 
-        $this->assertEquals($this->e->formatAsUsername("this"), "This");
20 
-        $this->assertEquals($this->e->formatAsUsername("1this"), "1this");
21 
-        $this->assertEquals($this->e->formatAsUsername("This"), "This");
22 
-        $this->assertEquals($this->e->formatAsUsername("This "), "This");
23 
-        $this->assertEquals($this->e->formatAsUsername("This_"), "This");
24 
-
25 
-        // Sad Path
26 
-        $this->assertNotEquals($this->e->formatAsUsername("This "), "This ");
27 
-        $this->assertNotEquals($this->e->formatAsUsername("This_"), "This_");
28 
-        $this->assertNotEquals($this->e->formatAsUsername("this"), "this");
29 
-        $this->assertNotEquals($this->e->formatAsUsername("1this"), "1This");
30 
-    }
31 
-
32 
-    public function test_formatAsEmail() {
33 
-        $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
34 
-        $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
35 
-        $this->assertEquals($this->e->formatAsEmail(" [email protected]"), "[email protected]");
36 
-        $this->assertEquals($this->e->formatAsEmail("[email protected] "), "[email protected]");
37 
-        $this->assertEquals($this->e->formatAsEmail("1this12345 @example.com"), "[email protected]");
38 
-        $this->assertEquals($this->e->formatAsEmail("1this12345@ example.com"), "[email protected]");
39 
-
40 
-        // Sad Path
41 
-        $this->assertNotEquals($this->e->formatAsEmail(" [email protected]"), " [email protected]");
42 
-        $this->assertNotEquals($this->e->formatAsEmail("[email protected] "), "[email protected] ");
43 
-        $this->assertNotEquals($this->e->formatAsEmail("1this12345 @example.com"), "1this12345 @example.com");
44 
-        $this->assertNotEquals($this->e->formatAsEmail("1this12345@ example.com"), "1this12345@ example.com");
45 
-
46 
-    }
14 
+		$this->e = NULL;
15 
+	}
16 
+
17 
+	public function test_formatAsUsername() {
18 
+		// Happy path
19 
+		$this->assertEquals($this->e->formatAsUsername("this"), "This");
20 
+		$this->assertEquals($this->e->formatAsUsername("1this"), "1this");
21 
+		$this->assertEquals($this->e->formatAsUsername("This"), "This");
22 
+		$this->assertEquals($this->e->formatAsUsername("This "), "This");
23 
+		$this->assertEquals($this->e->formatAsUsername("This_"), "This");
24 
+
25 
+		// Sad Path
26 
+		$this->assertNotEquals($this->e->formatAsUsername("This "), "This ");
27 
+		$this->assertNotEquals($this->e->formatAsUsername("This_"), "This_");
28 
+		$this->assertNotEquals($this->e->formatAsUsername("this"), "this");
29 
+		$this->assertNotEquals($this->e->formatAsUsername("1this"), "1This");
30 
+	}
31 
+
32 
+	public function test_formatAsEmail() {
33 
+		$this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
34 
+		$this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
35 
+		$this->assertEquals($this->e->formatAsEmail(" [email protected]"), "[email protected]");
36 
+		$this->assertEquals($this->e->formatAsEmail("[email protected] "), "[email protected]");
37 
+		$this->assertEquals($this->e->formatAsEmail("1this12345 @example.com"), "[email protected]");
38 
+		$this->assertEquals($this->e->formatAsEmail("1this12345@ example.com"), "[email protected]");
39 
+
40 
+		// Sad Path
41 
+		$this->assertNotEquals($this->e->formatAsEmail(" [email protected]"), " [email protected]");
42 
+		$this->assertNotEquals($this->e->formatAsEmail("[email protected] "), "[email protected] ");
43 
+		$this->assertNotEquals($this->e->formatAsEmail("1this12345 @example.com"), "1this12345 @example.com");
44 
+		$this->assertNotEquals($this->e->formatAsEmail("1this12345@ example.com"), "1this12345@ example.com");
45 
+
46 
+	}
47 47
48 48 
 }
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -10,11 +10,13 @@  discard block
 
 block discarded – undo
10 10 
 		$this->e = new StringFunctions();
11 11 
 	}
12 12
13 
-	public function tearDown() {
13 
+	public function tearDown()
14 
+	{
14 15 
         $this->e = NULL;
15 16 
     }
16 17
17 
-    public function test_formatAsUsername() {
18 
+    public function test_formatAsUsername()
19 
+    {
18 20 
         // Happy path
19 21 
         $this->assertEquals($this->e->formatAsUsername("this"), "This");
20 22 
         $this->assertEquals($this->e->formatAsUsername("1this"), "1this");
 
@@ -29,7 +31,8 @@  discard block
 
 block discarded – undo
29 31 
         $this->assertNotEquals($this->e->formatAsUsername("1this"), "1This");
30 32 
     }
31 33
32 
-    public function test_formatAsEmail() {
34 
+    public function test_formatAsEmail()
35 
+    {
33 36 
         $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
34 37 
         $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
35 38 
         $this->assertEquals($this->e->formatAsEmail(" [email protected]"), "[email protected]");
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->e = NULL;
14 
+        $this->e = null;
15 15 
     }
16 16
17 17 
     public function test_formatAsUsername() {
Please login to merge, or discard this patch.
tests/includes/stringsTest.php 3 patches
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch 
@@ -2,7 +2,7 @@  discard block
 
 block discarded – undo
2 2
3 3 
 class stringsTest extends PHPUnit_Framework_TestCase
4 4 
 {
5 
-    private $e;
5 
+	private $e;
6 6
7 7 
 	public function setUp()
8 8 
 	{
 
@@ -11,38 +11,38 @@  discard block
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->e = NULL;
15 
-    }
16 
-
17 
-    public function test_struname() {
18 
-        // Happy path
19 
-        $this->assertEquals($this->e->struname("this"), "This");
20 
-        $this->assertEquals($this->e->struname("1this"), "1this");
21 
-        $this->assertEquals($this->e->struname("This"), "This");
22 
-        $this->assertEquals($this->e->struname("This "), "This");
23 
-        $this->assertEquals($this->e->struname("This_"), "This");
24 
-
25 
-        // Sad Path
26 
-        $this->assertNotEquals($this->e->struname("This "), "This ");
27 
-        $this->assertNotEquals($this->e->struname("This_"), "This_");
28 
-        $this->assertNotEquals($this->e->struname("this"), "this");
29 
-        $this->assertNotEquals($this->e->struname("1this"), "1This");
30 
-    }
31 
-
32 
-    public function test_stremail() {
33 
-        $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
34 
-        $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
35 
-        $this->assertEquals($this->e->stremail(" [email protected]"), "[email protected]");
36 
-        $this->assertEquals($this->e->stremail("[email protected] "), "[email protected]");
37 
-        $this->assertEquals($this->e->stremail("1this12345 @example.com"), "[email protected]");
38 
-        $this->assertEquals($this->e->stremail("1this12345@ example.com"), "[email protected]");
39 
-
40 
-        // Sad Path
41 
-        $this->assertNotEquals($this->e->stremail(" [email protected]"), " [email protected]");
42 
-        $this->assertNotEquals($this->e->stremail("[email protected] "), "[email protected] ");
43 
-        $this->assertNotEquals($this->e->stremail("1this12345 @example.com"), "1this12345 @example.com");
44 
-        $this->assertNotEquals($this->e->stremail("1this12345@ example.com"), "1this12345@ example.com");
45 
-
46 
-    }
14 
+		$this->e = NULL;
15 
+	}
16 
+
17 
+	public function test_struname() {
18 
+		// Happy path
19 
+		$this->assertEquals($this->e->struname("this"), "This");
20 
+		$this->assertEquals($this->e->struname("1this"), "1this");
21 
+		$this->assertEquals($this->e->struname("This"), "This");
22 
+		$this->assertEquals($this->e->struname("This "), "This");
23 
+		$this->assertEquals($this->e->struname("This_"), "This");
24 
+
25 
+		// Sad Path
26 
+		$this->assertNotEquals($this->e->struname("This "), "This ");
27 
+		$this->assertNotEquals($this->e->struname("This_"), "This_");
28 
+		$this->assertNotEquals($this->e->struname("this"), "this");
29 
+		$this->assertNotEquals($this->e->struname("1this"), "1This");
30 
+	}
31 
+
32 
+	public function test_stremail() {
33 
+		$this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
34 
+		$this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
35 
+		$this->assertEquals($this->e->stremail(" [email protected]"), "[email protected]");
36 
+		$this->assertEquals($this->e->stremail("[email protected] "), "[email protected]");
37 
+		$this->assertEquals($this->e->stremail("1this12345 @example.com"), "[email protected]");
38 
+		$this->assertEquals($this->e->stremail("1this12345@ example.com"), "[email protected]");
39 
+
40 
+		// Sad Path
41 
+		$this->assertNotEquals($this->e->stremail(" [email protected]"), " [email protected]");
42 
+		$this->assertNotEquals($this->e->stremail("[email protected] "), "[email protected] ");
43 
+		$this->assertNotEquals($this->e->stremail("1this12345 @example.com"), "1this12345 @example.com");
44 
+		$this->assertNotEquals($this->e->stremail("1this12345@ example.com"), "1this12345@ example.com");
45 
+
46 
+	}
47 47
48 48 
 }
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -10,11 +10,13 @@  discard block
 
 block discarded – undo
10 10 
 		$this->e = new strings();
11 11 
 	}
12 12
13 
-	public function tearDown() {
13 
+	public function tearDown()
14 
+	{
14 15 
         $this->e = NULL;
15 16 
     }
16 17
17 
-    public function test_struname() {
18 
+    public function test_struname()
19 
+    {
18 20 
         // Happy path
19 21 
         $this->assertEquals($this->e->struname("this"), "This");
20 22 
         $this->assertEquals($this->e->struname("1this"), "1this");
 
@@ -29,7 +31,8 @@  discard block
 
 block discarded – undo
29 31 
         $this->assertNotEquals($this->e->struname("1this"), "1This");
30 32 
     }
31 33
32 
-    public function test_stremail() {
34 
+    public function test_stremail()
35 
+    {
33 36 
         $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
34 37 
         $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
35 38 
         $this->assertEquals($this->e->stremail(" [email protected]"), "[email protected]");
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@
 
 block discarded – undo
11 11 
 	}
12 12
13 13 
 	public function tearDown() {
14 
-        $this->e = NULL;
14 
+        $this->e = null;
15 15 
     }
16 16
17 17 
     public function test_struname() {
Please login to merge, or discard this patch.