View GitHub Repository waca

Schedule Inspection
Subscribe
Failed Conditions
Push — multiproject/prefs ( 965e5d )
by Simon
08:54
created
Status
Category
Toggle Patches
includes/Pages/UserAuth/PagePreferences.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -37,8 +37,8 @@
 
 block discarded – undo
37 37 
         if (WebRequest::wasPosted()) {
38 38 
             $this->validateCSRFToken();
39 39
40 
-            $this->setPreference($preferencesManager,PreferenceManager::PREF_EMAIL_SIGNATURE, 'emailSignature');
41 
-            $this->setPreferenceWithValue($preferencesManager,PreferenceManager::PREF_SKIP_JS_ABORT, 'skipJsAbort', WebRequest::postBoolean('skipJsAbort') ? 1 : 0);
40 
+            $this->setPreference($preferencesManager, PreferenceManager::PREF_EMAIL_SIGNATURE, 'emailSignature');
41 
+            $this->setPreferenceWithValue($preferencesManager, PreferenceManager::PREF_SKIP_JS_ABORT, 'skipJsAbort', WebRequest::postBoolean('skipJsAbort') ? 1 : 0);
42 42 
             $this->setCreationMode($user, $preferencesManager);
43 43 
             $this->setSkin($preferencesManager);
44 44 
             $preferencesManager->setGlobalPreference(PreferenceManager::PREF_DEFAULT_DOMAIN, WebRequest::postInt('defaultDomain'));
Please login to merge, or discard this patch.
includes/DataObjects/UserPreference.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
      */
68 68 
     public function save()
69 69 
     {
70 
-        if($this->isNew()) {
70 
+        if ($this->isNew()) {
71 71 
             // insert
72 72 
             $statement = $this->dbObject->prepare(<<<SQL
73 73 
                 INSERT INTO `userpreference` (
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
             else {
89 89 
                 throw new Exception($statement->errorInfo());
90 90 
             }
91 
-        }else{
91 
+        } else {
92 92 
             // update
93 93 
             $statement = $this->dbObject->prepare(<<<SQL
94 94 
                 UPDATE `userpreference` SET
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -28,7 +28,8 @@  discard block
 
 block discarded – undo
28 28 
     /** @var ?mixed */
29 29 
     private $value;
30 30
31 
-    public static function getLocalPreference(PdoDatabase $database, int $user, string $preference, int $domain) {
31 
+    public static function getLocalPreference(PdoDatabase $database, int $user, string $preference, int $domain)
32 
+    {
32 33 
         $statement = $database->prepare('SELECT * FROM userpreference WHERE preference = :preference AND USER = :user AND domain = :domain');
33 34 
         $statement->execute([
34 35 
             ':user' => $user,
 
@@ -45,7 +46,8 @@  discard block
 
 block discarded – undo
45 46 
         return $resultObject;
46 47 
     }
47 48
48 
-    public static function getGlobalPreference(PdoDatabase $database, int $user, string $preference) {
49 
+    public static function getGlobalPreference(PdoDatabase $database, int $user, string $preference)
50 
+    {
49 51 
         $statement = $database->prepare('SELECT * FROM userpreference WHERE preference = :preference AND USER = :user AND domain IS NULL');
50 52 
         $statement->execute([
51 53 
             ':user' => $user,
 
@@ -88,7 +90,8 @@  discard block
 
 block discarded – undo
88 90 
             else {
89 91 
                 throw new Exception($statement->errorInfo());
90 92 
             }
91 
-        }else{
93 
+        }
94 
+        else {
92 95 
             // update
93 96 
             $statement = $this->dbObject->prepare(<<<SQL
94 97 
                 UPDATE `userpreference` SET
Please login to merge, or discard this patch.