endorphin-studio / browser-detector

src/Detector.php

Doc Comments +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
     }
 
     /**
-     * @param $version Windows number version
+     * @param string $version Windows number version
      * @return string Windows version
      */
     private static function getWindowsVersion($version)

Spacing +26 added lines, -26 removed lines

@@ -53,27 +53,27 @@ 
      * Detector constructor.
      * @param string $pathToData Path to directory with xml data files
      */
-    private function __construct($pathToData='auto')
+    private function __construct($pathToData = 'auto')
     {
-        if($pathToData == 'auto')
+        if ($pathToData == 'auto')
         {
-            $this->setPathToData(str_replace('src','data',__DIR__).'/');
+            $this->setPathToData(str_replace('src', 'data', __DIR__).'/');
         }
 
-        $xml = array('browser','device','os','robot');
+        $xml = array('browser', 'device', 'os', 'robot');
         $xmlData = array();
-        foreach($xml as $name)
+        foreach ($xml as $name)
         {
             $xmlData[$name] = simplexml_load_file($this->getPathToData().$name.'.xml');
         }
         $this->setXmlData($xmlData);
     }
 
-    public static function Analyse($uaString='UA',$pathToData='auto')
+    public static function Analyse($uaString = 'UA', $pathToData = 'auto')
     {
         $ua = $uaString;
         $pathXML = $pathToData;
-        if($uaString == 'UA')
+        if ($uaString == 'UA')
         {
             $ua = $_SERVER['HTTP_USER_AGENT'];
         }
@@ -81,21 +81,21 @@ 
         $detector = new Detector($pathToData);
         $xml = $detector->getXmlData();
         $data = array();
-        foreach($xml as $key => $item)
+        foreach ($xml as $key => $item)
         {
-            $data[$key] = self::analysePart($xml,$key,$ua);
+            $data[$key] = self::analysePart($xml, $key, $ua);
         }
 
         $detectorResult = new DetectorResult();
         $detectorResult->uaString = $ua;
 
-        foreach($data as $key => $result)
+        foreach ($data as $key => $result)
         {
-            switch($key)
+            switch ($key)
             {
                 case 'os':
                     $os = new OS($result);
-                    $os->Version = self::getVersion($result,$ua);
+                    $os->Version = self::getVersion($result, $ua);
                     $detectorResult->OS = $os;
                     break;
                 case 'device':
@@ -104,7 +104,7 @@ 
                     break;
                 case 'browser':
                     $browser = new Browser($result);
-                    $browser->Version = self::getVersion($result,$ua);
+                    $browser->Version = self::getVersion($result, $ua);
                     $detectorResult->Browser = $browser;
                     break;
             }
@@ -119,13 +119,13 @@ 
      * @param string $uaString User agent
      * @return \SimpleXMLElement xml element
      */
-    private static function analysePart($xmlData,$key,$uaString)
+    private static function analysePart($xmlData, $key, $uaString)
     {
         $data = $xmlData[$key]->data;
-        foreach($data as $xmlItem)
+        foreach ($data as $xmlItem)
         {
             $pattern = '/'.$xmlItem->pattern.'/';
-            if(preg_match($pattern,$uaString))
+            if (preg_match($pattern, $uaString))
             {
                 return $xmlItem;
             }
@@ -138,22 +138,22 @@ 
      * @param string $uaString User agent
      * @return string Version
      */
-    private static function getVersion($xmlItem,$uaString)
+    private static function getVersion($xmlItem, $uaString)
     {
         $vPattern = $xmlItem->versionPattern;
         $version = @'/'.$vPattern.'(\/| )[\w-._]{1,15}/';
-        $uaString = str_replace(' NT','',$uaString);
-        if(preg_match($version,$uaString))
+        $uaString = str_replace(' NT', '', $uaString);
+        if (preg_match($version, $uaString))
         {
-            preg_match($version,$uaString,$v);
+            preg_match($version, $uaString, $v);
             @$version = $v[0];
-            $version = preg_replace('/'.$vPattern.'/','',$version);
-            $version = str_replace(';','',$version);
-            $version = str_replace(' ','',$version);
-            $version = str_replace('/','',$version);
-            $version = str_replace('_','.',$version);
+            $version = preg_replace('/'.$vPattern.'/', '', $version);
+            $version = str_replace(';', '', $version);
+            $version = str_replace(' ', '', $version);
+            $version = str_replace('/', '', $version);
+            $version = str_replace('_', '.', $version);
 
-            if($xmlItem->id == 'Windows')
+            if ($xmlItem->id == 'Windows')
             {
                 $version = self::getWindowsVersion($version);
             }

src/Data.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      */
     public function __construct($xmlData)
     {
-        if($xmlData != null)
+        if ($xmlData != null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName()) {

src/Device.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function __construct($xmlData)
     {
-        if($xmlData == null)
+        if ($xmlData == null)
         {
             $this->Name = 'Desktop';
             $this->Type = 'desktop';

Braces +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
         {
             $this->Name = 'Desktop';
             $this->Type = 'desktop';
-        }
-        else
+        } else
         {
             parent::__construct($xmlData);
 

src/OS.php

Spacing +6 added lines, -6 removed lines

@@ -22,12 +22,12 @@ 
     public function __construct($xmlData)
     {
         parent::__construct($xmlData);
-        foreach($xmlData->children() as $child)
+        foreach ($xmlData->children() as $child)
         {
-            switch($child->getName())
+            switch ($child->getName())
             {
                 case 'family':
-                    switch($child->__toString())
+                    switch ($child->__toString())
                     {
                         case 'UNX':
                             $this->Family = UNX;
@@ -46,6 +46,6 @@ 
 
 }
 
-define('UNX','unix');
-define('WIN','windows');
-define('MAC','mac');
\ No newline at end of file
+define('UNX', 'unix');
+define('WIN', 'windows');
+define('MAC', 'mac');
\ No newline at end of file

tests/BrowserTest.php

Spacing +2 added lines, -2 removed lines

@@ -14,11 +14,11 @@
 {
     public function testFirefox()
     {
-        $this->assertEquals('Firefox',Detector::Analyse('Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 ')->Browser->Name);
+        $this->assertEquals('Firefox', Detector::Analyse('Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 ')->Browser->Name);
     }
     public function testOpera()
     {
-        $this->assertEquals('Opera',Detector::Analyse('Opera/9.80 (X11; Linux i686; Ubuntu/14.10) Presto/2.12.388 Version/12.16')->Browser->Name);
+        $this->assertEquals('Opera', Detector::Analyse('Opera/9.80 (X11; Linux i686; Ubuntu/14.10) Presto/2.12.388 Version/12.16')->Browser->Name);
     }
 
 }

tests/bootstrap.php

Spacing +6 added lines, -6 removed lines

@@ -7,13 +7,13 @@
  * @project browser-detector
  */
 
-$vendor = realpath(__DIR__ . '/../vendor');
-if (file_exists($vendor . '/autoload.php')) {
-    require $vendor . '/autoload.php';
+$vendor = realpath(__DIR__.'/../vendor');
+if (file_exists($vendor.'/autoload.php')) {
+    require $vendor.'/autoload.php';
 } else {
-    $vendor = realpath(__DIR__ . '/../../../');
-    if (file_exists($vendor . '/autoload.php')) {
-        require $vendor . '/autoload.php';
+    $vendor = realpath(__DIR__.'/../../../');
+    if (file_exists($vendor.'/autoload.php')) {
+        require $vendor.'/autoload.php';
     } else {
         throw new Exception('Unable to load dependencies');
     }