endorphin-studio / browser-detector

src/Detector.php

Doc Comments +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
     }
 
     /**
-     * @param $version Windows number version
+     * @param string $version Windows number version
      * @return string Windows version
      */
     private static function getWindowsVersion($version)

Braces +1 added lines, -2 removed lines

@@ -98,8 +98,7 @@
                 {
                     $object->setVersion(self::getVersion($result, $ua));
                 }
-            }
-            else
+            } else
             {
                 $object = $classname::initEmpty();
             }

Spacing +20 added lines, -20 removed lines

@@ -18,7 +18,7 @@ 
     {
         if ($pathToData == 'auto')
         {
-            $pathToData = str_replace('src', 'data', __DIR__) . '/';
+            $pathToData = str_replace('src', 'data', __DIR__).'/';
         }
 
         if (self::$xmlData == null)
@@ -26,16 +26,16 @@ 
             $xml = array('Robot', 'Browser', 'Device', 'OS');
             $xmlData = array();
             foreach ($xml as $name) {
-                $xmlData[$name] = simplexml_load_file($pathToData . strtolower($name) . '.xml');
+                $xmlData[$name] = simplexml_load_file($pathToData.strtolower($name).'.xml');
             }
             self::$xmlData = $xmlData;
         }
     }
 
-    public static function analyse($uaString='UA', $pathToData='auto')
+    public static function analyse($uaString = 'UA', $pathToData = 'auto')
     {
         $ua = $uaString;
-        if($uaString == 'UA')
+        if ($uaString == 'UA')
         {
             $ua = $_SERVER['HTTP_USER_AGENT'];
         }
@@ -47,14 +47,14 @@ 
         $detectorResult->uaString = $ua;
         $ns = '\\EndorphinStudio\\Detector\\';
 
-        foreach($xml as $key => $item)
+        foreach ($xml as $key => $item)
         {
-            $data = self::analysePart($xml,$key,$ua);
+            $data = self::analysePart($xml, $key, $ua);
             $classname = $ns.$key;
-            if($data !== null)
+            if ($data !== null)
             {
                 $object = new $classname($data);
-                if($key == 'OS' || $key == 'Browser')
+                if ($key == 'OS' || $key == 'Browser')
                 {
                     $object->setVersion(self::getVersion($data, $ua));
                 }
@@ -77,13 +77,13 @@ 
      * @param string $uaString User agent
      * @return \SimpleXMLElement xml element
      */
-    private static function analysePart($xmlData,$key,$uaString)
+    private static function analysePart($xmlData, $key, $uaString)
     {
         $data = $xmlData[$key]->data;
-        foreach($data as $xmlItem)
+        foreach ($data as $xmlItem)
         {
             $pattern = '/'.$xmlItem->pattern.'/';
-            if(preg_match($pattern,$uaString))
+            if (preg_match($pattern, $uaString))
             {
                 return $xmlItem;
             }
@@ -96,21 +96,21 @@ 
      * @param string $uaString User agent
      * @return string Version
      */
-    private static function getVersion(\SimpleXMLElement $xmlItem,$uaString)
+    private static function getVersion(\SimpleXMLElement $xmlItem, $uaString)
     {
-        if($xmlItem !== null)
+        if ($xmlItem !== null)
         {
-            foreach($xmlItem->children() as $node)
+            foreach ($xmlItem->children() as $node)
             {
-                if($node->getName() == 'versionPattern')
+                if ($node->getName() == 'versionPattern')
                 {
                     $vPattern = $node->__toString();
-                    $version = '/' . $vPattern . '(\/| )[\w-._]{1,15}/';
+                    $version = '/'.$vPattern.'(\/| )[\w-._]{1,15}/';
                     $uaString = str_replace(' NT', '', $uaString);
                     if (preg_match($version, $uaString)) {
                         preg_match($version, $uaString, $v);
                         $version = $v[0];
-                        $version = preg_replace('/' . $vPattern . '/', '', $version);
+                        $version = preg_replace('/'.$vPattern.'/', '', $version);
                         $version = str_replace(';', '', $version);
                         $version = str_replace(' ', '', $version);
                         $version = str_replace('/', '', $version);
@@ -154,14 +154,14 @@ 
     private static function checkRules(DetectorResult $result)
     {
         $Rules = DetectorRule::loadRulesFromFile();
-        foreach($Rules as $rule)
+        foreach ($Rules as $rule)
         {
             $objectType = $rule->getObjectType();
             $objectProperty = $rule->getObjectProperty();
             $targetType = $rule->getTargetType();
             $targetValue = $rule->isTargetValue();
             $func = 'get'.$objectProperty;
-            if($result->$objectType !== null)
+            if ($result->$objectType !== null)
             {
                 if ($result->$objectType->$func() == $rule->getObjectPropertyValue()) {
                     $result->$targetType = $targetValue;
@@ -172,4 +172,4 @@ 
         return $result;
     }
 }
-define('D_NA','N\A');
+define('D_NA', 'N\A');

src/Device.php

Braces +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
         {
             $this->Name = 'Desktop';
             $this->Type = 'desktop';
-        }
-        else
+        } else
         {
             parent::__construct($xmlData);
 

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData === null || $xmlData->getName() == 'null')
+        if ($xmlData === null || $xmlData->getName() == 'null')
         {
             parent::__construct($xmlData);
 

src/OS.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
     public function __construct(\SimpleXMLElement $xmlData)
     {
         parent::__construct($xmlData);
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName()) {
@@ -46,6 +46,6 @@ 
 
 }
 
-define('UNX','unix');
-define('WIN','windows');
-define('MC','mac');
+define('UNX', 'unix');
+define('WIN', 'windows');
+define('MC', 'mac');

src/Data.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
     {
         parent::__construct($xmlData);
 
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {

src/Robot.php

Spacing +4 added lines, -4 removed lines

@@ -72,19 +72,19 @@
     {
         parent::__construct($xmlData);
 
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
                 $name = $child->getName();
                 $val = $child->__toString();
-                if($name != 'id' && $name != 'pattern' && $name != 'SearchEngine')
+                if ($name != 'id' && $name != 'pattern' && $name != 'SearchEngine')
                 {
                     $this->$name = $val;
                 }
-                if($name == 'SearchEngine')
+                if ($name == 'SearchEngine')
                 {
-                    if($val == 'true')
+                    if ($val == 'true')
                     {
                         $this->setSearchEngine(true);
                     }

Braces +2 added lines, -2 removed lines

@@ -87,9 +87,9 @@
                     if($val == 'true')
                     {
                         $this->setSearchEngine(true);
+                    } else {
+                                            $this->setSearchEngine(false);
                     }
-                    else
-                        $this->setSearchEngine(false);
                 }
             }
         }

src/DetectorRule.php

Spacing +6 added lines, -6 removed lines

@@ -104,13 +104,13 @@ 
 
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
                 $name = $child->getName();
                 $val = $child->__toString();
-                if($name != 'TargetValue')
+                if ($name != 'TargetValue')
                 {
                     $this->$name = $val;
                 }
@@ -125,15 +125,15 @@ 
      */
     public static function loadRulesFromFile()
     {
-        $path = str_replace('src','data',__DIR__).'/rules/';
+        $path = str_replace('src', 'data', __DIR__).'/rules/';
         $files = scandir($path);
         $rules = array();
-        foreach($files as $file)
+        foreach ($files as $file)
         {
-            if($file != '.' && $file != '..')
+            if ($file != '.' && $file != '..')
             {
                 $xmlObj = simplexml_load_file($path.$file);
-                foreach($xmlObj->children() as $rule)
+                foreach ($xmlObj->children() as $rule)
                 {
                     $rules[] = new self($rule);
                 }

Braces +2 added lines, -2 removed lines

@@ -113,9 +113,9 @@
                 if($name != 'TargetValue')
                 {
                     $this->$name = $val;
+                } else {
+                                    $this->$name = filter_var($val, FILTER_VALIDATE_BOOLEAN);
                 }
-                else
-                    $this->$name = filter_var($val, FILTER_VALIDATE_BOOLEAN);
             }
         }
     }