endorphin-studio / browser-detector

src/Device.php

Braces +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
         {
             $this->Name = 'Desktop';
             $this->Type = 'desktop';
-        }
-        else
+        } else
         {
             parent::__construct($xmlData);
 

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData === null || $xmlData->getName() == 'null')
+        if ($xmlData === null || $xmlData->getName() == 'null')
         {
             parent::__construct($xmlData);
 

src/OS.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
     public function __construct(\SimpleXMLElement $xmlData)
     {
         parent::__construct($xmlData);
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName()) {
@@ -46,6 +46,6 @@ 
 
 }
 
-define('UNX','unix');
-define('WIN','windows');
-define('MC','mac');
+define('UNX', 'unix');
+define('WIN', 'windows');
+define('MC', 'mac');

tests/BrowserTest.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
      */
     public function testFirefox()
     {
-        $this->assertEquals('Firefox',Detector::analyse('Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 ')->Browser->getName());
+        $this->assertEquals('Firefox', Detector::analyse('Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 ')->Browser->getName());
     }
 
     /**
@@ -25,7 +25,7 @@ 
      */
     public function testOpera()
     {
-        $this->assertEquals('Opera',Detector::analyse('Opera/9.80 (X11; Linux i686; Ubuntu/14.10) Presto/2.12.388 Version/12.16')->Browser->getName());
+        $this->assertEquals('Opera', Detector::analyse('Opera/9.80 (X11; Linux i686; Ubuntu/14.10) Presto/2.12.388 Version/12.16')->Browser->getName());
     }
 
 

src/Data.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
     {
         parent::__construct($xmlData);
 
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {

tests/DeviceTest.php

Spacing +5 added lines, -5 removed lines

@@ -21,8 +21,8 @@ 
             'Mozilla/5.0 (iPhone; U; CPU like Mac OS X; en) AppleWebKit/420+ (KHTML, like Gecko) Version/3.0 Mobile/1A543 Safari/419.3'
         );
 
-        testUaList($this,'Device','Name',$ualist,'iPhone');
-        testUaListIsProperty($this,'isMobile',$ualist,true);
+        testUaList($this, 'Device', 'Name', $ualist, 'iPhone');
+        testUaListIsProperty($this, 'isMobile', $ualist, true);
     }
 
     public function testIPad()
@@ -34,7 +34,7 @@ 
             'Mozilla/5.0 (iPad; CPU OS 5_1_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Mobile/9B206'
         );
 
-        testUaList($this,'Device','Name',$ualist,'iPad');
+        testUaList($this, 'Device', 'Name', $ualist, 'iPad');
     }
 
     public function testLumia()
@@ -46,7 +46,7 @@ 
             'Mozilla/5.0 (compatible; MSIE 9.0; Windows Phone OS 7.5; Trident/5.0; IEMobile/9.0; NOKIA; Lumia 900)'
         );
 
-        testUaList($this,'Device','Name',$ualist,'Lumia');
-        testUaListIsProperty($this,'isMobile',$ualist,true);
+        testUaList($this, 'Device', 'Name', $ualist, 'Lumia');
+        testUaListIsProperty($this, 'isMobile', $ualist, true);
     }
 }

tests/OsTest.php

Spacing +3 added lines, -3 removed lines

@@ -18,7 +18,7 @@ 
             'Mozilla/1.1I (X11; I; UNIX_SV 4.2MP R4000)',
         );
 
-        testUaList($this,'OS','Name',$ualist,'Linux');
+        testUaList($this, 'OS', 'Name', $ualist, 'Linux');
     }
 
     public function testAIX()
@@ -27,7 +27,7 @@ 
             'Mozilla/4.04j2 [en] (X11; I; AIX 4.2) ',
         );
 
-        testUaList($this,'OS','Name',$ualist,'AIX');
+        testUaList($this, 'OS', 'Name', $ualist, 'AIX');
     }
 
     public function testAliyunOS()
@@ -36,6 +36,6 @@ 
             'Mozilla/5.0 (Linux; U; AliyunOS 2.0; Android 4.0 Compatible; xx; R819T Build/AliyunOs-2012) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30',
         );
 
-        testUaList($this,'OS','Name',$ualist,'Aliyun OS');
+        testUaList($this, 'OS', 'Name', $ualist, 'Aliyun OS');
     }
 }
\ No newline at end of file

tests/bootstrap.php

Spacing +16 added lines, -16 removed lines

@@ -7,15 +7,15 @@ 
  * @project browser-detector
  */
 
-$vendor = realpath(__DIR__ . '/../vendor/');
+$vendor = realpath(__DIR__.'/../vendor/');
 
-define('__SRC__',str_replace('tests','src',__DIR__));
-if (file_exists($vendor . '/autoload.php')) {
-    require $vendor . '/autoload.php';
+define('__SRC__', str_replace('tests', 'src', __DIR__));
+if (file_exists($vendor.'/autoload.php')) {
+    require $vendor.'/autoload.php';
 } else {
-    $vendor = realpath(__DIR__ . '/../../../');
-    if (file_exists($vendor . '/autoload.php')) {
-        require $vendor . '/autoload.php';
+    $vendor = realpath(__DIR__.'/../../../');
+    if (file_exists($vendor.'/autoload.php')) {
+        require $vendor.'/autoload.php';
     } else {
         throw new Exception('Unable to load dependencies');
     }
@@ -28,30 +28,30 @@ 
 $loader->addPrefix('EndorphinStudio\\Detector', __SRC__);
 $loader->register();
 
-function testUaList($object,$detectorProperty,$property,$uaList,$expectedValue)
+function testUaList($object, $detectorProperty, $property, $uaList, $expectedValue)
 {
-    foreach($uaList as $ua)
+    foreach ($uaList as $ua)
     {
         $obj = Detector::analyse($ua)->$detectorProperty;
         $func = 'get'.$property;
-        $object->assertEquals($expectedValue,$obj->$func());
+        $object->assertEquals($expectedValue, $obj->$func());
     }
 }
 
-function testUaListBooleanTrue($object,$detectorProperty,$property,$uaList)
+function testUaListBooleanTrue($object, $detectorProperty, $property, $uaList)
 {
-    foreach($uaList as $ua)
+    foreach ($uaList as $ua)
     {
         $obj = Detector::analyse($ua)->$detectorProperty;
         $func = 'is'.$property;
-        $object->assertTrue($obj->$func(),'Object Property '.$property.' is no equal TRUE');
+        $object->assertTrue($obj->$func(), 'Object Property '.$property.' is no equal TRUE');
     }
 }
 
-function testUaListIsProperty($object,$detectorProperty,$uaList,$expectedValue)
+function testUaListIsProperty($object, $detectorProperty, $uaList, $expectedValue)
 {
-    foreach($uaList as $ua)
+    foreach ($uaList as $ua)
     {
-        $object->assertEquals($expectedValue,Detector::analyse($ua)->$detectorProperty);
+        $object->assertEquals($expectedValue, Detector::analyse($ua)->$detectorProperty);
     }
 }
\ No newline at end of file

src/Robot.php

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
     {
         parent::__construct($xmlData);
 
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
@@ -86,7 +86,7 @@ 
                         break;
                     case 'isse':
                         $val = $child->__toString();
-                        if($val == 'true')
+                        if ($val == 'true')
                         {
                             $this->setSearchEngine(true);
                         }

Braces +2 added lines, -2 removed lines

@@ -89,9 +89,9 @@
                         if($val == 'true')
                         {
                             $this->setSearchEngine(true);
+                        } else {
+                                                    $this->setSearchEngine(false);
                         }
-                        else
-                            $this->setSearchEngine(false);
                         break;
                 }
             }

src/DetectorRule.php

Spacing +6 added lines, -6 removed lines

@@ -104,7 +104,7 @@ 
 
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName())
@@ -123,7 +123,7 @@ 
                         break;
                     case 'targetProperty':
                         $boolVal = $child->__toString();
-                        if($boolVal == 'true')
+                        if ($boolVal == 'true')
                         {
                             $this->TargetValue = true;
                         }
@@ -142,15 +142,15 @@ 
      */
     public static function loadRulesFromFile()
     {
-        $path = str_replace('src','data',__DIR__).'/rules/';
+        $path = str_replace('src', 'data', __DIR__).'/rules/';
         $files = scandir($path);
         $rules = array();
-        foreach($files as $file)
+        foreach ($files as $file)
         {
-            if($file != '.' && $file != '..')
+            if ($file != '.' && $file != '..')
             {
                 $xmlObj = simplexml_load_file($path.$file);
-                foreach($xmlObj->children() as $rule)
+                foreach ($xmlObj->children() as $rule)
                 {
                     $rules[] = new self($rule);
                 }

Braces +1 added lines, -2 removed lines

@@ -126,8 +126,7 @@
                         if($boolVal == 'true')
                         {
                             $this->TargetValue = true;
-                        }
-                        else
+                        } else
                         {
                             $this->TargetValue = false;
                         }