endorphin-studio / browser-detector

oldSrc/Result/DeviceModel.php

Spacing +3 added lines, -3 removed lines

@@ -68,7 +68,7 @@ 
 
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
@@ -84,10 +84,10 @@ 
      */
     public static function loadFromFile()
     {
-        $path = str_replace('src','data',__DIR__).'/deviceModels.xml';
+        $path = str_replace('src', 'data', __DIR__).'/deviceModels.xml';
         $models = array();
         $xmlObj = simplexml_load_file($path);
-        foreach($xmlObj->children() as $rule)
+        foreach ($xmlObj->children() as $rule)
         {
             $models[] = new self($rule);
         }

oldSrc/Result/Data.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      */
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName()) {

oldSrc/Result/Robot.php

Spacing +4 added lines, -4 removed lines

@@ -72,19 +72,19 @@
     {
         parent::__construct($xmlData);
 
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
                 $name = $child->getName();
                 $val = $child->__toString();
-                if($name != 'id' && $name != 'pattern' && $name != 'SearchEngine')
+                if ($name != 'id' && $name != 'pattern' && $name != 'SearchEngine')
                 {
                     $this->$name = $val;
                 }
-                if($name == 'SearchEngine')
+                if ($name == 'SearchEngine')
                 {
-                    if($val == 'true')
+                    if ($val == 'true')
                     {
                         $this->setSearchEngine(true);
                     }

Braces +2 added lines, -2 removed lines

@@ -87,9 +87,9 @@
                     if($val == 'true')
                     {
                         $this->setSearchEngine(true);
+                    } else {
+                                            $this->setSearchEngine(false);
                     }
-                    else
-                        $this->setSearchEngine(false);
                 }
             }
         }

oldSrc/Result/Device.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData === null || $xmlData->getName() == 'null')
+        if ($xmlData === null || $xmlData->getName() == 'null')
         {
             parent::__construct($xmlData);
 

Braces +1 added lines, -2 removed lines

@@ -43,8 +43,7 @@
 
             $this->setName('Desktop');
             $this->setType('desktop');
-        }
-        else
+        } else
         {
             parent::__construct($xmlData);
 

oldSrc/Result/DetectorRule.php

Spacing +6 added lines, -6 removed lines

@@ -104,13 +104,13 @@ 
 
     public function __construct(\SimpleXMLElement $xmlData)
     {
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child)
             {
                 $name = $child->getName();
                 $val = $child->__toString();
-                if($name != 'TargetValue')
+                if ($name != 'TargetValue')
                 {
                     $this->$name = $val;
                 }
@@ -125,15 +125,15 @@ 
      */
     public static function loadRulesFromFile()
     {
-        $path = str_replace('src','data',__DIR__).'/rules/';
+        $path = str_replace('src', 'data', __DIR__).'/rules/';
         $files = scandir($path);
         $rules = array();
-        foreach($files as $file)
+        foreach ($files as $file)
         {
-            if($file != '.' && $file != '..')
+            if ($file != '.' && $file != '..')
             {
                 $xmlObj = simplexml_load_file($path.$file);
-                foreach($xmlObj->children() as $rule)
+                foreach ($xmlObj->children() as $rule)
                 {
                     $rules[] = new self($rule);
                 }

Braces +2 added lines, -2 removed lines

@@ -113,9 +113,9 @@
                 if($name != 'TargetValue')
                 {
                     $this->$name = $val;
+                } else {
+                                    $this->$name = filter_var($val, FILTER_VALIDATE_BOOLEAN);
                 }
-                else
-                    $this->$name = filter_var($val, FILTER_VALIDATE_BOOLEAN);
             }
         }
     }

oldSrc/Result/OS.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
     public function __construct(\SimpleXMLElement $xmlData)
     {
         parent::__construct($xmlData);
-        if($xmlData !== null)
+        if ($xmlData !== null)
         {
             foreach ($xmlData->children() as $child) {
                 switch ($child->getName()) {
@@ -46,6 +46,6 @@ 
 
 }
 
-define('UNX','unix');
-define('WIN','windows');
-define('MC','mac');
+define('UNX', 'unix');
+define('WIN', 'windows');
+define('MC', 'mac');

src/YamlLoader.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
     {
         $parameters = [];
         $parser = new Parser();
-        $dataDir = \dirname(__DIR__) . '/var/data/';
+        $dataDir = \dirname(__DIR__).'/var/data/';
         foreach (new \DirectoryIterator($dataDir) as $file) {
             if ($file->getExtension() === '.yml') {
                 $data = $parser->parseFile($file->getRealPath());
@@ -56,7 +56,7 @@ 
     public function getParameter(string $name): array
     {
         if (!array_key_exists($name, $this->parameters)) {
-            throw new DetectorException(sprintf('% not exist in data' . $name), 1);
+            throw new DetectorException(sprintf('% not exist in data'.$name), 1);
         }
         return $this->parameters[$name];
     }