DeviceDetector::initResultObject() - Code Metrics - Inspection of "Version 4.0" - endorphin-studio/browser-detector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 604d5a...33061c )

by Serhii

created 2018-08-28 14:50 UTC

DeviceDetector::initResultObject() A

↳ Parent: DeviceDetector

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.9666
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php


namespace EndorphinStudio\Detector\Detection;

use EndorphinStudio\Detector\Tools;

class DeviceDetector extends BrowserDetector
{
    public function detect(string $ua)
    {
        $this->config = $this->detector->getPatternList($this->detector->getDataProvider()->getConfig(), 'device');
        $this->initResultObject();
        $this->setupResultObject();
    }


    private function initResultObject()

    {
        $result = $this->detector->getResultObject()->getDevice();

        // init default value from data
        foreach ($this->config['default'] as $defaultKey => $defaultValue) {
            Tools::runSetter($result, $defaultKey, $defaultValue);
        }
    }

    private function setupResultObject()

    {
        $result = $this->detector->getResultObject()->getDevice();
        $browserData = $this->detectByType();
        foreach ($browserData as $key => $value) {
            if ($key === 'originalInfo') {
                $this->setAttributes($value);
                continue;
            }
            Tools::runSetter($result, $key, $value);
        }
    }
}

1		<?php
2
3
4		namespace EndorphinStudio\Detector\Detection;
5
6		use EndorphinStudio\Detector\Tools;
7
8		class DeviceDetector extends BrowserDetector
9		{
10		public function detect(string $ua)
11		{
12		$this->config = $this->detector->getPatternList($this->detector->getDataProvider()->getConfig(), 'device');
13		$this->initResultObject();
14		$this->setupResultObject();
15		}
16
17
18	View Code Duplication	private function initResultObject()
		0 ignored issues – show Bug introduced 2018-08-28 14:52 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Duplication introduced 2018-08-28 14:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$result = $this->detector->getResultObject()->getDevice();
21
22		// init default value from data
23		foreach ($this->config['default'] as $defaultKey => $defaultValue) {
24		Tools::runSetter($result, $defaultKey, $defaultValue);
25		}
26		}
27
28	View Code Duplication	private function setupResultObject()
		0 ignored issues – show Bug introduced 2018-08-28 14:52 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Duplication introduced 2018-08-28 14:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$result = $this->detector->getResultObject()->getDevice();
31		$browserData = $this->detectByType();
32		foreach ($browserData as $key => $value) {
33		if ($key === 'originalInfo') {
34		$this->setAttributes($value);
35		continue;
36		}
37		Tools::runSetter($result, $key, $value);
38		}
39		}
40		}

endorphin-studio / browser-detector

Push — 4.0 ( 604d5a...33061c )

DeviceDetector::initResultObject() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like