EndorphinStudio\Detector\Detection\DeviceDetector

Complexity

Total Complexity

6

Size/Duplication

Total Lines	33
Duplicated Lines	63.64 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	detect()	0	6	1
A	initResultObject()	9	9	2
A	setupResultObject()	12	12	3

<?php


namespace EndorphinStudio\Detector\Detection;

use EndorphinStudio\Detector\Tools;

class DeviceDetector extends BrowserDetector
{
    public function detect(string $ua)
    {
        $this->config = $this->detector->getPatternList($this->detector->getDataProvider()->getConfig(), 'device');
        $this->initResultObject();
        $this->setupResultObject();
    }


    private function initResultObject()

Consider using a different method name as you override a private method of the parent class.

This method seems to be duplicated in your project.

    {
        $result = $this->detector->getResultObject()->getDevice();

        // init default value from data
        foreach ($this->config['default'] as $defaultKey => $defaultValue) {
            Tools::runSetter($result, $defaultKey, $defaultValue);
        }
    }

    private function setupResultObject()

Consider using a different method name as you override a private method of the parent class.

This method seems to be duplicated in your project.

    {
        $result = $this->detector->getResultObject()->getDevice();
        $browserData = $this->detectByType();
        foreach ($browserData as $key => $value) {
            if ($key === 'originalInfo') {
                $this->setAttributes($value);
                continue;
            }
            Tools::runSetter($result, $key, $value);
        }
    }
}