edno / kleis

app/Account.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Database\Eloquent\Model;
 use App\User;
-
 use WhiteHat101\Crypt\APR1_MD5;
 
 class Account extends Model

Spacing +4 added lines, -4 removed lines

@@ -13,12 +13,12 @@
     const ACCOUNT_ENABLE = 1;
 
     const ACCOUNT_STATUS = [
-        0 => [  'text' => 'accounts.disabled',
+        0 => ['text' => 'accounts.disabled',
                 'icon' => 'fa-ban',
-                'unicon' => '' ],
-        1 => [  'text' => 'accounts.enabled',
+                'unicon' => ''],
+        1 => ['text' => 'accounts.enabled',
                 'icon' => 'fa-globe',
-                'unicon' => '' ]
+                'unicon' => '']
     ];
 
     const SEARCH_CRITERIA = [

app/Console/Commands/ExportWhitelists.php

Doc Comments +3 added lines

@@ -50,6 +50,9 @@
         }
     }
 
+    /**
+     * @param boolean $isWhiteList
+     */
     private function exportProxyList($type, $isWhiteList)
     {
         $items = ProxyListItem::where('type', $type)

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     public function handle()
     {
         $whitelist = empty($this->option('blacklist'));
-        if ( false === empty($this->option('list'))) {
+        if (false === empty($this->option('list'))) {
             $this->exportProxyList($this->option('list'), $whitelist);
         } else {
             $this->exportProxyList('domain', $whitelist);

app/Console/Commands/UpdateAccounts.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Console\Command;
 use App\Account;
-use Storage;
 
 class UpdateAccounts extends Command
 {

app/Http/Controllers/AccountController.php

Doc Comments +2 added lines, -2 removed lines

@@ -108,7 +108,7 @@ 
     /**
      * Add a new account.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function addAccount(Request $request)
     {
@@ -149,7 +149,7 @@ 
      *
      * @param  Request  $request
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function updateAccount(Request $request, $id)
     {

Unused Use Statements -3 removed lines

@@ -3,9 +3,6 @@
 namespace App\Http\Controllers;
 
 use Illuminate\Http\Request;
-use Illuminate\Routing\UrlGenerator as Url;
-
-use App\Http\Requests;
 use App\Account;
 use App\Group;
 use App\Category;

app/Http/Controllers/AdminController.php

Doc Comments +5 added lines, -5 removed lines

@@ -76,7 +76,7 @@ 
     /**
      * Add a new user.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function addUser(Request $request)
     {
@@ -114,7 +114,7 @@ 
      *
      * @param  Request  $request
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function updateUser(Request $request, $id = 0)
     {
@@ -169,7 +169,7 @@ 
      * Enable an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function enableUser($id)
     {
@@ -186,7 +186,7 @@ 
      * Disable an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function disableUser($id)
     {
@@ -203,7 +203,7 @@ 
      * Remove an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function removeUser($id)
     {

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Http\Controllers;
 
 use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\User;
 use App\Group;
 use Auth;

app/Http/Controllers/CategoryController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Http\Controllers;
 
 use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\Category;
 
 class CategoryController extends Controller

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
     {
         $category = Category::findOrFail($id);
         $accounts = $category->accounts()->where('status', 0);
-        if (count($accounts) > 0 ) {
+        if (count($accounts) > 0) {
             $accounts->delete();
         }
         return redirect()->back()->with(

app/Http/Controllers/HomeController.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use App\Http\Requests;
-use Illuminate\Http\Request;
-
 use App\Account;
 use App\Group;
 use App\ProxyListItem;

Spacing +11 added lines, -11 removed lines

@@ -42,12 +42,12 @@ 
 
     private function accountSummary()
     {
-        $list = [ 'total' => 0, 'summary' => []];
+        $list = ['total' => 0, 'summary' => []];
         $categories = Category::orderBy('name', 'asc')->get();
         foreach ($categories as $category) {
             $count = Account::where('category_id', $category->id)->count();
             if ($count) {
-                $list['summary'][]= [
+                $list['summary'][] = [
                     'count' => $count,
                     'text' => $category->name
                 ];
@@ -59,11 +59,11 @@ 
 
     private function groupSummary()
     {
-        $list = [ 'total' => 0, 'summary' => []];
+        $list = ['total' => 0, 'summary' => []];
         $groups = Group::orderBy('name', 'asc')->get();
         foreach ($groups as $group) {
             $count = Account::where('group_id', $group->id)->count();
-            $list['summary'][]= [
+            $list['summary'][] = [
                 'count' => $count,
                 'text' => $group->name
             ];
@@ -74,11 +74,11 @@ 
 
     private function categorySummary()
     {
-        $list = [ 'total' => 0, 'summary' => []];
+        $list = ['total' => 0, 'summary' => []];
         $categories = Category::get();
         foreach ($categories as $category) {
             $count = Account::where('category_id', $category->id)->count();
-            $list['summary'][]= [
+            $list['summary'][] = [
                 'count' => $count,
                 'text' => $category->name
             ];
@@ -89,12 +89,12 @@ 
 
     private function listSummary()
     {
-        $list = [ 'total' => 0, 'summary' => [] ];
-        $types = [ 'domain', 'url' ];
+        $list = ['total' => 0, 'summary' => []];
+        $types = ['domain', 'url'];
         foreach ($types as $type) {
             $count = ProxyListItem::where('type', $type)->count();
             if ($count) {
-                $list['summary'][]= [
+                $list['summary'][] = [
                     'count' => $count,
                     'text' => "{$type}s"
                 ];
@@ -106,11 +106,11 @@ 
 
     private function userSummary()
     {
-        $list = [ 'total' => 0, 'summary' => []];
+        $list = ['total' => 0, 'summary' => []];
         foreach (User::USER_LEVEL as $id => $level) {
             $count = User::where('level', $id)->count();
             if ($count) {
-                $list['summary'][]= [
+                $list['summary'][] = [
                     'count' => $count,
                     'text' => $level['text']
                 ];

app/Http/Controllers/InstallerController.php

Doc Comments +3 added lines, -4 removed lines

@@ -48,7 +48,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepStoreApp(Request $request, Redirector $redirect)
     {
@@ -75,7 +75,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepStoreDb(Request $request, Redirector $redirect)
     {
@@ -161,7 +161,6 @@ 
     /**
      * Processes the newly saved environment configuration and continue.
      *
-     * @param Request $input
      * @param Redirector $redirect
      * @return \Illuminate\Http\RedirectResponse
      */
@@ -205,7 +204,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepMigrate(DatabaseManager $databaseManager)
     {

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use Validator;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Redirector;
-use Illuminate\Support\Facades\Artisan;
-use App\Http\Requests;
 use App\Http\Helpers\Installer\DatabaseManager;
 use App\Http\Helpers\Installer\EnvironmentManager;
 use App\Http\Helpers\Installer\PermissionsChecker;

Indentation +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
         $response = $databaseManager->migrateAndSeed();
 
         return redirect()->route('KleisInstaller::stepFinal')
-                         ->with(['message' => $response]);
+                            ->with(['message' => $response]);
     }
 
     /**

Spacing +3 added lines, -3 removed lines

@@ -130,12 +130,12 @@ 
             }
         }
 
-        if(!empty($request->announce)) {
+        if (!empty($request->announce)) {
             $filename = 'announce.md';
             $mdfile = public_path("markdown/{$filename}");
             try {
                 file_put_contents($mdfile, $request->announce);
-            }  catch(Exception $e) {
+            } catch (Exception $e) {
                 return $redirect->route('KleisInstaller::stepCustomization')
                                 ->withInput();
             }
@@ -169,7 +169,7 @@ 
     {
         $status = $environmentManager->saveFile($request);
 
-        if($status) {
+        if ($status) {
             return $redirect->route('KleisInstaller::stepRequirements')
                             ->with(['message' => session('message')]);
         } else {

Braces +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
             $mdfile = public_path("markdown/{$filename}");
             try {
                 file_put_contents($mdfile, $request->announce);
-            }  catch(Exception $e) {
+            } catch(Exception $e) {
                 return $redirect->route('KleisInstaller::stepCustomization')
                                 ->withInput();
             }

app/Http/Controllers/ProxyListItemController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Http\Controllers;
 
 use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\ProxyListItem;
 
 class ProxyListItemController extends Controller