edno / kleis

app/Account.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Database\Eloquent\Model;
 use App\User;
-
 use WhiteHat101\Crypt\APR1_MD5;
 
 class Account extends Model

Spacing +4 added lines, -4 removed lines

@@ -13,12 +13,12 @@
     const ACCOUNT_ENABLE = 1;
 
     const ACCOUNT_STATUS = [
-        0 => [  'text' => 'accounts.disabled',
+        0 => ['text' => 'accounts.disabled',
                 'icon' => 'fa-ban',
-                'unicon' => '' ],
-        1 => [  'text' => 'accounts.enabled',
+                'unicon' => ''],
+        1 => ['text' => 'accounts.enabled',
                 'icon' => 'fa-globe',
-                'unicon' => '' ]
+                'unicon' => '']
     ];
 
     const SEARCH_CRITERIA = [

app/Console/Commands/ExportWhitelists.php

Doc Comments +3 added lines

@@ -50,6 +50,9 @@
         }
     }
 
+    /**
+     * @param boolean $isWhiteList
+     */
     private function exportProxyList($type, $isWhiteList)
     {
         $items = ProxyListItem::where('type', $type)

Indentation +4 added lines, -4 removed lines

@@ -66,19 +66,19 @@
 
         $flagCI = $this->option('ci');
         if ($flagCI === false) {
-          $bar = $this->output->createProgressBar($count);
+            $bar = $this->output->createProgressBar($count);
         }
 
         foreach ($items as $item) {
             $this->storage->prepend($filename, "{$item->value}");
             if (isset($bar)) {
-              $bar->advance();
+                $bar->advance();
             }
         }
 
         if (isset($bar)) {
-          $bar->finish();
-          $this->info("\n");
+            $bar->finish();
+            $this->info("\n");
         }
 
         try {

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
     public function handle()
     {
         $whitelist = empty($this->option('blacklist'));
-        if ( false === empty($this->option('list'))) {
+        if (false === empty($this->option('list'))) {
             $this->exportProxyList($this->option('list'), $whitelist);
         } else {
             $this->exportProxyList('domain', $whitelist);
@@ -83,7 +83,7 @@ 
 
         try {
             $url = $this->exportToLocation($filename);
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             $this->error('Export cancelled by user!');
             return;
         }

app/Http/Controllers/AccountController.php

Doc Comments +2 added lines, -2 removed lines

@@ -108,7 +108,7 @@ 
     /**
      * Add a new account.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function addAccount(Request $request)
     {
@@ -149,7 +149,7 @@ 
      *
      * @param  Request  $request
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function updateAccount(Request $request, $id)
     {

app/Http/Controllers/AdminController.php

Doc Comments +5 added lines, -5 removed lines

@@ -76,7 +76,7 @@ 
     /**
      * Add a new user.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function addUser(Request $request)
     {
@@ -114,7 +114,7 @@ 
      *
      * @param  Request  $request
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function updateUser(Request $request, $id = 0)
     {
@@ -169,7 +169,7 @@ 
      * Enable an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function enableUser($id)
     {
@@ -186,7 +186,7 @@ 
      * Disable an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function disableUser($id)
     {
@@ -203,7 +203,7 @@ 
      * Remove an user.
      *
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function removeUser($id)
     {

app/Http/Controllers/InstallerController.php

Doc Comments +3 added lines, -4 removed lines

@@ -48,7 +48,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepStoreApp(Request $request, Redirector $redirect)
     {
@@ -75,7 +75,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepStoreDb(Request $request, Redirector $redirect)
     {
@@ -161,7 +161,6 @@ 
     /**
      * Processes the newly saved environment configuration and continue.
      *
-     * @param Request $input
      * @param Redirector $redirect
      * @return \Illuminate\Http\RedirectResponse
      */
@@ -205,7 +204,7 @@ 
     /**
      * XXXXXXXXXX
      *
-     * @return \Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function stepMigrate(DatabaseManager $databaseManager)
     {

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use Validator;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Redirector;
-use Illuminate\Support\Facades\Artisan;
-use App\Http\Requests;
 use App\Http\Helpers\Installer\DatabaseManager;
 use App\Http\Helpers\Installer\EnvironmentManager;
 use App\Http\Helpers\Installer\PermissionsChecker;

Indentation +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
         $response = $databaseManager->migrateAndSeed();
 
         return redirect()->route('KleisInstaller::stepFinal')
-                         ->with(['message' => $response]);
+                            ->with(['message' => $response]);
     }
 
     /**

Spacing +3 added lines, -3 removed lines

@@ -130,12 +130,12 @@ 
             }
         }
 
-        if(!empty($request->announce)) {
+        if (!empty($request->announce)) {
             $filename = 'announce.md';
             $mdfile = public_path("markdown/{$filename}");
             try {
                 file_put_contents($mdfile, $request->announce);
-            }  catch(Exception $e) {
+            } catch (Exception $e) {
                 return $redirect->route('KleisInstaller::stepCustomization')
                                 ->withInput();
             }
@@ -169,7 +169,7 @@ 
     {
         $status = $environmentManager->saveFile($request);
 
-        if($status) {
+        if ($status) {
             return $redirect->route('KleisInstaller::stepRequirements')
                             ->with(['message' => session('message')]);
         } else {

Braces +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
             $mdfile = public_path("markdown/{$filename}");
             try {
                 file_put_contents($mdfile, $request->announce);
-            }  catch(Exception $e) {
+            } catch(Exception $e) {
                 return $redirect->route('KleisInstaller::stepCustomization')
                                 ->withInput();
             }

app/Http/Helpers/Installer/PermissionsChecker.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
      *
      * @param $folder
      * @param $permission
-     * @param $isSet
+     * @param boolean $isSet
      */
     private function addFileAndSetErrors($folder, $permission, $isSet)
     {

Spacing +2 added lines, -2 removed lines

@@ -29,9 +29,9 @@
      */
     public function check(array $folders)
     {
-        foreach($folders as $folder => $permission)
+        foreach ($folders as $folder => $permission)
         {
-            if(!($this->getPermission($folder) >= $permission))
+            if (!($this->getPermission($folder) >= $permission))
             {
                 $this->addFileAndSetErrors($folder, $permission, false);
             }

Braces +1 added lines, -2 removed lines

@@ -34,8 +34,7 @@
             if(!($this->getPermission($folder) >= $permission))
             {
                 $this->addFileAndSetErrors($folder, $permission, false);
-            }
-            else {
+            } else {
                 $this->addFile($folder, $permission, true);
             }
         }

app/Http/Middleware/RedirectIfInstalled.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      */
     public function handle($request, Closure $next)
     {
-        if($this->alreadyInstalled() || !config('kleis.installer')) {
+        if ($this->alreadyInstalled() || !config('kleis.installer')) {
             return redirect('/');
         }
 

app/Http/Helpers/Installer/EnvironmentManager.php

Spacing +4 added lines, -4 removed lines

@@ -36,9 +36,9 @@ 
         $data = $request->session()->all();
 
         $env = '';
-        foreach($data as $key => $value) {
-            if(preg_match('/^[A-Z]+_[A-Z]+$/', $key)) {
-                $env .= "${key}=${value}" . PHP_EOL;
+        foreach ($data as $key => $value) {
+            if (preg_match('/^[A-Z]+_[A-Z]+$/', $key)) {
+                $env .= "${key}=${value}".PHP_EOL;
             }
         }
 
@@ -58,7 +58,7 @@ 
 
         try {
             file_put_contents($this->envPath, $request->get('envConfig'));
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             $status = false;
         }
 

Doc Comments +1 added lines

@@ -29,6 +29,7 @@
     /**
      * Get the content of the .env file.
      *
+     * @param Request $request
      * @return string
      */
     public function getEnvContent($request)

app/Http/Helpers/Installer/RequirementsChecker.php

Spacing +2 added lines, -2 removed lines

@@ -15,11 +15,11 @@
     {
         $results = [];
 
-        foreach($requirements as $requirement)
+        foreach ($requirements as $requirement)
         {
             $results['requirements'][$requirement] = true;
 
-            if(!extension_loaded($requirement))
+            if (!extension_loaded($requirement))
             {
                 $results['requirements'][$requirement] = false;