Inbounder\GatewayManager::__construct()

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __construct(AbstractHandler $handler, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->handler = $handler;

It seems like $handler of type object<Inbounder\AbstractHandler> is incompatible with the declared type object<Inbounder\HandlerInterface> of property $handler.

        $this->request = $request;
        
        $this->parser = $handler->parser();

It seems like $handler->parser() of type object<Inbounder\Parsers\Contracts\ParserInterface> is incompatible with the declared type object<Inbounder\ParserInterface> of property $parser.

        $this->parser->request($request);

The method request() does not seem to exist on object<Inbounder\Parsers\Contracts\ParserInterface>.

    }