Inbounder\GatewayManager

Complexity

Total Complexity

3

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	parse()	0	4	1
A	runHandler()	0	4	1

<?php

namespace Inbounder;

use Illuminate\Http\Request;
use Inbounder\AbstractHandler;

class GatewayManager
{
    /**
     * @var Request
     */
    protected $request;

    /**
     * @var ParserInterface
     */
    protected $parser;

    /**
     * @var HandlerInterface
     */
    protected $handler;

    /**
     * 
     */
    public function __construct(AbstractHandler $handler, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->handler = $handler;

It seems like $handler of type object<Inbounder\AbstractHandler> is incompatible with the declared type object<Inbounder\HandlerInterface> of property $handler.

        $this->request = $request;
        
        $this->parser = $handler->parser();

It seems like $handler->parser() of type object<Inbounder\Parsers\Contracts\ParserInterface> is incompatible with the declared type object<Inbounder\ParserInterface> of property $parser.

        $this->parser->request($request);

The method request() does not seem to exist on object<Inbounder\Parsers\Contracts\ParserInterface>.

    }

    /**
     * Parse the inbound request
     * 
     * @return ParserInterface
     */
    public function parse()
    {
        return $this->parser->parse();
    }

    /**
     * Run the handler
     * 
     * @return ??

The doc-type ?? could not be parsed: Unknown type name "??" at position 0. (view supported doc-types)

     */
    public function runHandler()
    {
        return $this->handler->run($this->parse());
    }
}