edefimov / async-sockets

src/Frame/MarkerFramePicker.php

Spacing +1 added lines, -2 removed lines

@@ -126,7 +126,6 @@
     protected function findMarker($haystack, $needle, $offset = 0)
     {
         return $this->isCaseSensitive ?
-            strpos($haystack, $needle, $offset) :
-            stripos($haystack, $needle, $offset);
+            strpos($haystack, $needle, $offset) : stripos($haystack, $needle, $offset);
     }
 }

Doc Comments +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
      * @param string $needle What to find
      * @param int    $offset Start offset in $haystack
      *
-     * @return bool|int
+     * @return string
      */
     protected function findMarker($haystack, $needle, $offset = 0)
     {

src/Socket/Io/AbstractClientIo.php

Spacing +1 added lines, -2 removed lines

@@ -143,8 +143,7 @@
         $resource = $this->socket->getStreamResource();
         if (!is_resource($resource)) {
             $message = $this->state === self::STATE_CONNECTED ?
-                'Connection was unexpectedly closed.' :
-                'Can not start io operation on uninitialized socket.';
+                'Connection was unexpectedly closed.' : 'Can not start io operation on uninitialized socket.';
             throw new ConnectionException($this->socket, $message);
         }
 

src/RequestExecutor/Pipeline/AbstractStage.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
         return new Event(
             $this->executor,
             $operation->getSocket(),
-            $meta[ RequestExecutorInterface::META_USER_CONTEXT ],
+            $meta[RequestExecutorInterface::META_USER_CONTEXT],
             $eventName
         );
     }

src/RequestExecutor/Pipeline/SelectStage.php

Spacing +2 added lines, -4 removed lines

@@ -127,8 +127,7 @@ 
     private function getMinTimeout($newValue, $oldValue)
     {
         return (($newValue > 0 && $newValue < $oldValue) || $oldValue === null) ?
-            $newValue :
-            $oldValue;
+            $newValue : $oldValue;
     }
 
     /**
@@ -149,8 +148,7 @@ 
         }
 
         $result = $lastOperationTime === null ?
-            $desiredTimeout :
-            $desiredTimeout - ($microTime - $lastOperationTime);
+            $desiredTimeout : $desiredTimeout - ($microTime - $lastOperationTime);
 
         return $result >= 0 ? $result : 0;
     }

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
      * @param RequestDescriptor $operation Operation object
      * @param double            $microTime Current time with microseconds
      *
-     * @return double|null
+     * @return double
      */
     private function getSingleSocketTimeout(RequestDescriptor $operation, $microTime)
     {

src/RequestExecutor/Pipeline/GuardianStage.php

Spacing +2 added lines, -2 removed lines

@@ -115,7 +115,7 @@ 
      */
     private function isZombieCandidate(RequestDescriptor $descriptor)
     {
-        $metadata  = $descriptor->getMetadata();
+        $metadata = $descriptor->getMetadata();
         if ($metadata[RequestExecutorInterface::META_REQUEST_COMPLETE]) {
             return false;
         }
@@ -164,7 +164,7 @@ 
         $event  = new DataAlertEvent(
             $this->executor,
             $socket,
-            $meta[ RequestExecutorInterface::META_USER_CONTEXT ],
+            $meta[RequestExecutorInterface::META_USER_CONTEXT],
             $attempt,
             $totalAttempts
         );

Indentation +2 added lines, -2 removed lines

@@ -123,9 +123,9 @@
         $operation = $descriptor->getOperation();
         return ($operation instanceof NullOperation) ||
                (
-                   $operation instanceof ReadOperation &&
+                    $operation instanceof ReadOperation &&
                    $operation->getFramePicker() instanceof EmptyFramePicker
-               );
+                );
     }
 
     /**

src/RequestExecutor/Pipeline/ExcludedOperationsStage.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 
         foreach ($requestDescriptors as $key => $descriptor) {
             if (in_array($descriptor, $currentOperations, true)) {
-                unset($requestDescriptors[ $key]);
+                unset($requestDescriptors[$key]);
             }
         }
 

src/RequestExecutor/Pipeline/TimeoutStage.php

Indentation +3 added lines, -3 removed lines

@@ -114,10 +114,10 @@
 
         return ($desiredTimeout !== RequestExecutorInterface::WAIT_FOREVER) &&
                (
-                   ($hasConnected && $lastOperationTime !== null) ||
+                    ($hasConnected && $lastOperationTime !== null) ||
                    !$hasConnected
-               ) &&
+                ) &&
                ($microTime - $lastOperationTime >= $desiredTimeout)
-               ;
+                ;
     }
 }

Spacing +2 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
     public function processStage(array $requestDescriptors)
     {
         /** @var RequestDescriptor[] $requestDescriptors */
-        $result    = [ ];
+        $result    = [];
         $microTime = microtime(true);
         foreach ($requestDescriptors as $key => $descriptor) {
             $isTimeout = $this->isSingleSocketTimeout($descriptor, $microTime) &&
@@ -52,8 +52,7 @@ 
             $meta[RequestExecutorInterface::META_USER_CONTEXT],
             $meta[RequestExecutorInterface::META_CONNECTION_FINISH_TIME] !== null &&
             !$descriptor->getSocket()->isServer() ?
-                TimeoutEvent::DURING_IO :
-                TimeoutEvent::DURING_CONNECTION
+                TimeoutEvent::DURING_IO : TimeoutEvent::DURING_CONNECTION
         );
         try {
             $this->callSocketSubscribers($descriptor, $event);

src/Exception/UnmanagedSocketException.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
             $socket,
             sprintf(
                 'System has detected a zombie connection %s and closed it. '.
-                'If you see this message it means that application ' .
+                'If you see this message it means that application '.
                 'has lost control on one of its sockets.',
                 (string) $socket
             )

src/Socket/AsyncSocketFactory.php

Spacing +6 added lines, -8 removed lines

@@ -74,19 +74,17 @@
     {
         switch ($type) {
             case self::SOCKET_CLIENT:
-                $isPersistent  = isset($options[ self::SOCKET_OPTION_IS_PERSISTENT ]) &&
-                                 $options[ self::SOCKET_OPTION_IS_PERSISTENT ];
-                $persistentKey = isset($options[ self::SOCKET_OPTION_PERSISTENT_KEY ]) ?
-                    $options[ self::SOCKET_OPTION_PERSISTENT_KEY ] :
-                    null;
+                $isPersistent  = isset($options[self::SOCKET_OPTION_IS_PERSISTENT]) &&
+                                 $options[self::SOCKET_OPTION_IS_PERSISTENT];
+                $persistentKey = isset($options[self::SOCKET_OPTION_PERSISTENT_KEY]) ?
+                    $options[self::SOCKET_OPTION_PERSISTENT_KEY] : null;
 
                 return $isPersistent ?
-                    new PersistentClientSocket($persistentKey) :
-                    new ClientSocket();
+                    new PersistentClientSocket($persistentKey) : new ClientSocket();
             case self::SOCKET_SERVER:
                 return new ServerSocket();
             default:
-                throw new \InvalidArgumentException("Unexpected type {$type} used in " . __FUNCTION__);
+                throw new \InvalidArgumentException("Unexpected type {$type} used in ".__FUNCTION__);
         }
     }