eclipxe13 /
XmlSchemaValidator
| Conditions | 3 |
| Paths | 3 |
| Total Lines | 18 |
| Code Lines | 11 |
| Lines | 3 |
| Ratio | 16.67 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 6 | public function download($url, $timeout) |
||
| 7 | { |
||
| 8 | View Code Duplication | if (false === $tempname = tempnam(null, null)) { |
|
|
|
|||
| 9 | throw new \RuntimeException('Cannot create a temporary file'); |
||
| 10 | } |
||
| 11 | $ctx = stream_context_create([ |
||
| 12 | 'http' => [ |
||
| 13 | 'timeout' => $timeout, |
||
| 14 | 'ignore_errors' => false, |
||
| 15 | ], |
||
| 16 | ]); |
||
| 17 | // if Error Control '@' is omitted then when the download fail an error occurs and cannot return the exception |
||
| 18 | if (! @copy($url, $tempname, $ctx)) { |
||
| 19 | unlink($tempname); |
||
| 20 | throw new \RuntimeException("Download fail for url $url"); |
||
| 21 | } |
||
| 22 | return $tempname; |
||
| 23 | } |
||
| 24 | } |
||
| 25 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.