Completed
Push — master ( 6fbb52...2e9214 )
by Carlos C
06:52
created

PhpDownloader   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 21
Duplicated Lines 14.29 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 0
dl 3
loc 21
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A download() 3 18 3

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
namespace XmlSchemaValidator\Downloader;
3
4
class PhpDownloader implements DownloaderInterface
5
{
6
    public function download($url, $timeout)
7
    {
8 View Code Duplication
        if (false === $tempname = tempnam(null, null)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
9
            throw new \RuntimeException('Cannot create a temporary file');
10
        }
11
        $ctx = stream_context_create([
12
            'http' => [
13
                'timeout' => $timeout,
14
                'ignore_errors' => false,
15
            ],
16
        ]);
17
        // if Error Control '@' is omitted then when the download fail an error occurs and cannot return the exception
18
        if (! @copy($url, $tempname, $ctx)) {
19
            unlink($tempname);
20
            throw new \RuntimeException("Download fail for url $url");
21
        }
22
        return $tempname;
23
    }
24
}
25