eXpansionPluginPack / eXpansion2

src/eXpansion/Framework/Core/Helpers/Data/ArrayFilter.php

Doc Comments +2 added lines, -2 removed lines

@@ -58,10 +58,10 @@
     /**
      * Check if value respects condition.
      *
-     * @param $value
+     * @param string $value
      * @param $condition
      *
-     * @return bool
+     * @return boolean|null
      * @throws InvalidFilterTypeException
      */
     protected function checkValue($value, $condition) {

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
                     $allTrue = true;
                     break;
                 } else if ($logic == self::FILTER_LOGIC_AND) {
-                    if (!$result)  {
+                    if (!$result) {
                         $allTrue = false;
                         break;
                     }

src/eXpansion/Framework/Core/Model/Gui/Factory/LineFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     /**
      * TODO Handle more options such as pregenerated buttons and such instead of text.
      *
-     * @param $totalWidth
+     * @param double $totalWidth
      * @param $columns
      *
      * @return Frame

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use FML\Controls\Control;
 use FML\Controls\Frame;
 use FML\Controls\Label;
-use FML\Types\Renderable;
 use oliverde8\AssociativeArraySimplified\AssociativeArray;
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     public function create($totalWidth, $columns, $index = 0)
     {
         $totalCoef
-            = ($totalWidth - 1) / array_reduce($columns, function($carry, $item){return $carry + $item['width'];});
+            = ($totalWidth - 1) / array_reduce($columns, function($carry, $item) {return $carry + $item['width']; });
 
         $frame = new Frame();
         $frame->setHeight(5);

src/eXpansion/Framework/Core/Model/Gui/Grid/DataCollection.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
      * @param mixed  $lineData
      * @param string $key
      *
-     * @return mixed
+     * @return string
      */
     public function getLineData($lineData, $key)
     {
@@ -74,7 +74,7 @@ 
     /**
      * Get the number of the last page.
      *
-     * @return int
+     * @return double
      */
     public function getLastPageNumber()
     {

src/eXpansion/Framework/Core/Model/Gui/Grid/DataCollectionInterface.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      * @param mixed  $lineData
      * @param string $key
      *
-     * @return mixed
+     * @return string
      */
     public function getLineData($lineData, $key);
 

src/eXpansion/Framework/Core/Model/Gui/Grid/GridBuilder.php

Unused Use Statements -3 removed lines

@@ -2,7 +2,6 @@ 
 
 namespace eXpansion\Framework\Core\Model\Gui\Grid;
 use eXpansion\Framework\Core\Model\Gui\Action;
-use eXpansion\Framework\Core\Model\Gui\Factory\LabelFactory;
 use eXpansion\Framework\Core\Model\Gui\Factory\LineFactory;
 use eXpansion\Framework\Core\Model\Gui\Factory\PagerFactory;
 use eXpansion\Framework\Core\Model\Gui\Grid\Column\AbstractColumn;
@@ -12,8 +11,6 @@ 
 use eXpansion\Framework\Core\Plugins\Gui\ActionFactory;
 use eXpansion\Framework\Core\Plugins\Gui\ManialinkFactory;
 use FML\Controls\Frame;
-use FML\Controls\Label;
-use FML\Controls\Quads\Quad_Icons64x64_1;
 
 
 /**

Spacing +4 added lines, -4 removed lines

@@ -90,7 +90,7 @@ 
         $this->lineFactory = $lineFactory;
         $this->pagerFactory = $pagerFactory;
 
-        $this->pageKey = spl_object_hash($this) . "_key";
+        $this->pageKey = spl_object_hash($this)."_key";
     }
 
     /**
@@ -192,7 +192,7 @@ 
         $lineHeight = 5 + 0.5;
 
         $frame = new Frame();
-        $frame->setPosition(0,0);
+        $frame->setPosition(0, 0);
         $frame->setSize($width, $height);
 
         $posY = 0;
@@ -221,7 +221,7 @@ 
                         'width' => $columnData->getWidthCoeficiency(),
                         'translatable' => $columnData->getTranslatable()
                     ];
-                } elseif($columnData instanceof ActionColumn) {
+                } elseif ($columnData instanceof ActionColumn) {
                     $action = $this->actionFactory
                         ->createManialinkAction($this->manialink, $columnData->getCallable(), $lineData);
                     $this->temporaryActions[] = $action;
@@ -241,7 +241,7 @@ 
         /*
          * Handle the pager.
          */
-        $posY = ($frame->getHeight() -7) * -1;
+        $posY = ($frame->getHeight() - 7) * -1;
         $pager = $this->pagerFactory->create(
             $frame->getWidth(),
             $this->currentPage,

Doc Comments +12 added lines, -8 removed lines

@@ -145,9 +145,9 @@ 
     }
 
     /**
-     * @param      $key
-     * @param      $name
-     * @param      $widthCoefficiency
+     * @param      string $key
+     * @param      string $name
+     * @param      integer $widthCoefficiency
      * @param bool $sortable
      * @param bool $translatable
      *
@@ -163,11 +163,11 @@ 
     /**
      * Add an action into a column.
      *
-     * @param $key
-     * @param $name
-     * @param $widthCoefficiency
+     * @param string $key
+     * @param string $name
+     * @param integer $widthCoefficiency
      * @param $action
-     * @param $renderer
+     * @param Label $renderer
      */
     public function addActionColumn($key, $name, $widthCoefficiency, $action, $renderer)
     {
@@ -183,6 +183,10 @@ 
         $this->totalWidthCoefficency = 0;
     }
 
+    /**
+     * @param double $width
+     * @param double $height
+     */
     public function build($width, $height)
     {
         foreach ($this->temporaryActions as $action) {
@@ -296,7 +300,7 @@ 
     /**
      * Handle page change & refresh user window.
      *
-     * @param $page
+     * @param integer $page
      */
     protected function changePage($page)
     {

src/eXpansion/Framework/Core/Plugins/Gui/ManialinkFactory.php

Doc Comments +1 added lines

@@ -116,6 +116,7 @@
 
     /**
      * @inheritdoc
+     * @param Group $group
      */
     final public function update($group)
     {

src/eXpansion/Framework/Core/Model/Gui/Factory/PagerFactory.php

Spacing +6 added lines, -6 removed lines

@@ -45,7 +45,7 @@ 
         $actionPreviousPage,
         $actionNextPage,
         $actionLastPage
-    ){
+    ) {
         $frame = new Frame();
         $frame->setSize($width, 7);
 
@@ -55,7 +55,7 @@ 
         if ($currentPageNumber > 2) {
             $button = Quad_Icons64x64_1::create();
             $button->setSubStyle(Quad_Icons64x64_1::SUBSTYLE_ArrowFirst)
-                ->setSize($buttonSize,$buttonSize)
+                ->setSize($buttonSize, $buttonSize)
                 ->setPosition(1, 0)
                 ->setAction($actionFirstPage);
             $frame->addChild($button);
@@ -63,7 +63,7 @@ 
         if ($currentPageNumber > 1) {
             $button = Quad_Icons64x64_1::create();
             $button->setSubStyle(Quad_Icons64x64_1::SUBSTYLE_ArrowPrev)
-                ->setSize($buttonSize,$buttonSize)
+                ->setSize($buttonSize, $buttonSize)
                 ->setPosition(2 + $buttonSize, 0)
                 ->setAction($actionPreviousPage);
             $frame->addChild($button);
@@ -79,15 +79,15 @@ 
         if ($currentPageNumber < $lastPageNumber) {
             $button = Quad_Icons64x64_1::create();
             $button->setSubStyle(Quad_Icons64x64_1::SUBSTYLE_ArrowNext)
-                ->setSize($buttonSize,$buttonSize)
-                ->setPosition($frame->getWidth() - 1 - (2*$buttonSize), 0)
+                ->setSize($buttonSize, $buttonSize)
+                ->setPosition($frame->getWidth() - 1 - (2 * $buttonSize), 0)
                 ->setAction($actionNextPage);
             $frame->addChild($button);
         }
         if ($currentPageNumber < $lastPageNumber - 1) {
             $button = Quad_Icons64x64_1::create();
             $button->setSubStyle(Quad_Icons64x64_1::SUBSTYLE_ArrowLast)
-                ->setSize($buttonSize,$buttonSize)
+                ->setSize($buttonSize, $buttonSize)
                 ->setPosition($frame->getWidth() - 1 - $buttonSize, 0)
                 ->setAction($actionLastPage);
             $frame->addChild($button);

src/eXpansion/Framework/Core/Plugins/Gui/WindowHelpFactory.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use eXpansion\Framework\Core\Services\ChatCommands;
 use FML\Controls\Frame;
 use FML\Controls\Label;
-use FML\Controls\Quads\Quad_Icons64x64_1;
 
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -113,6 +113,6 @@
      */
     public function callbackHelp($login, $params, $arguments)
     {
-        $this->chatCommandDataPovider->onPlayerChat(0, $login, '/' . $arguments['command'] . ' -h', true);
+        $this->chatCommandDataPovider->onPlayerChat(0, $login, '/'.$arguments['command'].' -h', true);
     }
 }

src/eXpansion/Framework/Core/Model/Gui/Window.php

Doc Comments +2 added lines, -2 removed lines

@@ -175,7 +175,7 @@ 
     /**
      * Recursive search all dome tree in order to find all translatable labels.
      *
-     * @param $frame
+     * @param \FML\ManiaLink $frame
      * @param $translations
      */
     protected function getDictionaryInformation($frame, &$translations)
@@ -305,7 +305,7 @@ 
      *
      * @param Format $format New Format
      *
-     * @return static
+     * @return Frame
      * @deprecated Use Style
      * @see        Style
      */

Spacing +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
 
         foreach ($translations as $msgId => $messages) {
             foreach ($messages as $message) {
-                $this->dictionary->setEntry($message['Lang'], $msgId, htmlspecialchars ($message['Text']));
+                $this->dictionary->setEntry($message['Lang'], $msgId, htmlspecialchars($message['Text']));
             }
         }
     }
@@ -182,7 +182,7 @@ 
     {
         foreach ($frame->getChildren() as $child) {
             if ($child instanceof Label && $child->getTranslate()) {
-                $textId = 'exp_' . md5($child->getTextId());
+                $textId = 'exp_'.md5($child->getTextId());
                 $translations[$textId] = $this->translationHelper->getTranslations($child->getTextId(), []);
 
                 // Replaces with text id that can be used in the xml.