Completed
Pull Request — master (#278)
by De Cramer
03:45
created
src/eXpansion/Bundle/Menu/DataProviders/MenuItemProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     }
48 48
 
49 49
     /**
50
-     * @return ParentItem|null
50
+     * @return ItemInterface|null
51 51
      */
52 52
     public function getRootItem()
53 53
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use eXpansion\Bundle\Menu\Model\Menu\ParentItem;
7 7
 use eXpansion\Bundle\Menu\Services\ItemBuilder;
8 8
 use eXpansion\Framework\Core\DataProviders\AbstractDataProvider;
9
-use FML\Controls\Quad;
10 9
 
11 10
 /**
12 11
  * Class MenuItemProvider
Please login to merge, or discard this patch.
src/eXpansion/Bundle/LocalRecords/Command/GenDummyRecordsCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
                     if (!in_array($x, $idsUsed)) {
170 170
                         $rec = clone $record;
171 171
                         $rec->setScore(mt_rand($map->getGoldtime(), $map->getGoldtime() * 5));
172
-                        $rec->setPlayerId($players[$x-1]->getId());
172
+                        $rec->setPlayerId($players[$x - 1]->getId());
173 173
                         $rec->save();
174 174
                         $progress->advance();
175 175
                     }
Please login to merge, or discard this patch.
GameTrackmania/DataProviders/ScriptBaseRounds/RaceDataProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
         }
38 38
 
39 39
         // If rounds is configured to be single laps then no need for race data. lap is sufficient.
40
-        return $nbLaps > 1;    }
40
+        return $nbLaps > 1; }
41 41
 
42 42
 
43 43
     public function onWayPoint($params)
Please login to merge, or discard this patch.
src/eXpansion/Bundle/Maps/Services/MapInfoService.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      */
94 94
     public function onEndMap(DedicatedMap $map)
95 95
     {
96
-      // do nothing
96
+        // do nothing
97 97
     }
98 98
 
99 99
     /**
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
     public function onExpansionNextMapChange($nextMap, $previousNextMap)
119 119
     {
120
-       // do nothing
120
+        // do nothing
121 121
     }
122 122
 
123 123
     protected function syncMaps()
Please login to merge, or discard this patch.
src/eXpansion/Bundle/Players/Plugins/Gui/BanListWindow.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 namespace eXpansion\Bundle\Players\Plugins\Gui;
4
-use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
5 4
 
6 5
 /**
7 6
  * Class IgnoreListWindow
Please login to merge, or discard this patch.
src/eXpansion/Framework/Config/DependencyInjection/Compiler/ConfigPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         // Find all services to display configs.
45 45
         $definition = $container->getDefinition(ConfigUiManager::class);
46 46
         $services = $this->findAndSortTaggedServices('expansion.config.ui', $container);
47
-        foreach($services as $service) {
47
+        foreach ($services as $service) {
48 48
             $definition->addMethodCall(
49 49
                 'registerUi',
50 50
                 [$service]
Please login to merge, or discard this patch.
src/eXpansion/Bundle/AdminChat/ChatCommand/TimeParameterCommand.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -81,9 +81,9 @@
 block discarded – undo
81 81
 
82 82
             $logMessage = $this->chatNotification->getMessage($this->chatMessage,
83 83
                 ['%adminLevel%' => $group, '%admin%' => $nickName, "%parameter%" => $parameter], "en");
84
-            $this->logger->info("[". $login. "] " . TMString::trimStyles($logMessage));
84
+            $this->logger->info("[".$login."] ".TMString::trimStyles($logMessage));
85 85
 
86
-        }  catch (DedicatedException $e) {
86
+        } catch (DedicatedException $e) {
87 87
             $this->logger->error("Error on admin command", ["exception" => $e]);
88 88
             $this->chatNotification->sendMessage("expansion_admin_chat.dedicatedexception", $login,
89 89
                 ["%message%" => $e->getMessage()]);
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
                 ['%adminLevel%' => $group, '%admin%' => $nickName, "%parameter%" => $parameter], "en");
84 84
             $this->logger->info("[". $login. "] " . TMString::trimStyles($logMessage));
85 85
 
86
-        }  catch (DedicatedException $e) {
86
+        } catch (DedicatedException $e) {
87 87
             $this->logger->error("Error on admin command", ["exception" => $e]);
88 88
             $this->chatNotification->sendMessage("expansion_admin_chat.dedicatedexception", $login,
89 89
                 ["%message%" => $e->getMessage()]);
Please login to merge, or discard this patch.
src/eXpansion/Framework/Core/Plugins/Gui/ScriptVariableUpdateFactory.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             );
62 62
         }
63 63
 
64
-        $uniqueId = uniqid('exp_',true);
64
+        $uniqueId = uniqid('exp_', true);
65 65
         $this->checkVariable = new Variable('check', 'Text', 'This', "\"$uniqueId\"");
66 66
         $this->checkOldVariable = new Variable('check_old', 'Text', 'Page', "\"$uniqueId\"");
67 67
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         if ($this->variables[$variable]->getValue() != $newValue) {
78 78
             $this->variables[$variable]->setValue($newValue);
79
-            $uniqueId = '"' . uniqid('exp_', true) . '"';
79
+            $uniqueId = '"'.uniqid('exp_', true).'"';
80 80
             $this->checkVariable->setValue($uniqueId);
81 81
 
82 82
             if (is_null($this->queuedForUpdate)) {
@@ -135,16 +135,16 @@  discard block
 block discarded – undo
135 135
     {
136 136
         $scriptContent = '';
137 137
         foreach ($this->variables as $variable) {
138
-            $scriptContent .= $variable->getScriptDeclaration() . "\n";
138
+            $scriptContent .= $variable->getScriptDeclaration()."\n";
139 139
             if ($defaultValues) {
140
-                $scriptContent .= $variable->getScriptValueSet() . "\n";
140
+                $scriptContent .= $variable->getScriptValueSet()."\n";
141 141
             }
142 142
         }
143
-        $scriptContent .= $this->checkVariable->getScriptDeclaration() . "\n";
144
-        $scriptContent .= $this->checkOldVariable->getScriptDeclaration() . "\n";
143
+        $scriptContent .= $this->checkVariable->getScriptDeclaration()."\n";
144
+        $scriptContent .= $this->checkOldVariable->getScriptDeclaration()."\n";
145 145
         if ($defaultValues) {
146
-            $scriptContent .= $this->checkVariable->getScriptValueSet() . "\n";
147
-            $scriptContent .= $this->checkOldVariable->getVariableName() . ' = "";';
146
+            $scriptContent .= $this->checkVariable->getScriptValueSet()."\n";
147
+            $scriptContent .= $this->checkOldVariable->getVariableName().' = "";';
148 148
         }
149 149
 
150 150
         return $scriptContent;
Please login to merge, or discard this patch.
src/eXpansion/Bundle/Maps/Plugins/ManiaExchange.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -388,7 +388,7 @@
 block discarded – undo
388 388
      * Remove special characters from map name
389 389
      *
390 390
      * @param string $string
391
-     * @return mixed
391
+     * @return string
392 392
      */
393 393
     protected function cleanString($string)
394 394
     {
Please login to merge, or discard this patch.