View GitHub Repository eXpansion2

Schedule Inspection
Subscribe
Completed
Pull Request — master (#99)
by De Cramer
02:42
created

2,153 +41 Covered Lines

3,372 -897 Total Lines

63.8 % +14.4% Code Coverage

PHP Classes Changes

 
 ⇢
0%
WidgetFactoryContext added
 
 ⇢
0%
WindowFactoryContext added
 
 ⇢
100%
ManialinkFactoryContext added
 
 ⇢
100%
Factory added
12.5%
 ↗
100%
 MapDataProvider improved
0%
 ↗
47.27%
 layoutRow improved
82.86%
 ↗
100%
 OneParameterCommand improved
86.49%
 ↗
100%
 ChatCommandDataProvider improved
94.59%
 ↗
100%
 PlayerDataProvider improved
100%
 ↘
99.02%
 GridBuilder got worse
18.42%
 ↗
18.67%
 PluginManager improved
98.94%
 ↘
98.86%
 ChatNotification got worse

CRAP Changes

 
 ⇢
4
Factory::__call() added
 
 ⇢
2
RecordsWindowFactory::__construct() added
 
 ⇢
2
MapsWindowFactory::__construct() added
 
 ⇢
2
WindowHelpDetailsFactory::__construct() added
 
 ⇢
2
WindowHelpFactory::__construct() added
 
 ⇢
2
WidgetFactoryContext::__construct() added
 
 ⇢
2
WidgetFactoryContext::getTranslationsHelper() added
 
 ⇢
2
WidgetFactoryContext::getUiFactory() added
 
 ⇢
2
WindowFactoryContext::__construct() added
 
 ⇢
2
WindowFactoryContext::getWindowManiaScriptFactory(... added
⋮ view more  
7
 ↗
7.0003
 GridBuilder::build() got worse
2.0625
 ↘
2
 PlayerDataProvider::onPlayerDisconnect() improved
10.9037
 ↘
10
 ChatCommandDataProvider::onPlayerChat() improved
2
 ↘
1
 layoutRow::addChild() improved
2
 ↘
1
 layoutRow::addClass() improved
6
 ↘
2
 layoutRow::render() improved
12
 ↘
3.1825
 layoutRow::__construct() improved
2
 ↛
 
 WindowHelpDetailsFactory::setLineFactory() removed
2
 ↛
 
 WindowHelpDetailsFactory::setTitleLineFactory() removed
2
 ↛
 
 WindowHelpDetailsFactory::setTranslationsHelper() removed
2
 ↛
 
 WindowHelpFactory::setGridBuilderFactory() removed
2
 ↛
 
 WindowHelpFactory::setDataCollectionFactory() removed
2
 ↛
 
 WindowHelpFactory::setChatCommands() removed
2
 ↛
 
 WindowHelpFactory::setChatCommandDataProvide() removed
2
 ↛
 
 WindowHelpFactory::setWindowDescriptionFactory() removed
2
 ↛
 
 RecordsWindowFactory::setGridBuilderFactory() removed
2
 ↛
 
 RecordsWindowFactory::setDataCollectionFactory() removed
⋮ view more