View GitHub Repository eXpansion2

Schedule Inspection
Subscribe
Completed
Pull Request — master (#99)
by De Cramer
02:57
created

2,383 -183 Covered Lines

3,860 -380 Total Lines

61.7 % +1.2% Code Coverage

PHP Classes Changes

 
 ⇢
0%
WidgetFactoryContext added
 
 ⇢
0%
WindowFactoryContext added
 
 ⇢
100%
ManialinkFactoryContext added
12%
 ↗
100%
 MapDataProvider improved
24%
 ↗
85.71%
 uiLine improved
83.78%
 ↗
100%
 OneParameterCommand improved
90%
 ↗
100%
 ChatCommandDataProvider improved
81.82%
 ↗
90%
 AbstractConnectionCommand improved
81.82%
 ↗
90%
 Factory improved
61.11%
 ↗
68.75%
 AbstractUserGroupPlugin improved
82.14%
 ↗
88.46%
 uiLabel improved
65.15%
 ↗
71.19%
 uiDropdown improved
65.22%
 ↘
60%
 Dispatcher got worse
⋮ view more  

CRAP Changes

 
 ⇢
2
WindowHelpFactory::__construct() added
 
 ⇢
2
RecordsWindowFactory::__construct() added
 
 ⇢
2
MapsWindowFactory::__construct() added
 
 ⇢
2
WidgetFactoryContext::__construct() added
 
 ⇢
2
WidgetFactoryContext::getTranslationsHelper() added
 
 ⇢
2
WindowFactoryContext::__construct() added
 
 ⇢
2
WindowFactoryContext::getWindowManiaScriptFactory(... added
 
 ⇢
2
WindowHelpDetailsFactory::__construct() added
 
 ⇢
1
ManialinkFactoryContext::__construct() added
 
 ⇢
1
ManialinkFactoryContext::getClassName() added
⋮ view more  
7
 ↗
7.0003
 GridBuilder::build() got worse
6.0029
 ↗
6.0045
 LineFactory::create() got worse
6.0061
 ↘
6
 Widget::getDictionaryInformation() improved
4.0119
 ↗
4.0218
 ChatNotification::getSecuredBy() got worse
4.0186
 ↘
4.0039
 Time::timeToText() improved
4.0378
 ↗
4.0582
 ManialinkFactory::create() got worse
3.1406
 ↗
3.1825
 layoutRow::__construct() got worse
2.0811
 ↘
2.032
 uiLine::render() improved
2.0625
 ↘
2
 PlayerDataProvider::onPlayerDisconnect() improved
4.1137
 ↘
4.0312
 uiLabel::__construct() improved
⋮ view more  
2
 ↛
 
 WindowHelpDetailsFactory::setLineFactory() removed
2
 ↛
 
 WindowHelpDetailsFactory::setTitleLineFactory() removed
2
 ↛
 
 WindowHelpDetailsFactory::setTranslationsHelper() removed
2
 ↛
 
 WindowHelpFactory::setGridBuilderFactory() removed
2
 ↛
 
 WindowHelpFactory::setDataCollectionFactory() removed
2
 ↛
 
 WindowHelpFactory::setChatCommands() removed
2
 ↛
 
 WindowHelpFactory::setChatCommandDataProvide() removed
2
 ↛
 
 WindowHelpFactory::setWindowDescriptionFactory() removed
2
 ↛
 
 RecordsWindowFactory::setGridBuilderFactory() removed
2
 ↛
 
 RecordsWindowFactory::setDataCollectionFactory() removed
⋮ view more