Completed
Pull Request — master (#292)
by De Cramer
07:27 queued 01:23
created
src/eXpansion/Framework/Core/Plugins/Gui/ScriptVariableUpdateFactory.php 3 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,6 @@  discard block
 block discarded – undo
42 42
      * @param                      $name
43 43
      * @param array                $variables
44 44
      * @param int                  $maxUpdateFrequency
45
-     * @param Group                $playerGroup
46 45
      * @param WidgetFactoryContext $context
47 46
      */
48 47
     public function __construct($name, array  $variables, int $maxUpdateFrequency = 1, WidgetFactoryContext $context)
@@ -91,7 +90,7 @@  discard block
 block discarded – undo
91 90
     /**
92 91
      * Get a variable.
93 92
      *
94
-     * @param $variable
93
+     * @param string $variable
95 94
      *
96 95
      * @return Variable
97 96
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use eXpansion\Framework\Core\DataProviders\Listener\ListenerInterfaceExpTimer;
6 6
 use eXpansion\Framework\Core\DataProviders\Listener\ListenerInterfaceExpUserGroup;
7
-use eXpansion\Framework\Core\Model\Gui\ManialinkFactoryContext;
8 7
 use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
9 8
 use eXpansion\Framework\Core\Model\Gui\Script\Variable;
10 9
 use eXpansion\Framework\Core\Model\Gui\WidgetFactoryContext;
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             );
60 60
         }
61 61
 
62
-        $uniqueId = uniqid('exp_',true);
62
+        $uniqueId = uniqid('exp_', true);
63 63
         $this->checkVariable = new Variable('check', 'Text', 'This', "\"$uniqueId\"");
64 64
         $this->checkOldVariable = new Variable('check_old', 'Text', 'Page', "\"$uniqueId\"");
65 65
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         $checkVariable = clone $this->checkVariable;
84
-        $uniqueId = uniqid('exp_',true);
84
+        $uniqueId = uniqid('exp_', true);
85 85
         $checkVariable->setValue($uniqueId);
86 86
 
87 87
         $this->queuedForUpdate[$group->getName()]['group'] = $group;
@@ -138,16 +138,16 @@  discard block
 block discarded – undo
138 138
     {
139 139
         $scriptContent = '';
140 140
         foreach ($this->variables as $variable) {
141
-            $scriptContent .= $variable->getScriptDeclaration() . "\n";
141
+            $scriptContent .= $variable->getScriptDeclaration()."\n";
142 142
             if ($defaultValues) {
143
-                $scriptContent .= $variable->getScriptValueSet() . "\n";
143
+                $scriptContent .= $variable->getScriptValueSet()."\n";
144 144
             }
145 145
         }
146
-        $scriptContent .= $this->checkVariable->getScriptDeclaration() . "\n";
147
-        $scriptContent .= $this->checkOldVariable->getScriptDeclaration() . "\n";
146
+        $scriptContent .= $this->checkVariable->getScriptDeclaration()."\n";
147
+        $scriptContent .= $this->checkOldVariable->getScriptDeclaration()."\n";
148 148
         if ($defaultValues) {
149
-            $scriptContent .= $this->checkVariable->getScriptValueSet() . "\n";
150
-            $scriptContent .= $this->checkOldVariable->getVariableName() . ' = "";';
149
+            $scriptContent .= $this->checkVariable->getScriptValueSet()."\n";
150
+            $scriptContent .= $this->checkOldVariable->getVariableName().' = "";';
151 151
         }
152 152
 
153 153
         return $scriptContent;
Please login to merge, or discard this patch.
eXpansion/Bundle/WidgetBestCheckpoints/Plugins/Gui/UpdaterWidgetFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@
 block discarded – undo
30 30
     public function setLocalRecord($checkpoints)
31 31
     {
32 32
         if (count($checkpoints) > 0) {
33
-            $this->updateValue($this->playerGroup ,'LocalRecordCheckpoints', Builder::getArray($checkpoints, true));
33
+            $this->updateValue($this->playerGroup, 'LocalRecordCheckpoints', Builder::getArray($checkpoints, true));
34 34
         } else {
35
-            $this->updateValue($this->playerGroup ,'LocalRecordCheckpoints', "Integer[Integer]");
35
+            $this->updateValue($this->playerGroup, 'LocalRecordCheckpoints', "Integer[Integer]");
36 36
         }
37 37
     }
38 38
 }
Please login to merge, or discard this patch.