Completed
Pull Request — master (#294)
by De Cramer
03:48
created
src/eXpansion/Framework/Config/Ui/Window/ConfigWindowFactory.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use eXpansion\Framework\Core\Plugins\Gui\WindowFactory;
14 14
 use eXpansion\Framework\Gui\Components\Button;
15 15
 use eXpansion\Framework\Gui\Components\Label;
16
-use eXpansion\Framework\Gui\Components\Tooltip;
17 16
 use FML\Controls\Control;
18 17
 use FML\Controls\Frame;
19 18
 use FML\Controls\Quad;
Please login to merge, or discard this patch.
src/eXpansion/Framework/Config/Services/ConfigManager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use eXpansion\Framework\Config\Exception\UnhandledConfigurationException;
6 6
 use eXpansion\Framework\Config\Model\ConfigInterface;
7
-use eXpansion\Framework\Config\Ui\UiInterface;
8 7
 use eXpansion\Framework\Core\Services\Application\DispatcherInterface;
9
-
10 8
 use eXpansion\Framework\Core\Storage\GameDataStorage;
11 9
 use League\Flysystem\File;
12 10
 use League\Flysystem\Filesystem;
Please login to merge, or discard this patch.
src/eXpansion/Framework/Config/Ui/Fields/TextListField.php 3 patches
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
85 85
      * @param $config
86 86
      * @param $manialink
87 87
      * @param $element
88
-     * @param $width
89
-     * @param $manialinkFactory
88
+     * @param double $width
89
+     * @param ManialinkFactory $manialinkFactory
90 90
      *
91 91
      * @return \eXpansion\Framework\Gui\Layouts\LayoutLine
92 92
      */
@@ -102,6 +102,10 @@  discard block
 block discarded – undo
102 102
             ->setAction(
103 103
                 $this->actionFactory->createManialinkAction(
104 104
                     $manialink,
105
+
106
+                    /**
107
+                     * @param double $args
108
+                     */
105 109
                     function (ManialinkInterface $manialink, $login, $entries, $args) use ($manialinkFactory) {
106 110
                         /** @var TextListConfig $config */
107 111
                         $config = $args['config'];
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use eXpansion\Framework\Config\Model\ConfigInterface;
6 6
 use eXpansion\Framework\Config\Model\TextListConfig;
7
-use eXpansion\Framework\Config\Ui\Window\ConfigWindowFactory;
8 7
 use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
9 8
 use eXpansion\Framework\Core\Plugins\Gui\ActionFactory;
10 9
 use eXpansion\Framework\Core\Plugins\Gui\ManialinkFactory;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             ->setAction(
58 58
                 $this->actionFactory->createManialinkAction(
59 59
                     $manialink,
60
-                    function (ManialinkInterface $manialink, $login, $entries, $args) use ($manialinkFactory) {
60
+                    function(ManialinkInterface $manialink, $login, $entries, $args) use ($manialinkFactory) {
61 61
                         /** @var TextListConfig $config */
62 62
                         $config = $args['config'];
63 63
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
                 )
72 72
             );
73 73
 
74
-        $elements = [$this->uiFactory->createLayoutLine(0,0, [$input, $addButton])];
74
+        $elements = [$this->uiFactory->createLayoutLine(0, 0, [$input, $addButton])];
75 75
         foreach ($config->get() as $element) {
76 76
             $elements[] = $this->getElementLine($config, $manialink, $element, $width, $manialinkFactory);
77 77
         }
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             ->setAction(
103 103
                 $this->actionFactory->createManialinkAction(
104 104
                     $manialink,
105
-                    function (ManialinkInterface $manialink, $login, $entries, $args) use ($manialinkFactory) {
105
+                    function(ManialinkInterface $manialink, $login, $entries, $args) use ($manialinkFactory) {
106 106
                         /** @var TextListConfig $config */
107 107
                         $config = $args['config'];
108 108
                         $config->remove($args['element']);
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
                 )
114 114
             );
115 115
 
116
-        return $this->uiFactory->createLayoutLine(0,0, [$label, $delButton]);
116
+        return $this->uiFactory->createLayoutLine(0, 0, [$label, $delButton]);
117 117
     }
118 118
 
119 119
     /**
Please login to merge, or discard this patch.
src/eXpansion/Framework/Config/Ui/Fields/MaskedField.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function isCompatible(ConfigInterface $config): bool
49 49
     {
50
-         return ($config instanceof PasswordConfig);
50
+            return ($config instanceof PasswordConfig);
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.
eXpansion/Framework/AdminGroups/DependencyInjection/Compiler/ConfigPass.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -35,15 +35,15 @@  discard block
 block discarded – undo
35 35
 
36 36
         foreach ($groups as $groupCode => $group)
37 37
         {
38
-            $pathPrefix = $container->getParameter('expansion.admin_groups.config.path') . "/$groupCode";
38
+            $pathPrefix = $container->getParameter('expansion.admin_groups.config.path')."/$groupCode";
39 39
 
40
-            $id = 'expansion.admin_groups.config.label.' . $groupCode;
40
+            $id = 'expansion.admin_groups.config.label.'.$groupCode;
41 41
             $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.label.abstract'))
42 42
                 ->replaceArgument('$path', "$pathPrefix/label")
43 43
                 ->replaceArgument('$defaultValue', $group['label']);
44 44
             $configManager->addMethodCall('registerConfig', [new Reference($id), $id]);
45 45
 
46
-            $id = 'expansion.admin_groups.config.logins.' . $groupCode;
46
+            $id = 'expansion.admin_groups.config.logins.'.$groupCode;
47 47
             $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.logins.abstract'))
48 48
                 ->setArgument('$path', "$pathPrefix/logins")
49 49
                 ->setArgument('$defaultValue', $group['logins']);
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
             if ($groupCode != "master_admin") {
53 53
                 foreach ($permissions as $permission) {
54
-                    $id = 'expansion.admin_groups.config.permissions.' . $groupCode . ".$permission";
54
+                    $id = 'expansion.admin_groups.config.permissions.'.$groupCode.".$permission";
55 55
                     $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.permissions.abstract'))
56 56
                         ->setArgument('$path', "$pathPrefix/perm_$permission")
57 57
                         ->setArgument('$defaultValue', $group['logins'])
Please login to merge, or discard this patch.