eXpansionPluginPack / eXpansion2

src_experimantal/eXpansionExperimantal/Bundle/Dedimania/Classes/Request.php

Doc Comments +9 added lines

@@ -7,11 +7,17 @@ 
 
     private $requests = array();
 
+    /**
+     * @param string $method
+     */
     public function __construct($method, $args)
     {
         $this->requests[] = $this->generate($method, $args);
     }
 
+    /**
+     * @param string $method
+     */
     public function add($method, $args)
     {
         $this->requests[] = $this->generate($method, $args);
@@ -63,6 +69,9 @@ 
 {
     private $data;
 
+    /**
+     * @param string|false $data
+     */
     public function __construct($data)
     {
         $this->data = $data;

Spacing +10 added lines, -10 removed lines

@@ -70,7 +70,7 @@ 
 
     public function getXml()
     {
-        return '<base64>' . base64_encode($this->data) . '</base64>';
+        return '<base64>'.base64_encode($this->data).'</base64>';
     }
 }
 
@@ -146,32 +146,32 @@ 
         // Return XML for this value
         switch ($this->type) {
             case 'boolean':
-                return '<boolean>' . ($this->data ? '1' : '0') . '</boolean>';
+                return '<boolean>'.($this->data ? '1' : '0').'</boolean>';
                 break;
             case 'int':
-                return '<int>' . $this->data . '</int>';
+                return '<int>'.$this->data.'</int>';
                 break;
             case 'double':
-                return '<double>' . $this->data . '</double>';
+                return '<double>'.$this->data.'</double>';
                 break;
             case 'string':
-                return '<string>' . htmlspecialchars($this->data) . '</string>';
+                return '<string>'.htmlspecialchars($this->data).'</string>';
                 break;
             case 'array':
                 $xml = '';
                 foreach ($this->data as $item) {
-                    $xml .= '<value>' . $item->getXml() . '</value>';
+                    $xml .= '<value>'.$item->getXml().'</value>';
                 }
 
-                return '<array><data>' . $xml . '</data></array>';
+                return '<array><data>'.$xml.'</data></array>';
                 break;
             case 'struct':
                 $xml = '';
                 foreach ($this->data as $name => $value) {
-                    $xml .= '<member><name>' . $name . '</name><value>' . $value->getXml() . '</value></member>';
+                    $xml .= '<member><name>'.$name.'</name><value>'.$value->getXml().'</value></member>';
                 }
 
-                return '<struct>' . $xml . '</struct>';
+                return '<struct>'.$xml.'</struct>';
                 break;
             case 'date':
             case 'base64':
@@ -186,7 +186,7 @@ 
     {
         $expected = 0;
         foreach ($array as $key => $value) {
-            if ((string)$key != (string)$expected) {
+            if ((string) $key != (string) $expected) {
                 return true;
             }
             $expected++;

src_experimantal/eXpansionExperimantal/Bundle/Dedimania/Classes/Webaccess.php

Doc Comments +17 added lines

@@ -131,6 +131,11 @@ 
         $this->console = $console;
     }
 
+    /**
+     * @param string $url
+     * @param callable[] $callback
+     * @param string $datas
+     */
     public function request(
         $url,
         $callback,
@@ -204,6 +209,9 @@ 
         }
     }  // retry
 
+    /**
+     * @param integer $tv_sec
+     */
     public function select(&$read, &$write, &$except, $tv_sec, $tv_usec = 0)
     {
         $timeout = (int)($tv_sec * 1000000 + $tv_usec);
@@ -421,6 +429,9 @@ 
     // Methods
     //-----------------------------
 
+    /**
+     * @param Webaccess $wa
+     */
     public function __construct(
         &$wa,
         $host,
@@ -1058,6 +1069,9 @@ 
         }
     }  // _receive
 
+    /**
+     * @param string $error
+     */
     private function _callCallback($error = null)
     {
         if ($error !== null) {
@@ -1406,6 +1420,9 @@ 
     return array(false, false, false);
 }
 
+/**
+ * @param string $input
+ */
 function urlsafe_base64_encode($input)
 {
     return strtr(\base64_encode($input), '+/=', '-_,');

Indentation +4 added lines, -4 removed lines

@@ -61,9 +61,9 @@ 
 
 
 global $_web_access_compress_xmlrpc_request, $_web_access_compress_reply,
-       $_web_access_keepalive, $_web_access_keepalive_timeout,
-       $_web_access_keepalive_max, $_web_access_retry_timeout,
-       $_web_access_retry_timeout_max, $_web_access_post_xmlrpc;
+        $_web_access_keepalive, $_web_access_keepalive_timeout,
+        $_web_access_keepalive_max, $_web_access_retry_timeout,
+        $_web_access_retry_timeout_max, $_web_access_post_xmlrpc;
 
 
 // Will compress xmlrpc request ('never','accept','force','force-gzip','force-deflate')
@@ -1153,7 +1153,7 @@ 
             }
         } else {
             $headers = &$this->_spool[0]['Headers'];
-          //  echo "Previous Headers! (".strlen($datas[0]).")\n"; // for debugging purposes, don't remove
+            //  echo "Previous Headers! (".strlen($datas[0]).")\n"; // for debugging purposes, don't remove
         }
 
 

Spacing +5 added lines, -5 removed lines

@@ -206,7 +206,7 @@ 
 
     public function select(&$read, &$write, &$except, $tv_sec, $tv_usec = 0)
     {
-        $timeout = (int)($tv_sec * 1000000 + $tv_usec);
+        $timeout = (int) ($tv_sec * 1000000 + $tv_usec);
 
         if ($read == null) {
             $read = array();
@@ -232,11 +232,11 @@ 
             return 0;
         }
 
-        $utime = (int)(microtime(true) * 1000000);
+        $utime = (int) (microtime(true) * 1000000);
         $nb = @stream_select($read, $write, $except, $tv_sec, $tv_usec);
         if ($nb === false) {
             // in case stream_select "forgot" to wait, sleep the remaining asked timeout...
-            $dtime = (int)(microtime(true) * 1000000) - $utime;
+            $dtime = (int) (microtime(true) * 1000000) - $utime;
             $timeout -= $dtime;
             if ($timeout > 1000) {
                 usleep($timeout);
@@ -803,7 +803,7 @@ 
                 }
             } // else just do a send on the current
             elseif (isset($this->_spool[0]['State']) && $this->_spool[0]['State'] == 'OPEN') {
-                @stream_set_timeout($this->_socket, 0, 2000);  // timeout 2 ms
+                @stream_set_timeout($this->_socket, 0, 2000); // timeout 2 ms
                 $this->_send($waittimeout);
             }
         }
@@ -1032,7 +1032,7 @@ 
         // reply is complete :)
         if ($state === true) {
             $this->_bad_timeout = 0; // reset error timeout
-            $time = microtime(true);  // @todo see if this is needed ?
+            $time = microtime(true); // @todo see if this is needed ?
             $this->_spool[0]['Times']['receive'][1] = $time - $this->_spool[0]['Times']['receive'][0];
             $this->_spool[0]['State'] = 'DONE';
 

src_experimantal/eXpansionExperimantal/Bundle/Dedimania/Plugins/Dedimania.php

Doc Comments +4 added lines, -1 removed lines

@@ -622,7 +622,7 @@ 
 
     /**
      * Sets new Ghost replay for the map
-     * @param $login
+     * @param string $login
      */
     protected function setGReplay($login)
     {
@@ -711,6 +711,9 @@ 
         }
     }
 
+    /**
+     * @param string $titleId
+     */
     protected function getPackMask($titleId)
     {
         foreach ($this->titles as $title => $data) {

Spacing +8 added lines, -8 removed lines

@@ -362,7 +362,7 @@ 
 
         $request = new Request('dedimania.OpenSession', [$params]);
 
-        $this->sendRequest($request, function ($response) {
+        $this->sendRequest($request, function($response) {
             $this->sessionId = $response['SessionId'];
             $this->getRecords();
             $this->connectAllPlayers();
@@ -404,7 +404,7 @@ 
 
         $request = new Request('dedimania.GetChallengeRecords', $params);
 
-        $this->sendRequest($request, function ($response) {
+        $this->sendRequest($request, function($response) {
 
             $this->dedimaniaService->setServerMaxRank($response['ServerMaxRank']);
             /** @var DedimaniaRecord[] $recs */
@@ -448,7 +448,7 @@ 
         ];
         $request = new Request('dedimania.UpdateServerPlayers', $params);
 
-        $this->sendRequest($request, function ($response) {
+        $this->sendRequest($request, function($response) {
             // do nothing
         });
 
@@ -468,7 +468,7 @@ 
         ];
 
         $request = new Request('dedimania.PlayerConnect', $params);
-        $this->sendRequest($request, function ($response) use ($player) {
+        $this->sendRequest($request, function($response) use ($player) {
             $dediplayer = DedimaniaPlayer::fromArray($response);
 
             if ($dediplayer->banned) {
@@ -497,7 +497,7 @@ 
         ];
 
         $request = new Request('dedimania.PlayerConnect', $params);
-        $this->sendRequest($request, function ($response) use ($player) {
+        $this->sendRequest($request, function($response) use ($player) {
             $this->dedimaniaService->disconnectPlayer($player->getLogin());
         });
     }
@@ -528,7 +528,7 @@ 
             return;
         }
 
-        $this->sendRequest($request, function ($response) {
+        $this->sendRequest($request, function($response) {
 
             if (array_key_exists("Login", $response)) {
                 $response = [0 => $response];
@@ -548,7 +548,7 @@ 
         }
 
         $that = $this;
-        $this->getScores->get(function ($scores) use ($that) {
+        $this->getScores->get(function($scores) use ($that) {
             if (count($scores['players']) > 0 && isset($scores['players'][0]['login'])) {
 
                 $player = new Player();
@@ -579,7 +579,7 @@ 
 
                     $request = new Request("dedimania.SetChallengeTimes", $params);
 
-                    $that->sendRequest($request, function ($response) {
+                    $that->sendRequest($request, function($response) {
                         $this->console->writeln('Dedimania: $0f0records saved.');
                     });
                 } catch (\Exception $e) {

src_experimantal/eXpansionExperimantal/Bundle/Dedimania/Services/DedimaniaService.php

Doc Comments +7 added lines, -4 removed lines

@@ -86,6 +86,9 @@ 
         $this->dispatcher->dispatch('expansion.dedimania.records.load', [$records]);
     }
 
+    /**
+     * @param integer $login
+     */
     public function getRecord($login)
     {
         if (isset($this->recordsByLogin[$login])) {
@@ -200,7 +203,7 @@ 
 
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getServerMaxRank()
     {
@@ -241,7 +244,7 @@ 
     }
 
     /**
-     * @param $login
+     * @param string $login
      */
     public function disconnectPlayer($login)
     {
@@ -269,7 +272,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getGReplay()
     {
@@ -287,7 +290,7 @@ 
     }
 
     /**
-     * @return string|false
+     * @return boolean
      */
     public function isDisabled()
     {