TotoWindowFactory_old::updateContent() - Code Metrics - Inspection of "WIP : Ui builder mock" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#304)

unknown

created 2018-04-18 19:45 UTC

TotoWindowFactory_old::updateContent() C

↳ Parent: TotoWindowFactory_old

Complexity

Conditions	7
Paths	19

Size

Total Lines	77
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	77
rs	6.5755
c	0
b	0
f	0
cc	7
eloc	47
nc	19
nop	1

How to fix Long Method

<?php

namespace eXpansion\Bundle\Acme\Plugins\Gui;

use eXpansion\Bundle\Maps\Services\JukeboxService;
use eXpansion\Framework\Core\Helpers\Time;
use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Model\Gui\Widget;
use eXpansion\Framework\Core\Model\Gui\WindowFactoryContext;
use eXpansion\Framework\Core\Plugins\Gui\WindowFactory as BaseWindowFactory;
use eXpansion\Framework\Core\Storage\MapStorage;
use eXpansion\Framework\Gui\Builders\uiBuilder;

class TotoWindowFactory_old extends BaseWindowFactory
{
    /**
     * @var MapStorage
     */
    private $mapStorage;
    /**
     * @var Time
     */
    private $time;
    /**
     * @var JukeboxService
     */
    private $jukeboxService;

    /**
     * TotoWindowFactory constructor.
     * @param                      $name
     * @param                      $sizeX
     * @param                      $sizeY
     * @param null                 $posX
     * @param null                 $posY
     * @param WindowFactoryContext $context
     * @param MapStorage           $mapStorage
     * @param Time                 $time
     * @param JukeboxService       $jukeboxService
     */
    public function __construct(
        $name,
        $sizeX,
        $sizeY,
        $posX = null,
        $posY = null,
        WindowFactoryContext $context,
        MapStorage $mapStorage,
        Time $time,
        JukeboxService $jukeboxService
    ) {
        parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);
        $this->mapStorage = $mapStorage;
        $this->time = $time;
        $this->jukeboxService = $jukeboxService;
    }

    /**
     * @param ManialinkInterface|Widget $manialink
     */
    protected function updateContent(ManialinkInterface $manialink)
    {
        parent::updateContent($manialink);

        $manialink->getContentFrame()->removeAllChildren();

        $builder = new uiBuilder($this->uiFactory, $this->actionFactory, $manialink, $this);

        $maps = $this->mapStorage->getMaps();

        $current = $this->mapStorage->getCurrentMap();

        $queue = $this->jukeboxService->getMapQueue();


        $x = 0;

        $inc = '<uiLayoutLine margin="1">';
        foreach ($maps as $map) {
            $juke = "";

            if ($x % 8 == 0) {
                if ($x != 0) {
                    $inc .= '</uiLayoutRow>';
                }
                $inc .= '<uiLayoutRow margin="1">';
            }

            if ($map->uId == $current->uId) {
                $color = "0f03";
                $juke = "<uiLabel pos='1 -7' width='30' textColor='fff' textSize='1'>Map Currently Playing</uiLabel>";
            } else {
                $color = "fff3";
            }



            $n = $x + 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


            $idx = 1;
            $sym = "";
            $gtime = "";
            foreach ($queue as $qmap) {
                if ($map->uId == $qmap->getMap()->uId) {
                    $nick = $qmap->getPlayer()->getNickName();
                    $color = "ff03";
                    $sym = "⏳".$idx;
                    $juke = "<uiLabel pos='1 -7' width='30' textColor='fff' textSize='1'>In Queue. Wished by $nick</uiLabel>";
                }
                $idx += 1;
            }

            $inc .= <<<EOL
                <frame size="40 10">              
                     <uiLabel actionCallback='callbackOk' actionParam='{$map->uId}' pos="32 -1" textColor="fff" textSize="4">$sym</uiLabel>                 
                     <uiLabel pos="1 -1" width="30" textColor="fff" textSize="1.5">{$map->name}</uiLabel>
                     <uiLabel pos="1 -4" width="30" textColor="fff" textSize="1">{$map->author} / {$gtime}</uiLabel> 
                     $juke
                     <quad backgroundColor="$color" size="40 10"/>         
                </frame>
EOL;
            $x++;
        }

        $inc .= '</uiLayoutRow>';
        $inc .= '</uiLayoutLine>';

        $manialink->getContentFrame()->addChild($builder->build(/** @lang text */
            <<<EOL
<window id="main">
           $inc
</window>
EOL
        ));

    }

    /*
     * <uiLayoutRow margin="2.">
            <uiLayoutLine margin="2">
                <uiButton actionCallback="callbackOk" type="decorated" >Ok</uiButton>
                <uiButton>Cancel</uiButton>
            </uiLayoutLine>
        </uiLayoutRow>
     */

    /** @var ManialinkInterface $manialink */
    public function callbackOk(
        $manialink,
        $login,
        $entries,
        $args
    ) {

        $map = $this->mapStorage->getMap($args['id']);
        if ($this->jukeboxService->checkMap($map)) {
            $this->jukeboxService->removeMap($map, $login, false);

        } else {
            $this->jukeboxService->addMapLast($map, $login, false);

        }


        $this->update($manialink->getUserGroup());
    }
}


1			<?php
2
3			namespace eXpansion\Bundle\Acme\Plugins\Gui;
4
5			use eXpansion\Bundle\Maps\Services\JukeboxService;
6			use eXpansion\Framework\Core\Helpers\Time;
7			use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
8			use eXpansion\Framework\Core\Model\Gui\Widget;
9			use eXpansion\Framework\Core\Model\Gui\WindowFactoryContext;
10			use eXpansion\Framework\Core\Plugins\Gui\WindowFactory as BaseWindowFactory;
11			use eXpansion\Framework\Core\Storage\MapStorage;
12			use eXpansion\Framework\Gui\Builders\uiBuilder;
13
14			class TotoWindowFactory_old extends BaseWindowFactory
15			{
16			/**
17			* @var MapStorage
18			*/
19			private $mapStorage;
20			/**
21			* @var Time
22			*/
23			private $time;
24			/**
25			* @var JukeboxService
26			*/
27			private $jukeboxService;
28
29			/**
30			* TotoWindowFactory constructor.
31			* @param $name
32			* @param $sizeX
33			* @param $sizeY
34			* @param null $posX
35			* @param null $posY
36			* @param WindowFactoryContext $context
37			* @param MapStorage $mapStorage
38			* @param Time $time
39			* @param JukeboxService $jukeboxService
40			*/
41			public function __construct(
42			$name,
43			$sizeX,
44			$sizeY,
45			$posX = null,
46			$posY = null,
47			WindowFactoryContext $context,
48			MapStorage $mapStorage,
49			Time $time,
50			JukeboxService $jukeboxService
51			) {
52			parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);
53			$this->mapStorage = $mapStorage;
54			$this->time = $time;
55			$this->jukeboxService = $jukeboxService;
56			}
57
58			/**
59			* @param ManialinkInterface\|Widget $manialink
60			*/
61			protected function updateContent(ManialinkInterface $manialink)
62			{
63			parent::updateContent($manialink);
64
65			$manialink->getContentFrame()->removeAllChildren();
66
67			$builder = new uiBuilder($this->uiFactory, $this->actionFactory, $manialink, $this);
68
69			$maps = $this->mapStorage->getMaps();
70
71			$current = $this->mapStorage->getCurrentMap();
72
73			$queue = $this->jukeboxService->getMapQueue();
74
75
76			$x = 0;
77
78			$inc = '<uiLayoutLine margin="1">';
79			foreach ($maps as $map) {
80			$juke = "";
81
82			if ($x % 8 == 0) {
83			if ($x != 0) {
84			$inc .= '</uiLayoutRow>';
85			}
86			$inc .= '<uiLayoutRow margin="1">';
87			}
88
89			if ($map->uId == $current->uId) {
90			$color = "0f03";
91			$juke = "<uiLabel pos='1 -7' width='30' textColor='fff' textSize='1'>Map Currently Playing</uiLabel>";
92			} else {
93			$color = "fff3";
94			}
95
96
97
98			$n = $x + 1;
			0 ignored issues – show Unused Code introduced 2018-04-18 19:49 UTC by Report Bug Copy Issue Report `$n` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
99
100
101			$idx = 1;
102			$sym = "";
103			$gtime = "";
104			foreach ($queue as $qmap) {
105			if ($map->uId == $qmap->getMap()->uId) {
106			$nick = $qmap->getPlayer()->getNickName();
107			$color = "ff03";
108			$sym = "⏳".$idx;
109			$juke = "<uiLabel pos='1 -7' width='30' textColor='fff' textSize='1'>In Queue. Wished by $nick</uiLabel>";
110			}
111			$idx += 1;
112			}
113
114			$inc .= <<<EOL
115			<frame size="40 10">
116			<uiLabel actionCallback='callbackOk' actionParam='{$map->uId}' pos="32 -1" textColor="fff" textSize="4">$sym</uiLabel>
117			<uiLabel pos="1 -1" width="30" textColor="fff" textSize="1.5">{$map->name}</uiLabel>
118			<uiLabel pos="1 -4" width="30" textColor="fff" textSize="1">{$map->author} / {$gtime}</uiLabel>
119			$juke
120			<quad backgroundColor="$color" size="40 10"/>
121			</frame>
122			EOL;
123			$x++;
124			}
125
126			$inc .= '</uiLayoutRow>';
127			$inc .= '</uiLayoutLine>';
128
129			$manialink->getContentFrame()->addChild($builder->build(/** @lang text */
130			<<<EOL
131			<window id="main">
132			$inc
133			</window>
134			EOL
135			));
136
137			}
138
139			/*
140			* <uiLayoutRow margin="2.">
141			<uiLayoutLine margin="2">
142			<uiButton actionCallback="callbackOk" type="decorated" >Ok</uiButton>
143			<uiButton>Cancel</uiButton>
144			</uiLayoutLine>
145			</uiLayoutRow>
146			*/
147
148			/** @var ManialinkInterface $manialink */
149			public function callbackOk(
150			$manialink,
151			$login,
152			$entries,
153			$args
154			) {
155
156			$map = $this->mapStorage->getMap($args['id']);
157			if ($this->jukeboxService->checkMap($map)) {
158			$this->jukeboxService->removeMap($map, $login, false);
159
160			} else {
161			$this->jukeboxService->addMapLast($map, $login, false);
162
163			}
164
165
166			$this->update($manialink->getUserGroup());
167			}
168			}
169

eXpansionPluginPack / eXpansion2

Pull Request — master (#304)

TotoWindowFactory_old::updateContent() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like