Completed
Pull Request — master (#127)
by De Cramer
04:50
created
src/eXpansion/Framework/Core/Model/Gui/Grid/DataCollection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
     /**
75 75
      * Get the number of the last page.
76 76
      *
77
-     * @return int
77
+     * @return double
78 78
      */
79 79
     public function getLastPageNumber()
80 80
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
         }
164 164
         if (!is_null($this->sort)) {
165 165
             $sort = $this->sort;
166
-            uasort($this->filteredData, function ($a, $b) use ($sort) {
166
+            uasort($this->filteredData, function($a, $b) use ($sort) {
167 167
                 $comp = (strcmp($a[$sort[0]], $b[$sort[0]]));
168 168
                 if ($sort[1] == "DESC") {
169 169
                     return -1 * $comp;
Please login to merge, or discard this patch.
src/eXpansion/Framework/Core/Model/Gui/Factory/TitleLineFactory.php 3 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,6 @@
 block discarded – undo
41 41
      * @param array $columns
42 42
      * @param int $index
43 43
      * @param float $height
44
-     * @param bool $autoNewLine
45
-     * @param int $maxLines
46 44
      *
47 45
      * @return Frame
48 46
      *
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,14 +2,10 @@
 block discarded – undo
2 2
 
3 3
 namespace eXpansion\Framework\Core\Model\Gui\Factory;
4 4
 
5
-use eXpansion\Framework\Gui\Components\uiCheckbox;
6
-use eXpansion\Framework\Gui\Components\uiInput;
7 5
 use eXpansion\Framework\Gui\Components\uiLabel;
8 6
 use eXpansion\Framework\Gui\Components\uiTooltip;
9 7
 use eXpansion\Framework\Gui\Ui\Factory;
10
-use FML\Controls\Control;
11 8
 use FML\Controls\Frame;
12
-use FML\Controls\Label;
13 9
 use oliverde8\AssociativeArraySimplified\AssociativeArray;
14 10
 
15 11
 /**
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
         $tooltip = $this->uiFactory->createTooltip();
55 55
 
56 56
         $totalCoef
57
-            = ($totalWidth - 1) / array_reduce($columns, function ($carry, $item) {
57
+            = ($totalWidth - 1) / array_reduce($columns, function($carry, $item) {
58 58
                 return $carry + $item['width'];
59 59
             });
60 60
 
Please login to merge, or discard this patch.