Completed
Pull Request — master (#294)
by De Cramer
17:11
created
src/eXpansion/Framework/Config/Ui/Fields/TextListField.php 2 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
      * @param $config
92 92
      * @param $manialink
93 93
      * @param $element
94
-     * @param $width
94
+     * @param double $width
95 95
      *
96 96
      * @return \eXpansion\Framework\Gui\Layouts\LayoutLine
97 97
      */
@@ -107,6 +107,10 @@  discard block
 block discarded – undo
107 107
             ->setAction(
108 108
                 $this->actionFactory->createManialinkAction(
109 109
                     $manialink,
110
+
111
+                    /**
112
+                     * @param double $args
113
+                     */
110 114
                     function (ManialinkInterface $manialink, $login, $entries, $args) {
111 115
                         /** @var TextListConfig $config */
112 116
                         $config = $args['config'];
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
             ->setAction(
64 64
                 $this->actionFactory->createManialinkAction(
65 65
                     $manialink,
66
-                    function (ManialinkInterface $manialink, $login, $entries, $args) {
66
+                    function(ManialinkInterface $manialink, $login, $entries, $args) {
67 67
                         /** @var TextListConfig $config */
68 68
                         $config = $args['config'];
69 69
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
                 )
78 78
             );
79 79
 
80
-        $elements = [$this->uiFactory->createLayoutLine(0,0, [$input, $addButton])];
80
+        $elements = [$this->uiFactory->createLayoutLine(0, 0, [$input, $addButton])];
81 81
         foreach ($config->get() as $element) {
82 82
             $elements[] = $this->getElementLine($config, $manialink, $element, $width);
83 83
         }
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
             ->setAction(
108 108
                 $this->actionFactory->createManialinkAction(
109 109
                     $manialink,
110
-                    function (ManialinkInterface $manialink, $login, $entries, $args) {
110
+                    function(ManialinkInterface $manialink, $login, $entries, $args) {
111 111
                         /** @var TextListConfig $config */
112 112
                         $config = $args['config'];
113 113
                         $config->remove($args['element']);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                 )
119 119
             );
120 120
 
121
-        return $this->uiFactory->createLayoutLine(0,0, [$label, $delButton]);
121
+        return $this->uiFactory->createLayoutLine(0, 0, [$label, $delButton]);
122 122
     }
123 123
 
124 124
     /**
Please login to merge, or discard this patch.
src/eXpansion/Framework/Config/Ui/Window/ConfigWindowFactory.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use eXpansion\Framework\Core\Plugins\Gui\WindowFactory;
14 14
 use eXpansion\Framework\Gui\Components\Button;
15 15
 use eXpansion\Framework\Gui\Components\Label;
16
-use eXpansion\Framework\Gui\Components\Tooltip;
17 16
 use FML\Controls\Control;
18 17
 use FML\Controls\Frame;
19 18
 use FML\Controls\Quad;
Please login to merge, or discard this patch.
eXpansion/Framework/AdminGroups/DependencyInjection/Compiler/ConfigPass.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -35,15 +35,15 @@  discard block
 block discarded – undo
35 35
 
36 36
         foreach ($groups as $groupCode => $group)
37 37
         {
38
-            $pathPrefix = $container->getParameter('expansion.admin_groups.config.path') . "/$groupCode";
38
+            $pathPrefix = $container->getParameter('expansion.admin_groups.config.path')."/$groupCode";
39 39
 
40
-            $id = 'expansion.admin_groups.config.label.' . $groupCode;
40
+            $id = 'expansion.admin_groups.config.label.'.$groupCode;
41 41
             $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.label.abstract'))
42 42
                 ->replaceArgument('$path', "$pathPrefix/label")
43 43
                 ->replaceArgument('$defaultValue', $group['label']);
44 44
             $configManager->addMethodCall('registerConfig', [new Reference($id), $id]);
45 45
 
46
-            $id = 'expansion.admin_groups.config.logins.' . $groupCode;
46
+            $id = 'expansion.admin_groups.config.logins.'.$groupCode;
47 47
             $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.logins.abstract'))
48 48
                 ->setArgument('$path', "$pathPrefix/logins")
49 49
                 ->setArgument('$defaultValue', $group['logins']);
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
             if ($groupCode != "master_admin") {
53 53
                 foreach ($permissions as $permission) {
54
-                    $id = 'expansion.admin_groups.config.permissions.' . $groupCode . '.permission';
54
+                    $id = 'expansion.admin_groups.config.permissions.'.$groupCode.'.permission';
55 55
                     $container->setDefinition($id, new ChildDefinition('expansion.admin_groups.config.logins.abstract'))
56 56
                         ->setArgument('$path', "$pathPrefix/perm_perm")
57 57
                         ->setArgument('$defaultValue', $group['logins'])
Please login to merge, or discard this patch.