eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Inventory/Model/Details/Request/Builder.php

Doc Comments +1 added lines

@@ -50,6 +50,7 @@
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce($key, array $arr, $default)

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInStorePickUpItem;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IShippingItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInventoryDetailsRequest;
 
 class EbayEnterprise_Inventory_Model_Details_Request_Builder extends

Indentation +13 added lines, -13 removed lines

@@ -1,24 +1,24 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInStorePickUpItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IShippingItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInventoryDetailsRequest;
 
 class EbayEnterprise_Inventory_Model_Details_Request_Builder extends
- EbayEnterprise_Inventory_Model_Details_Request_Builder_Abstract
+    EbayEnterprise_Inventory_Model_Details_Request_Builder_Abstract
 {
     /** @var EbayEnterprise_Inventory_Helper_Details_Item */
     protected $itemHelper;

src/app/code/community/EbayEnterprise/Inventory/Model/Details/Request/Builder/Abstract.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      *
      * @param  Mage_Sales_Model_Quote_Item_Abstract
      * @param  Mage_Customer_Model_Address_Abstract
-     * @return IInStorePickUpItem|null
+     * @return Payload\Inventory\IInStorePickUpItemIterable|null
      */
     protected function getIspuItem(
         Mage_Sales_Model_Quote_Item_Abstract $item,

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
  */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInStorePickUpItem;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IShippingItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInventoryDetailsRequest;
 
 abstract class EbayEnterprise_Inventory_Model_Details_Request_Builder_Abstract

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInStorePickUpItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IShippingItem;

src/app/code/community/EbayEnterprise/Inventory/Model/Details/Service.php

Doc Comments +1 added lines

@@ -73,6 +73,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Inventory_Model_Details_Service
 {

Spacing +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
      */
     protected function getQuoteItemId(Mage_Sales_Model_Quote_Item_Abstract $item)
     {
-        $children = $item->getChildren() ?:  [];
+        $children = $item->getChildren() ?: [];
         foreach ($children as $childItem) {
             return $childItem->getId();
         }

src/app/code/community/EbayEnterprise/Inventory/Model/Observer.php

Doc Comments +1 added lines

@@ -92,6 +92,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Inventory_Model_Observer
 {

Braces +1 added lines, -2 removed lines

@@ -147,8 +147,7 @@
     protected function handleAdminOrderException(
         EbayEnterprise_Inventory_Exception_Quantity_Unavailable_Exception $e,
         Mage_Sales_Model_Quote $quote
-    )
-    {
+    ) {
         $this->getAdminQuoteSession()->addError($e->getMessage());
         foreach ($quote->getAllVisibleItems() as $quoteItem) {
             if (!$this->quantityService->isItemAvailable($quoteItem)) {

src/app/code/community/EbayEnterprise/Inventory/Model/Order/Create/Item/Allocation.php

Doc Comments +1 added lines, -5 removed lines

@@ -37,11 +37,6 @@ 
     protected $logContext;
 
     /**
-     * @param array $args May contain:
-     *                    - helper => EbayEnterprise_Inventory_Helper_Data
-     *                    - allocation_service => EbayEnterprise_Inventory_Model_Allocation_Service
-     *                    - logger => EbayEnterprise_MageLog_Helper_Data
-     *                    - log_context => EbayEnterprise_MageLog_Helper_Context
      */
     public function __construct(array $init = [])
     {
@@ -86,6 +81,7 @@ 
      * @param array
      * @param string
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)

Indentation +19 added lines, -19 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use \eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 
@@ -182,13 +182,13 @@ 
             && $allocation->getQuantityAllocated() < $item->getQtyOrdered();
     }
 
-     /**
-     * Determine if the passed in item is backorderable.
-     *
-     * @param  Mage_Core_Model_Abstract
-     * @param  int
-     * @return bool
-     */
+        /**
+         * Determine if the passed in item is backorderable.
+         *
+         * @param  Mage_Core_Model_Abstract
+         * @param  int
+         * @return bool
+         */
     protected function isBackorderable(Mage_Core_Model_Abstract $item)
     {
         return $this->getStockItem($item)->getBackorders() > Mage_CatalogInventory_Model_Stock::BACKORDERS_NO;

src/app/code/community/EbayEnterprise/Inventory/Model/Order/Create/Item/Details.php

Doc Comments +2 added lines, -1 removed lines

@@ -72,6 +72,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)
@@ -83,7 +84,7 @@ 
      * Enforce type checks for the config key in the constructors parameter array $args.
      *
      * @param EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry[]
      */
     protected function checkConfigTypes(EbayEnterprise_Eb2cCore_Model_Config_Registry $config)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use \eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 use \eBayEnterprise\RetailOrderManagement\Payload\Order\IEstimatedDeliveryDate;

src/app/code/community/EbayEnterprise/Inventory/Model/Quantity/Collector.php

Doc Comments +3 added lines, -1 removed lines

@@ -85,6 +85,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)
@@ -120,7 +121,7 @@ 
      * if they are valid and apply to the current state of the provided items.
      *
      * @param Mage_Sales_Model_Quote_Item[]
-     * @return EbayEnterprise_Inventory_Model_Quantity_Restults|null
+     * @return EbayEnterprise_Inventory_Model_Quantity_IResults|null
      */
     protected function getSessionResults(array $items)
     {
@@ -135,6 +136,7 @@ 
      * Request new quantity results.
      *
      * @param Mage_Sales_Model_Quote_Item[]
+     * @param Mage_Sales_Model_Quote_Item_Abstract[] $items
      * @return EbayEnterprise_Inventory_Model_Quantity_Restults
      */
     protected function requestNewResults($items)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 use Psr\Log\LoggerInterface;
 
 class EbayEnterprise_Inventory_Model_Quantity_Collector

src/app/code/community/EbayEnterprise/Inventory/Model/Quantity/Request/Builder.php

Doc Comments +2 added lines, -1 removed lines

@@ -68,7 +68,8 @@
      * @param string
      * @param array
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Inventory_Helper_Quantity_Payload
      */
     protected function _nullCoalesce(array $arr, $key, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IQuantityRequest;
 

src/app/code/community/EbayEnterprise/Inventory/Model/Quantity/Response/Parser.php

Doc Comments +2 added lines, -1 removed lines

@@ -62,7 +62,8 @@
      * @param string
      * @param array
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Inventory_Helper_Quantity_Factory
      */
     protected function _nullCoalesce(array $arr, $key, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IQuantityReply;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IReplyQuantityItem;