eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Address/Helper/Data.php

Doc Comments +3 added lines, -1 removed lines

@@ -98,7 +98,9 @@
      *
      * @param string
      * @param string
-     * @return string
+     * @param string $regionCode
+     * @param string $countryCode
+     * @return integer
      */
     public function getRegionIdByCode($regionCode, $countryCode)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Checkout\IPhysicalAddress;
 

src/app/code/community/EbayEnterprise/Address/Model/Observer.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Address_Model_Observer
 {

src/app/code/community/EbayEnterprise/Address/Model/Order/Address/Validation.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */

Indentation +13 added lines, -13 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Address_Model_Order_Address_Validation
 {
@@ -70,7 +70,7 @@ 
      */
     public function allowAddressValidation(Mage_Customer_Model_Address_Abstract $address)
     {
-       /** @var Mage_Core_Controller_Request_Http */
+        /** @var Mage_Core_Controller_Request_Http */
         $request = $this->app->getRequest();
         /** @var bool */
         $needValidation = $this->validator->shouldValidateAddress($address);

src/app/code/community/EbayEnterprise/Address/Model/Validation/Request.php

Doc Comments +2 added lines, -2 removed lines

@@ -63,9 +63,9 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
-     * @return mixed
+     * @return EbayEnterprise_Address_Helper_Data
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 

src/app/code/community/EbayEnterprise/Address/Model/Validator.php

Doc Comments +4 added lines, -4 removed lines

@@ -72,7 +72,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */
@@ -321,7 +321,7 @@ 
     /**
      * Perform the web request for address validation and return the response
      * @param Mage_Customer_Model_Address_Abstract $address
-     * @return EbayEnterprise_Address_Model_Validation_Response|null
+     * @return EbayEnterprise_Address_Model_Validatoin_Response|null
      */
     protected function _makeRequestForAddress(Mage_Customer_Model_Address_Abstract $address)
     {
@@ -367,7 +367,7 @@ 
      *
      * @param Mage_Customer_Model_Address_Abstract
      * @param IBidirectionalApi
-     * @return \eBayEnterprise\RetailOrderManagement\Payload\Address\IValidationRequest
+     * @return IBidirectionalApi
      */
     protected function _prepareApiForAddressRequest(Mage_Customer_Model_Address_Abstract $address, IBidirectionalApi $api)
     {
@@ -409,7 +409,7 @@ 
      *
      * @param Mage_Customer_Model_Address_Abstract $address
      * @param string $errorMessage
-     * @return EbayEnterprise_Address_Model_Validation_Response|null
+     * @return EbayEnterprise_Address_Model_Validatoin_Response|null
      */
     protected function _processRequest(Mage_Customer_Model_Address_Abstract $address, &$errorMessage)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;

src/app/code/community/EbayEnterprise/Address/Test/Model/ObserverTest.php

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         $this->_setupBaseUrl();
     }
 
+    /**
+     * @param integer $enabled
+     */
     protected function _mockConfig($enabled)
     {
         $config = $this->getModelMockBuilder('eb2ccore/config_registry')

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use EcomDev_PHPUnit_Test_Case_Util as TestUtil;
-
 class EbayEnterprise_Address_Test_Model_ObserverTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
     public function setUp()

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use EcomDev_PHPUnit_Test_Case_Util as TestUtil;
 

src/app/code/community/EbayEnterprise/Address/Test/Model/Suggestion/GroupTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -17,8 +17,8 @@
 {
     /**
      * Create a new address object using the provided array of data.
-     * @param array $addressData
-     * @return Mage_Customer_Model_Address
+     * @param string|null $type
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _createAddress($type)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Address_Test_Model_Suggestion_GroupTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Address/Test/Model/ValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -193,7 +193,7 @@
 
     /**
      * Setup the session data with the supplied addresses.
-     * @param Mage_Customer_Model_Address_Abstract $original
+     * @param Mage_Customer_Model_Address|null $original
      * @param Mage_Customer_Model_Address_Abstract[] $suggestions
      * @param bool $hasFreshSuggestions
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;

Spacing +4 added lines, -4 removed lines

@@ -917,8 +917,8 @@ 
             ->method('getAddressType')
             ->will($this->returnValue($addressType));
         $addressData = [
-            ['street',    null, '123 Main St'],
-            ['city',      null, 'Fooville'],
+            ['street', null, '123 Main St'],
+            ['city', null, 'Fooville'],
             ['region_id', null, 51],
         ];
         $address->expects($this->any())
@@ -967,8 +967,8 @@ 
         // any one of these being different from the validatedAddressData below
         // will cause the comparison check fail
         $addressData = [
-            ['street',    null, 'Borg'],
-            ['city',      null, 'Barton'],
+            ['street', null, 'Borg'],
+            ['city', null, 'Barton'],
             ['region_id', null, 41],
         ];
         $address->expects($this->any())

src/app/code/community/EbayEnterprise/Amqp/Block/System/Config/Testamqpconnection.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * Type hints for injected dependencies via the self::__construct $args
      * @param  EbayEnterprise_Amqp_Helper_Data $amqpHelper
-     * @return mixed[]
+     * @return EbayEnterprise_Amqp_Helper_Data[]
      */
     protected function _checkTypes(EbayEnterprise_Amqp_Helper_Data $amqpHelper)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * @codeCoverageIgnore Mostly side-effects, little that can be covered well by unit tests