eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Eb2cFraud/Model/Order/Create/Context.php

Doc Comments +2 added lines, -1 removed lines

@@ -47,7 +47,7 @@ 
      * @param  EbayEnterprise_Eb2cFraud_Helper_Http
      * @param  EbayEnterprise_Eb2cCore_Helper_Data
      * @param  Mage_Core_Model_Cookie
-     * @return array
+     * @return Mage_Core_Model_Cookie[]
      */
     protected function _checkTypes(
         EbayEnterprise_Eb2cFraud_Helper_Data $helper,
@@ -63,6 +63,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce($key, array $ar, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use \eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderContext;
 

src/app/code/community/EbayEnterprise/Eb2cGiftwrap/Model/Order/Create/Gifting.php

Doc Comments +7 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
      * enforce injected types
      * @param  EbayEnterprise_MageLog_Helper_Data
      * @param  EbayEnterprise_Eb2cGiftwrap_Helper_Data
-     * @return array
+     * @return EbayEnterprise_MageLog_Helper_Data[]
      */
     protected function _checkTypes(
         EbayEnterprise_MageLog_Helper_Data $logger,
@@ -46,6 +46,11 @@ 
         return array($logger, $helper);
     }
 
+    /**
+     * @param string $key
+     *
+     * @return EbayEnterprise_MageLog_Helper_Data
+     */
     protected function _nullCoalesce($key, array $arr, $default = null)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -83,7 +88,7 @@ 
      * get the gifting pricegroup; a new price group is created
      * and attached if one doesn't exist.
      * @param  IGifting
-     * @return IPriceGroup
+     * @return Payload\Order\IPriceGroup
      */
     protected function _getPriceGroup(IGifting $giftingPayload)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IGifting;
 

src/app/code/community/EbayEnterprise/GiftCard/Block/Checkout/Onepage/Payment/Additional.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      * @return mixed
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_GiftCard_Block_Checkout_Onepage_Payment_Additional extends EbayEnterprise_GiftCard_Block_Template_Abstract
 {

src/app/code/community/EbayEnterprise/GiftCard/Helper/Data.php

Doc Comments +3 added lines, -5 removed lines

@@ -28,9 +28,7 @@ 
 
     /**
      * Type checks for self::__construct $initParams
-     * @param  EbayEnterprise_GiftCard_Model_IContainer $checkoutSession
-     * @param  EbayEnterprise_MageLog_Helper_Data $logger
-     * @return mixed[]
+     * @return EbayEnterprise_GiftCard_Model_IContainer[]
      */
     protected function _checkTypes(
         EbayEnterprise_GiftCard_Model_IContainer $container
@@ -42,9 +40,9 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
-     * @return mixed
+     * @return EbayEnterprise_GiftCard_Model_IContainer
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

src/app/code/community/EbayEnterprise/GiftCard/Helper/Tendertype.php

Doc Comments +5 added lines

@@ -56,6 +56,9 @@ 
         return func_get_args();
     }
 
+    /**
+     * @param string $key
+     */
     protected function nullCoalesce(array $arr, $key, $default)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -66,6 +69,8 @@ 
      * @param string
      * @param string
      * @param bool
+     * @param string $cardNumber
+     * @param null|string $currencyCode
      * @return string
      * @throws EbayEnterprise_GiftCard_Exception_InvalidCardNumber_Exception If card number cannot be retrieved.
      */

Unused Use Statements +1 added lines, -1 removed lines

@@ -1,8 +1,8 @@
 <?php
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 
 /**
  * performs gift card tender type lookups using the Retail Order Management

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      * @return string
      * @throws EbayEnterprise_GiftCard_Exception_InvalidCardNumber_Exception If card number cannot be retrieved.
      */
-    public function lookupTenderType($cardNumber, $currencyCode, $panIsToken=false)
+    public function lookupTenderType($cardNumber, $currencyCode, $panIsToken = false)
     {
         try {
             $api = $this->getTenderTypeLookupApi();

src/app/code/community/EbayEnterprise/GiftCard/Model/Adminhtml/Observer.php

Doc Comments +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
     }
     /**
      * Get post data from the request. If not set, return the default value.
-     * @param string|int $field
+     * @param string $field
      * @param string $default
      * @return string
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_GiftCard_Model_Adminhtml_Observer
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Container.php

Doc Comments +3 added lines, -3 removed lines

@@ -58,9 +58,9 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array $arr
-     * @param  string|int $field Valid array key
-     * @param  mixed $default
-     * @return mixed
+     * @param  string $field Valid array key
+     * @param  SplObjectStorage|null $default
+     * @return SplObjectStorage|null
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_GiftCard_Model_Container implements EbayEnterprise_GiftCard_Model_IContainer
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Giftcard.php

Doc Comments +3 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      * @return mixed
      */
@@ -370,7 +370,6 @@ 
      * Log the different requests consistently.
      *
      * @param string $type 'balance', 'redeem', 'void'
-     * @param string $body the serialized xml body
      * @param string $direction 'request' or 'response'
      */
     protected function logApiCall($type, $direction)
@@ -665,6 +664,8 @@ 
      * @param IBidirectionalApi
      * @param bool
      * @param string
+     * @param boolean $isRequest
+     * @param string $logMessage
      */
     protected function logStoredValuePayload(IBidirectionalApi $api, $isRequest, $logMessage)
     {

Unused Use Statements +3 added lines, -3 removed lines

@@ -13,14 +13,14 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
+use Psr\Log\LoggerInterface;
+use Psr\Log\NullLogger;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 /**
  * Model representing a gift card that has been applied to an order.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;

src/app/code/community/EbayEnterprise/GiftCard/Model/Mask.php

Doc Comments +2 added lines, -1 removed lines

@@ -46,7 +46,8 @@
      * @param  array
      * @param  string | int $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @param string $field
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_GiftCard_Model_Mask
 {

Spacing +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
      * @param  bool
      * @return self
      */
-    protected function doTheMasking(DOMDocument $doc, DOMXPath $xpath, array $nodes, $hasAttribute=false)
+    protected function doTheMasking(DOMDocument $doc, DOMXPath $xpath, array $nodes, $hasAttribute = false)
     {
         foreach ($nodes as $node => $expression) {
             /** @var DOMElement */