eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Config/Registry.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * Get the configuration flag value represented by the given configKey
      * @param string $configKey
      * @param null|string|bool|int|Mage_Core_Model_Store $store
-     * @return bool
+     * @return string|boolean
      */
     public function getConfig($configKey, $store = null)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * Single point of access for retrieving configuration values.

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Observer.php

Doc Comments +2 added lines, -1 removed lines

@@ -44,7 +44,8 @@
      * @param array
      * @param mixed
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function nullCoalesce(array $arr, $key, $default)
     {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/System/Config/Backend/Language/Code.php

Doc Comments +2 added lines, -1 removed lines

@@ -36,7 +36,7 @@ 
 
     /**
      * @param EbayEnterprise_Eb2cCore_Helper_Languages
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Helper_Languages[]
      */
     protected function _checkTypes(
         EbayEnterprise_Eb2cCore_Helper_Languages $langHelper,
@@ -71,6 +71,7 @@ 
      * is not, throw an exception.
      *
      * @param string
+     * @param string $langCode
      * @return self
      * @throws EbayeEnterprise_Eb2cCore_Exception If value is not a valid language code.
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * Clean the provided language code value so it can be consistent with BCP47

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Base.php

Doc Comments +2 added lines, -2 removed lines

@@ -124,8 +124,8 @@
 
     /**
      * @param  string $alias           model alias
-     * @param  array  $methodActions   mapping of method name to a value or PHPUnit_Framework_MockObject_Stub
-     * @return object                  mock object with specified methods mocked under the 'any' invokation constraint.
+     * @param  array  $methods   mapping of method name to a value or PHPUnit_Framework_MockObject_Stub
+     * @return EcomDev_PHPUnit_Mock_Proxy                  mock object with specified methods mocked under the 'any' invokation constraint.
      */
     protected function _buildModelMock($alias, array $methods = [])
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 abstract class EbayEnterprise_Eb2cCore_Test_Base extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/Api/ValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      * Get an eb2ccore helper to translate the messages. Replaces the translate
      * method with a simpler callback that will simply prepend the string
      * "Translated_" to the beginning of the first argument it is passed.
-     * @return Mock_EbayEnterprise_Eb2cCore_Helper_Data
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _getMockTranslationHelper()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 
 class EbayEnterprise_Eb2cCore_Test_Helper_Api_ValidatorTest extends EbayEnterprise_Eb2cCore_Test_Base

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         $helper->expects($this->once())
             ->method('__')
             ->will($this->returnCallback(
-                function ($msg) {
+                function($msg) {
                     return 'Translated_' . $msg;
                 }
             ));

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/ShippingTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -121,7 +121,8 @@
      *
      * @param string
      * @param array $methods shipping method array
-     * @return Mage_Shipping_Model_Carrier_Abstract
+     * @param string $title
+     * @return PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockCarrier($title, $methods = null)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Eb2cCore_Test_Helper_ShippingTest extends EbayEnterprise_Eb2cCore_Test_Base
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Model/SessionTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -33,7 +33,8 @@
      * @param  int     $qty       Qty of the item in the cart
      * @param  bool $isVirtual Is the item virtual
      * @param  int
-     * @return Mage_Sales_Model_Quote_Item The stub quote item
+     * @param integer $itemId
+     * @return EcomDev_PHPUnit_Mock_Proxy The stub quote item
      */
     protected function _stubQuoteItem($sku, $qty, $isVirtual, $itemId)
     {

Indentation +13 added lines, -13 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Eb2cCore_Test_Model_SessionTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
@@ -50,7 +50,7 @@ 
             ->expects($this->any())
             ->method('getIsVirtual')
             ->will($this->returnValue($isVirtual));
-         $item
+            $item
             ->expects($this->any())
             ->method('getId')
             ->will($this->returnValue($itemId));

Spacing +17 added lines, -17 removed lines

@@ -552,11 +552,11 @@ 
 
         return [
             //    old     new   bill       coupon       shipping   items      amounts       final
-            [$old,   $new, $billDiff, $empty,      $empty,    $empty,    $empty,       $billDiff],
-            [$old,   $new, $billDiff, $couponDiff, $empty,    $empty,    $empty,       $billDiff + $couponDiff],
-            [$old,   $new, $empty,    $couponDiff, $shipDiff, $empty,    $empty,       $couponDiff + $shipDiff],
-            [$old,   $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $empty,       $billDiff + $couponDiff + $shipDiff + $itemDiff],
-            [$old,   $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $amountsDiff, $billDiff + $couponDiff + $shipDiff + $itemDiff + $amountsDiff],
+            [$old, $new, $billDiff, $empty, $empty, $empty, $empty, $billDiff],
+            [$old, $new, $billDiff, $couponDiff, $empty, $empty, $empty, $billDiff + $couponDiff],
+            [$old, $new, $empty, $couponDiff, $shipDiff, $empty, $empty, $couponDiff + $shipDiff],
+            [$old, $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $empty, $billDiff + $couponDiff + $shipDiff + $itemDiff],
+            [$old, $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $amountsDiff, $billDiff + $couponDiff + $shipDiff + $itemDiff + $amountsDiff],
         ];
     }
     /**
@@ -693,9 +693,9 @@ 
     {
         return [
             //    currFlag newFlag
-            [true,    false],
-            [false,   true],
-            [false,   false],
+            [true, false],
+            [false, true],
+            [false, false],
         ];
     }
     /**
@@ -856,14 +856,14 @@ 
 
         return [
             // quoteData diff        has virtual hasManaged tax    deets
-            [$quoteData, $coupon,    false,      true,      true,   false],
-            [$quoteData, $billing,   false,      true,      false,  false],
-            [$quoteData, $billing,   true,       true,      true,   false],
-            [$quoteData, $shipping,  false,      true,      true,    true],
-            [$quoteData, $shipping,  false,      false,     true,   false],
-            [$quoteData, $managed,   false,      true,      true,    true],
-            [$quoteData, $noManaged, true,       false,     true,   false],
-            [$quoteData, $amount,    false,      false,     true,   false],
+            [$quoteData, $coupon, false, true, true, false],
+            [$quoteData, $billing, false, true, false, false],
+            [$quoteData, $billing, true, true, true, false],
+            [$quoteData, $shipping, false, true, true, true],
+            [$quoteData, $shipping, false, false, true, false],
+            [$quoteData, $managed, false, true, true, true],
+            [$quoteData, $noManaged, true, false, true, false],
+            [$quoteData, $amount, false, false, true, false],
         ];
     }
     /**
@@ -967,7 +967,7 @@ 
                 // the same. skus should match data extracted from the quote.
                 // last_updated should have been updated to the current time - best
                 // test I can think of for that is just making sure the new time is more recent that the old one
-                function ($quoteData) use ($oldData, $skuDataExtract) {
+                function($quoteData) use ($oldData, $skuDataExtract) {
                     return $quoteData['billing'] === $oldData['billing'] &&
                         $quoteData['coupon'] === $oldData['coupon'] &&
                         $quoteData['shipping'] === $oldData['shipping'] &&

src/app/code/community/EbayEnterprise/Eb2cCustomerService/Overrides/Model/Admin/Session.php

Doc Comments +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
      * user object.
      * @param  Mage_Admin_Model_User $user
      * @param  Mage_Core_Controller_Request_Http $request
-     * @param  Mage_Core_Exception $authException
+     * @param  EbayEnterprise_Eb2cCustomerService_Exception_Authentication $authException
      * @return null
      * @codeCoverageIgnore All side-effects taken from Magento auth/login process
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 
 class EbayEnterprise_Eb2cCustomerService_Overrides_Model_Admin_Session extends Mage_Admin_Model_Session

Braces +1 added lines, -2 removed lines

@@ -63,8 +63,7 @@
         EbayEnterprise_MageLog_Helper_Data $logger,
         EbayEnterprise_MageLog_Helper_Context $context,
         Mage_Adminhtml_Model_Url $url
-    )
-    {
+    ) {
         return func_get_args();
     }
 

src/app/code/community/EbayEnterprise/Eb2cFraud/Helper/Data.php

Doc Comments +1 added lines

@@ -65,6 +65,7 @@
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce($key, array $ar, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Eb2cFraud_Helper_Data extends Mage_Core_Helper_Abstract
 {