eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Catalog/Helper/Pim.php

Doc Comments +16 added lines, -16 removed lines

@@ -27,7 +27,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getValueAsDefault($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -47,7 +47,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passString($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -63,7 +63,7 @@ 
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
      * @throws EbayEnterprise_Catalog_Model_Pim_Product_Validation_Exception
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSKU($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -84,7 +84,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStringIf($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -102,7 +102,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passPrice($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -117,7 +117,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passDecimal($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -132,7 +132,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passDate($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -148,7 +148,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passInteger($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -164,7 +164,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passYesNoToBool($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -292,7 +292,7 @@ 
     /**
      * given a string representing decimal value if the string is a numeric value cast it as float otherwise return null
      * @param string $value
-     * @return int | null
+     * @return double|null | null
      */
     public function createDecimal($value)
     {
@@ -357,7 +357,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStyleId($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -372,7 +372,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return null|DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftCard($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -402,7 +402,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passProductLinks($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -457,7 +457,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passCategoryLinks($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -487,7 +487,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftWrap($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -504,7 +504,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passIsoCountryCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Helper_Pim
 {

Spacing +9 added lines, -12 removed lines

@@ -203,8 +203,7 @@ 
         $domAttribute = $this->_getDomAttr($doc, $attribute);
         $lastRunTime = Mage::helper('ebayenterprise_catalog')->getConfigModel()->pimExportFeedCutoffDate;
         $domAttribute->value = strtotime($product->getCreatedAt()) > strtotime($lastRunTime) ?
-            static::NEW_PRODUCT_OPERATION_TYPE :
-            static::DEFAULT_OPERATION_TYPE;
+            static::NEW_PRODUCT_OPERATION_TYPE : static::DEFAULT_OPERATION_TYPE;
         return $domAttribute;
     }
     /**
@@ -278,7 +277,7 @@ 
      */
     public function createDateTime($value)
     {
-        return !empty($value)? date('c', strtotime($value)) : null;
+        return !empty($value) ? date('c', strtotime($value)) : null;
     }
     /**
      * given a string representing integer value if the string is a numeric value cast it as integer otherwise return null
@@ -287,7 +286,7 @@ 
      */
     public function createInteger($value)
     {
-        return is_numeric($value)? (int) $value : null;
+        return is_numeric($value) ? (int) $value : null;
     }
     /**
      * given a string representing decimal value if the string is a numeric value cast it as float otherwise return null
@@ -296,7 +295,7 @@ 
      */
     public function createDecimal($value)
     {
-        return is_numeric($value)? (float) $value : null;
+        return is_numeric($value) ? (float) $value : null;
     }
     /**
      * given a string if it is '1' return 'true' otherwise 'false'
@@ -305,7 +304,7 @@ 
      */
     public function createBool($value)
     {
-        return ($value === '1')? 'true' : 'false';
+        return ($value === '1') ? 'true' : 'false';
     }
     /**
      * For a given product, look for a configurable product using that product.
@@ -382,11 +381,9 @@ 
         }
         $cfg = Mage::helper('ebayenterprise_catalog')->getConfigModel();
         $allowMessage = $product->getUseConfigAllowMessage() ?
-            $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_ALLOW_MESSAGE) :
-            $product->getAllowMessage();
+            $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_ALLOW_MESSAGE) : $product->getAllowMessage();
         $MessageMaxLength = $allowMessage ?
-            (int) $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_MESSAGE_MAX_LENGTH) :
-            0;
+            (int) $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_MESSAGE_MAX_LENGTH) : 0;
         $isDigital = $product->getGiftCardType() === Enterprise_GiftCard_Model_Giftcard::TYPE_VIRTUAL ? 'true' : 'false';
         $namespaceUri = $doc->documentElement->namespaceURI;
         $frag = $doc->createDocumentFragment();
@@ -468,7 +465,7 @@ 
             ->addAttributeToSelect('name');
         foreach ($categories as $category) {
             $pathArr = explode('/', $category->getPath());
-            array_walk($pathArr, function (&$val) use ($all) {
+            array_walk($pathArr, function(&$val) use ($all) {
                 $part = $all->getItemById((int) $val);
                 $val = $part ? $part->getName() : null;
             });
@@ -510,6 +507,6 @@ 
     public function passIsoCountryCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
         return Mage::helper('ebayenterprise_catalog')->isValidIsoCountryCode($attrValue) ?
-            $this->passString($attrValue, $attribute, $product, $doc): null;
+            $this->passString($attrValue, $attribute, $product, $doc) : null;
     }
 }

src/app/code/community/EbayEnterprise/Catalog/Interface/Feed.php

Doc Comments +1 added lines

@@ -20,6 +20,7 @@
 {
     /**
      * The point of entry to start process a feed.
+     * @return integer
      */
     public function processFeeds();
 }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * A common interface that all eb2c classes which process feeds must implement.

src/app/code/community/EbayEnterprise/Catalog/Model/Error/Confirmations.php

Doc Comments +6 added lines

@@ -190,6 +190,8 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addMessage()
+     * @param string $msgTemplate
+     * @param string $message
      */
     public function addMessage($msgTemplate, $message)
     {
@@ -205,6 +207,8 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addError()
+     * @param string $type
+     * @param string $fileName
      */
     public function addError($type, $fileName)
     {
@@ -221,6 +225,7 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addErrorConfirmation()
+     * @param string $sku
      */
     public function addErrorConfirmation($sku)
     {
@@ -389,6 +394,7 @@ 
      * @param  array list of SKUs that were suppose to be imported
      * @param  string the file the sku was found on
      * @param  string the event type
+     * @param string $fileName
      * @return self
      */
     protected function addImportErrors(

Spacing +2 added lines, -3 removed lines

@@ -355,9 +355,8 @@
 
         $this->loadFile($errorFile);
 
-        return ($operationType === 'delete')?
-            $this->addDeleteErrors($collection, $fileName, $type) :
-            $this->addImportErrors($collection, $skus, $fileName, $type);
+        return ($operationType === 'delete') ?
+            $this->addDeleteErrors($collection, $fileName, $type) : $this->addImportErrors($collection, $skus, $fileName, $type);
     }
 
     /**

src/app/code/community/EbayEnterprise/Catalog/Model/Feed/Ack.php

Doc Comments +4 added lines

@@ -76,6 +76,9 @@ 
         return [$logger, $context, $coreHelper];
     }
 
+    /**
+     * @param string $key
+     */
     protected function _nullCoalesce($key, array $arr, $default = null)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -188,6 +191,7 @@ 
      * try removing the source file
      * @param string
      * @param string
+     * @param string $cfgKey
      * @return self
      */
     protected function _mvTo($sourceFile, $cfgKey)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * This class will implement the functionality to confirm that feed files that were exported such as PIM, and Image

Spacing +2 added lines, -2 removed lines

@@ -102,7 +102,7 @@ 
                 self::CFG_ERROR_DIRECTORY => $cfg->feedAckErrorDirectory,
             ];
         }
-        return isset($this->_configMap[$cfgKey])? $this->_configMap[$cfgKey] : null;
+        return isset($this->_configMap[$cfgKey]) ? $this->_configMap[$cfgKey] : null;
     }
 
     /**
@@ -137,7 +137,7 @@ 
     protected function _getImportedAckFiles()
     {
         $imports = $this->_listFilesByCfgKey(self::CFG_IMPORTED_ACK_DIR);
-        return !empty($imports)? array_map([$this, '_extractExportedFile'], $imports): [];
+        return !empty($imports) ? array_map([$this, '_extractExportedFile'], $imports) : [];
     }
 
     /**

src/app/code/community/EbayEnterprise/Catalog/Model/Observers.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +18 added lines, -18 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Model_Observers
 {
@@ -25,12 +25,12 @@ 
         );
     }
 
-     /**
-     * Type hinting for self::__construct $initParams
-     *
-     * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
-     */
+        /**
+         * Type hinting for self::__construct $initParams
+         *
+         * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
+         * @return array
+         */
     protected function checkTypes(EbayEnterprise_Eb2cCore_Model_Config_Registry $config)
     {
         return func_get_args();

src/app/code/community/EbayEnterprise/Catalog/Model/Pim.php

Doc Comments +1 added lines, -5 removed lines

@@ -114,10 +114,7 @@ 
     }
     /**
      * generate the outgoing product feed.
-     * @param  array  $productIds     list of product id's to include in the feed.
-     * @param  array  $feedTypeConfig configuration data for the current feed.
-     * @param  array  $stores         list of stores to use as context for getting values.
-     * @return array  array of full filepath where the feed files was saved.
+     * @return string  array of full filepath where the feed files was saved.
      */
     public function buildFeed()
     {
@@ -215,7 +212,6 @@ 
      *
      * @param  Mage_Catalog_Model_Resource_Product_Collection $products products for a specific store
      * @param  EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
-     * @param  string $key
      * @param array $productIds
      * @return EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 
 class EbayEnterprise_Catalog_Model_Pim

Spacing +4 added lines, -5 removed lines

@@ -250,7 +250,7 @@ 
                 $logMessage = 'Product "{sku}" excluded from export.';
                 $this->_logger->warning($logMessage, $this->_context->getMetaData(__CLASS__, $logData));
                 $this->_logger->logException($e, $this->_context->getMetaData(__CLASS__, [], $e));
-                $excludedProductIds[]= $product->getId();
+                $excludedProductIds[] = $product->getId();
                 $pimProducts->deleteItem($pimProduct);
             }
         }
@@ -270,9 +270,8 @@ 
     protected function _getFeedAttributes($storeId)
     {
         $config = $this->_getFeedConfig();
-        return ((int) $storeId === (int) $this->_getDefaultStoreViewId())?
-            array_keys($config[self::KEY_MAPPINGS]) :
-            $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
+        return ((int) $storeId === (int) $this->_getDefaultStoreViewId()) ?
+            array_keys($config[self::KEY_MAPPINGS]) : $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
     }
     /**
      * get only translatable attributes
@@ -281,7 +280,7 @@ 
      */
     protected function _getTranslatableAttributes(array $mapAttributes)
     {
-        return array_filter(array_map(function ($key) use ($mapAttributes) {
+        return array_filter(array_map(function($key) use ($mapAttributes) {
                 return ($mapAttributes[$key]['translate'] === '1') ? $key : null;
         }, array_keys($mapAttributes)));
     }

src/app/code/community/EbayEnterprise/Catalog/Model/Pim/Attribute/Factory.php

Doc Comments +1 added lines, -3 removed lines

@@ -47,7 +47,6 @@ 
      * @param  string $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  EbayEnterprise_Dom_Document             $doc
-     * @param  array $key
      * @return EbayEnterprise_Catalog_Model_Pim_Attribute
      */
     public function getPimAttribute(
@@ -69,7 +68,6 @@ 
     /**
      * Get the attribute mapping. The result will be an empty array.
      * @param  string $attribute
-     * @param  string $key
      * @return array
      */
     protected function _getAttributeMapping($attribute, $config)
@@ -81,7 +79,7 @@ 
      * Lookup the callable described in the mapping xml to export this attribute for this product.
      *
      * @param array $callbackMapping
-     * @param $attribute
+     * @param string $attribute
      * @param Mage_Catalog_Model_Product $product
      * @param EbayEnterprise_Dom_Document $doc
      * @return array|null

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 
 class EbayEnterprise_Catalog_Model_Pim_Attribute_Factory

Spacing +1 added lines, -2 removed lines

@@ -125,8 +125,7 @@
             'destination_xpath' => $callbackMapping['xml_dest'],
             'sku' => $product->getSku(),
             'language' => $callbackMapping['translate'] ?
-                $product->getPimLanguageCode() :
-                null,
+                $product->getPimLanguageCode() : null,
             'value' => $pimAttributeValue,
         );
     }

src/app/code/community/EbayEnterprise/Catalog/Model/Price/Event.php

Doc Comments +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
 
     /**
      * Get the "special_price" if there is one.
-     * @return float|null
+     * @return double
      */
     public function getSpecialPrice()
     {
@@ -134,7 +134,7 @@ 
      * format string or via a default.
      * @see self::_formatDate
      * @param  string|null $format Date format string to use
-     * @return string|null Formatted datetime
+     * @return string Formatted datetime
      */
     public function getSpecialFromDate($format = null)
     {
@@ -146,7 +146,7 @@ 
      * format string or via a default.
      * @see self::_formatDate
      * @param  string|null $format Date format string to use
-     * @return string|null Formatted datetime
+     * @return string Formatted datetime
      */
     public function getSpecialToDate($format = null)
     {

src/app/code/community/EbayEnterprise/Catalog/Test/Helper/DataTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -862,8 +862,8 @@
     }
     /**
      * Test normalizing a product style id to match formatting for skus
-     * @param  string $style   The product style id
-     * @param  string $catalog The product catalog id
+     * @param  string $styleId   The product style id
+     * @param  string $catalogId The product catalog id
      * @dataProvider dataProvider
      */
     public function testNormalizeSku($styleId, $catalogId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Test_Helper_DataTest extends EbayEnterprise_Eb2cCore_Test_Base
 {

Spacing +4 added lines, -4 removed lines

@@ -243,17 +243,17 @@
      */
     public function testParseTranslations()
     {
-        $sampleInput = array (
-            array (
+        $sampleInput = array(
+            array(
                 'lang' => 'en-US',
                 'description' => 'An en-US translation',
             ),
-            array (
+            array(
                 'lang' => 'ja-JP',
                 'description' => 'ja-JP に変換',
             ),
         );
-        $expectedOutput = array (
+        $expectedOutput = array(
             'en-US' => 'An en-US translation',
             'ja-JP' => 'ja-JP に変換',
         );