eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Amqp/Helper/Config.php

Doc Comments +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
      * same configuration as (or is) the default store, should return 'default'
      * and 0.
      * @param  Mage_Core_Model_Store $store
-     * @return mixed[] Tuple of scope "type" and scope id
+     * @return string[] Tuple of scope "type" and scope id
      */
     public function getScopeForStoreSettings(Mage_Core_Model_Store $store)
     {

src/app/code/community/EbayEnterprise/Amqp/Model/Api/Validator.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Api\Exception\ConnectionError;
 

src/app/code/community/EbayEnterprise/Amqp/Model/Observer.php

Doc Comments +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Type checks for self::__construct $initParams
      * @param  EbayEnterprise_Amqp_Helper_Config $configHelper
-     * @return mixed[]
+     * @return EbayEnterprise_Amqp_Helper_Config[]
      */
     protected function _checkTypes(EbayEnterprise_Amqp_Helper_Config $configHelper)
     {
@@ -41,9 +41,9 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
-     * @return mixed
+     * @return EbayEnterprise_Amqp_Helper_Config
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Amqp_Model_Observer
 {

src/app/code/community/EbayEnterprise/Amqp/Model/Runner.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed $default
      * @return mixed
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Exception;
 use eBayEnterprise\RetailOrderManagement\Payload\OrderEvents\IOrderEvent;

src/app/code/community/EbayEnterprise/Amqp/Test/Model/Adminhtml/System/Config/Backend/LasttestmessageTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Test getting the last saved test message timestamp to be displayed in the
      * admin.
-     * @param string|null $timestamp
+     * @param string|null $lastTimestamp
      * @param string $value
      * @dataProvider provideLastTimestamp
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Amqp_Test_Model_Adminhtml_System_Config_Backend_LasttestmessageTest extends EbayEnterprise_Eb2cCore_Test_Base
 {

src/app/code/community/EbayEnterprise/Catalog/Helper/Data.php

Doc Comments +3 added lines, -1 removed lines

@@ -63,6 +63,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -159,7 +160,7 @@ 
     /**
      * Get the base url for a given store
      *
-     * @param $storeId
+     * @param integer $storeId
      * @return string the store base url
      */
     public function getStoreUrl($storeId)
@@ -717,6 +718,7 @@ 
      *
      * @param string
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function reregister($key, $value=null)

Spacing +5 added lines, -5 removed lines

@@ -370,8 +370,8 @@ 
      */
     public function mapPattern(array $keyMap, $pattern)
     {
-        return array_reduce(array_keys($keyMap), function ($result, $key) use ($keyMap, $pattern) {
-            $result = (trim($result) === '')? $pattern : $result;
+        return array_reduce(array_keys($keyMap), function($result, $key) use ($keyMap, $pattern) {
+            $result = (trim($result) === '') ? $pattern : $result;
             return str_replace(sprintf('{%s}', $key), $keyMap[$key], $result);
         });
     }
@@ -547,7 +547,7 @@ 
     protected function _loadWebsiteFilter($mageStoreId)
     {
         $config = Mage::helper('eb2ccore')->getConfigModel($mageStoreId);
-        return array (
+        return array(
             'catalog_id'      => $config->catalogId,
             'client_id'       => $config->clientId,
             'store_id'        => $config->storeId,
@@ -641,7 +641,7 @@ 
      */
     public function denormalizeSku($itemId, $catalogId)
     {
-        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0)?
+        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0) ?
             str_replace($catalogId . '-', '', $itemId) : $itemId;
     }
 
@@ -719,7 +719,7 @@ 
      * @param mixed
      * @return mixed
      */
-    protected function reregister($key, $value=null)
+    protected function reregister($key, $value = null)
     {
         $old = Mage::registry($key);
         Mage::unregister($key);

src/app/code/community/EbayEnterprise/Catalog/Helper/Itemmaster.php

Doc Comments +11 added lines, -11 removed lines

@@ -89,7 +89,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStyle($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -177,7 +177,7 @@ 
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
      * @throws EbayEnterprise_Catalog_Model_Pim_Product_Validation_Exception
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passTaxCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -195,7 +195,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return null|DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passUnitCost($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -231,7 +231,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passColorCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -247,7 +247,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passColorDescription($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -263,7 +263,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passItemURL($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -300,7 +300,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftCard($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -324,7 +324,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      */
     public function passDropShipSupplierPrefix($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
@@ -337,7 +337,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      */
     public function passSupplierPartNumber($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
@@ -353,7 +353,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSubscriptionEligible($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -370,7 +370,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSubscriptionType($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Helper_Itemmaster extends EbayEnterprise_Catalog_Helper_Pim
 {

Spacing +2 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
      */
     public function passSubClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $value = (int)0;
+        $value = (int) 0;
         if (!empty($attrValue)) {
             $value = $attrValue;
         }
@@ -287,8 +287,7 @@ 
      */
     public function passSalesClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $enum = empty($attrValue) ? 'stock' :
-            Mage::getSingleton('eav/entity_attribute')
+        $enum = empty($attrValue) ? 'stock' : Mage::getSingleton('eav/entity_attribute')
                 ->loadByCode($product::ENTITY, $attribute)
                 ->getSource()->getOptionText($attrValue);
         return $this->passString($enum, $attribute, $product, $doc);

src/app/code/community/EbayEnterprise/Catalog/Helper/Map.php

Doc Comments +1 added lines, -1 removed lines

@@ -346,7 +346,7 @@
     /**
      * it return the pass in value parameter
      * it's a callback to return static value set in the config
-     * @param mixed $value
+     * @param string $value
      * @return mixed
      */
     public function passThrough($value)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /**
  * Functions to help import EB2C attributes into Magento product attributes.

Spacing +11 added lines, -13 removed lines

@@ -99,9 +99,8 @@ 
      */
     public function extractStatusValue(DOMNodeList $nodes)
     {
-        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active')?
-            Mage_Catalog_Model_Product_Status::STATUS_ENABLED:
-            Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
+        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active') ?
+            Mage_Catalog_Model_Product_Status::STATUS_ENABLED : Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
     }
     /**
      * extracts visibility from node list, returning an expected integer or translating an expected string
@@ -142,7 +141,7 @@ 
     public function extractProductTypeValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $value = strtolower($this->coreHelper->extractNodeVal($nodes));
-        $type = ($this->_isValidProductType($value))? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
+        $type = ($this->_isValidProductType($value)) ? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
         $product->setTypeId($type)
             ->setTypeInstance(Mage_Catalog_Model_Product_Type::factory($product, true), true);
         return $type;
@@ -232,9 +231,8 @@ 
     public function extractUrlKeyValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $urlKey = $this->coreHelper->extractNodeVal($nodes);
-        return ($urlKey !== '')?
-            $urlKey . '-' . $product->getStoreId() :
-            'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
+        return ($urlKey !== '') ?
+            $urlKey . '-' . $product->getStoreId() : 'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
     }
     /**
      * given a gift card type return the gift card constant mapped to it
@@ -264,7 +262,7 @@ 
         $value = $this->coreHelper->extractNodeVal($nodes);
         $cfg = Mage::helper('ebayenterprise_catalog')->getConfigModel();
         $mapData = $cfg->getConfigData(EbayEnterprise_Catalog_Helper_Feed::GIFTCARD_TENDER_CONFIG_PATH);
-        return isset($mapData[$value])? $this->_getGiftCardType($mapData[$value]) : null;
+        return isset($mapData[$value]) ? $this->_getGiftCardType($mapData[$value]) : null;
     }
 
     /**
@@ -313,7 +311,7 @@ 
      */
     public function extractStringValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? $nodes->item(0)->nodeValue : null;
+        return ($nodes->length) ? $nodes->item(0)->nodeValue : null;
     }
     /**
      * extract the first element of a dom node list and return a boolean
@@ -323,7 +321,7 @@ 
      */
     public function extractBoolValue(DOMNodeList $nodes)
     {
-        return $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+        return $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
     }
     /**
      * extract the first element of a dom node list and return the string value cast as integer value
@@ -332,7 +330,7 @@ 
      */
     public function extractIntValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (int) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (int) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * extract the first element of a dom node list and return the string value cast as float value
@@ -341,7 +339,7 @@ 
      */
     public function extractFloatValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (float) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (float) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * it return the pass in value parameter
@@ -425,7 +423,7 @@ 
             $product->setUseConfigGiftMessageAvailable(0);
             // Explicitly casting the extracted boolean value as an integer value because
             // Magento only work with integer value 0 or 1 representing boolean value in the database.
-            return (int) $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+            return (int) $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
         }
         return null;
     }

Braces +1 added lines, -2 removed lines

@@ -73,8 +73,7 @@
         EbayEnterprise_Eb2cCore_Helper_Data $coreHelper,
         EbayEnterprise_MageLog_Helper_Data $logger,
         EbayEnterprise_MageLog_Helper_Context $context
-    )
-    {
+    ) {
         return func_get_args();
     }
 

src/app/code/community/EbayEnterprise/Catalog/Helper/Map/Attribute.php

Doc Comments +3 added lines, -1 removed lines

@@ -149,6 +149,8 @@ 
      *
      * @param  string
      * @param  string
+     * @param string $attributeCode
+     * @param string $optionValue
      * @return Mage_Eav_Model_Entity_Attribute_Option | null
      */
     protected function _getAttributeOptionModel($attributeCode, $optionValue)
@@ -395,7 +397,7 @@ 
      * Return empty array if there's no option id
      *
      * @param $attribute
-     * @param $attributeOptionId
+     * @param integer $attributeOptionId
      * @return array
      */
     protected function _getAllOptionValues($attribute, $attributeOptionId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Helper_Map_Attribute extends Mage_Core_Helper_Abstract
 {

Spacing +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
     protected function _getAttributeIdByName($name)
     {
         $attribute = $this->_getAttributeCollection()->getItemByColumnValue('attribute_code', $name);
-        return ($attribute)? $attribute->getId() : null;
+        return ($attribute) ? $attribute->getId() : null;
     }
 
     /**
@@ -140,7 +140,7 @@ 
     {
         /** @var Mage_Eav_Model_Entity_Attribute_Option */
         $option = $this->_getAttributeOptionModel($attributeCode, $optionValue);
-        return (!is_null($option))? (int) $option->getOptionId() : 0;
+        return (!is_null($option)) ? (int) $option->getOptionId() : 0;
     }
 
     /**