eBayEnterprise / RetailOrderManagement-SDK

src/eBayEnterprise/RetailOrderManagement/Api/HttpApi.php

Doc Comments +5 added lines, -2 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function post()
@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function get()
@@ -204,6 +204,9 @@ 
      * @param  string
      * @param  string
      * @param  string
+     * @param string $xmlPayload
+     * @param string $logMessage
+     * @param string $key
      * @return self
      */
     protected function logPayloadMessage($xmlPayload, $logMessage, $key)

Spacing +2 added lines, -2 removed lines

@@ -187,8 +187,8 @@
     protected function getRequestUrlLogData()
     {
         $context = $this->getContext();
-        $logData = ['rom_request_url' => $this->config->getEndpoint()];
-        return $context ? $context->getMetaData(__CLASS__, $logData) : [];
+        $logData = [ 'rom_request_url' => $this->config->getEndpoint() ];
+        return $context ? $context->getMetaData(__CLASS__, $logData) : [ ];
     }
 
     protected function logRequestUrl()

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/TPersonName.php

Doc Comments +1 added lines

@@ -103,6 +103,7 @@
      *
      * @param string
      * @param string
+     * @param string $name
      * @return string
      */
     abstract protected function serializeOptionalXmlEncodedValue($name, $value);

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/TPhysicalAddress.php

Doc Comments +1 added lines

@@ -179,6 +179,7 @@
      * encode the passed in string to be safe for xml if it is not null,
      * otherwise simply return the null parameter.
      * @param  mixed  $value
+     * @param string $name
      * @return string | null
      */
     abstract protected function serializeOptionalXmlEncodedValue($name, $value);

Spacing +6 added lines, -6 removed lines

@@ -91,12 +91,12 @@ 
      */
     protected function serializePhysicalAddress()
     {
-        $lines = [];
+        $lines = [ ];
         $idx = 0;
-        $addressLines = is_array($this->lines) ? $this->lines : [];
+        $addressLines = is_array($this->lines) ? $this->lines : [ ];
         foreach ($addressLines as $line) {
             $idx++;
-            $lines[] = sprintf(
+            $lines[ ] = sprintf(
                 '<Line%d>%s</Line%1$d>',
                 $idx,
                 $this->xmlEncode($line)
@@ -143,14 +143,14 @@ 
             $trimmed = trim($lines);
             $addressLines = preg_split("/\n/", $trimmed, null, PREG_SPLIT_NO_EMPTY);
 
-            $newLines = [];
+            $newLines = [ ];
             foreach ($addressLines as $line) {
-                $newLines[] = $this->cleanString($line, 70);
+                $newLines[ ] = $this->cleanString($line, 70);
             }
 
             if (count($newLines) > 4) {
                 // concat lines beyond the four allowed down into the last line
-                $newLines[3] = $this->cleanString(implode(' ', array_slice($newLines, 3)), 70);
+                $newLines[ 3 ] = $this->cleanString(implode(' ', array_slice($newLines, 3)), 70);
             }
 
             $finalLines = array_slice($newLines, 0, 4);

src/eBayEnterprise/RetailOrderManagement/Payload/Customer/OrderSummary.php

Doc Comments +4 added lines

@@ -432,6 +432,8 @@ 
 
     /**
      * Serialize the chain order node.
+     * @param string $node
+     * @param string|null $value
      * @return string | null
      */
     protected function serializeChainedOrder($node, $value)
@@ -445,6 +447,8 @@ 
 
     /**
      * Serialize the derived order node.
+     * @param string $node
+     * @param string|null $value
      * @return string | null
      */
     protected function serializeDerivedOrder($node, $value)

Spacing +6 added lines, -6 removed lines

@@ -481,12 +481,12 @@
         $testType = $this->getTestType();
         $cancellable = $this->getCancellable();
         return array_merge(
-            ['id' => $this->getId()],
-            $orderType ? ['orderType' => $orderType] : [],
-            $orderPurpose ? ['orderPurpose' => $orderPurpose] : [],
-            $testType ? ['testType' => $testType] : [],
-            ['modifiedTime' => $this->getModifiedTime()->format('c')],
-            $cancellable ? ['cancellable' => $cancellable] : []
+            [ 'id' => $this->getId() ],
+            $orderType ? [ 'orderType' => $orderType ] : [ ],
+            $orderPurpose ? [ 'orderPurpose' => $orderPurpose ] : [ ],
+            $testType ? [ 'testType' => $testType ] : [ ],
+            [ 'modifiedTime' => $this->getModifiedTime()->format('c') ],
+            $cancellable ? [ 'cancellable' => $cancellable ] : [ ]
         );
     }
 }

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/AllocatedItem.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
     /**
      * @see eBayEnterprise\RetailOrderManagement\Payload\TPayload::getXmlNamespace
      * @param string
-     * @return self
+     * @return string
      */
     protected function getXmlNamespace()
     {

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
      */
     protected function getRootAttributes()
     {
-        return ['lineId' => $this->getId(), 'itemId' => $this->getItemId()];
+        return [ 'lineId' => $this->getId(), 'itemId' => $this->getItemId() ];
     }
 
     /**

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/DetailItem.php

Doc Comments +4 added lines

@@ -272,6 +272,10 @@
             . '</DeliveryEstimate>';
     }
 
+    /**
+     * @param string $nodeName
+     * @param DateTime $dateTime
+     */
     protected function serializeDateTime($nodeName, $dateTime)
     {
         return is_null($dateTime) ? "<{$nodeName}/>" :

Spacing +1 added lines, -2 removed lines

@@ -274,8 +274,7 @@
 
     protected function serializeDateTime($nodeName, $dateTime)
     {
-        return is_null($dateTime) ? "<{$nodeName}/>" :
-            "<{$nodeName}>{$dateTime->format('c')}</{$nodeName}>";
+        return is_null($dateTime) ? "<{$nodeName}/>" : "<{$nodeName}>{$dateTime->format('c')}</{$nodeName}>";
     }
 
     protected function deserializeExtra()

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/InventoryDetailsReply.php

Doc Comments +1 added lines

@@ -136,6 +136,7 @@
      * @param  DOMNodeList
      * @param  IItemIterable
      * @param  string
+     * @param string $subPayloadMethod
      * @return self
      */
     protected function deserializeItems(DOMNodeList $itemNodes, IItemIterable $iterable, $subPayloadMethod)

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/ItemIterable.php

Doc Comments +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
     /**
      * Get a new, empty item for shipping.
      *
-     * @return IShippingItemIterable
+     * @return IPayload
      */
     public function getEmptyShippingItem()
     {
@@ -68,7 +68,7 @@ 
     /**
      * Get a new, empty item for in store pick up.
      *
-     * @return IInStorePickUpItemIterable
+     * @return IPayload
      */
     public function getEmptyInStorePickUpItem()
     {
@@ -78,7 +78,7 @@ 
     /**
      * Get a new, empty payload for an unavailable item.
      *
-     * @return IShippingItemIterable
+     * @return IPayload
      */
     public function getEmptyDetailItem()
     {
@@ -88,7 +88,7 @@ 
     /**
      * Get a new, empty payload for an unavailable item.
      *
-     * @return IShippingItemIterable
+     * @return IPayload
      */
     public function getEmptyUnavailableItem()
     {

src/eBayEnterprise/RetailOrderManagement/Payload/OmnidirectionalMessageFactory.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
     protected $logger;
 
     /**
-     * @param IConfig $config
      * @param IPayloadFactory $payloadFactory
      * @param array $messageMapping key/value pairs of config key => payload type
      */

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
      * @param IPayloadFactory $payloadFactory
      * @param array $messageMapping key/value pairs of config key => payload type
      */
-    public function __construct(IPayloadFactory $payloadFactory = null, array $messageMapping = [], LoggerInterface $logger = null)
+    public function __construct(IPayloadFactory $payloadFactory = null, array $messageMapping = [ ], LoggerInterface $logger = null)
     {
         $this->logger = $logger ?: new NullLogger();
         $this->payloadFactory = $payloadFactory ?: new PayloadFactory();
@@ -43,8 +43,8 @@ 
 
     public function messagePayload($type)
     {
-        if (isset($this->messageTypeMap[$type])) {
-            return $this->payloadFactory->buildPayload($this->messageTypeMap[$type], null, null, $this->logger);
+        if (isset($this->messageTypeMap[ $type ])) {
+            return $this->payloadFactory->buildPayload($this->messageTypeMap[ $type ], null, null, $this->logger);
         }
         throw new UnsupportedPayload("No payload found for '$type'");
     }