eBayEnterprise / RetailOrderManagement-SDK

src/eBayEnterprise/RetailOrderManagement/Api/HttpApi.php

Doc Comments +5 added lines, -2 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function post()
@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function get()
@@ -204,6 +204,9 @@ 
      * @param  string
      * @param  string
      * @param  string
+     * @param string $xmlPayload
+     * @param string $logMessage
+     * @param string $key
      * @return self
      */
     protected function logPayloadMessage($xmlPayload, $logMessage, $key)

Spacing +2 added lines, -2 removed lines

@@ -187,8 +187,8 @@
     protected function getRequestUrlLogData()
     {
         $context = $this->getContext();
-        $logData = ['rom_request_url' => $this->config->getEndpoint()];
-        return $context ? $context->getMetaData(__CLASS__, $logData) : [];
+        $logData = [ 'rom_request_url' => $this->config->getEndpoint() ];
+        return $context ? $context->getMetaData(__CLASS__, $logData) : [ ];
     }
 
     protected function logRequestUrl()

src/eBayEnterprise/RetailOrderManagement/Api/TLogger.php

Unused Use Statements -3 removed lines

@@ -15,9 +15,6 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Api;
 
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
-
 /**
  * Common logger utility methods.
  *

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Api;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/InvoiceTextCode.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class InvoiceTextCode implements IInvoiceTextCode
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/InvoiceTextCodeIterable.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TIterablePayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 use SPLObjectStorage;
 
 class InvoiceTextCodeIterable extends SPLObjectStorage implements IInvoiceTextCodeIterable

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/MailingAddress.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class MailingAddress implements IMailingAddress
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/Tax.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Order\Tax as OrderTax;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class Tax extends OrderTax implements ITax
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/TPersonName.php

Doc Comments +1 added lines

@@ -103,6 +103,7 @@
      *
      * @param string
      * @param string
+     * @param string $name
      * @return string
      */
     abstract protected function serializeOptionalXmlEncodedValue($name, $value);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Checkout/TPhysicalAddress.php

Doc Comments +1 added lines

@@ -179,6 +179,7 @@
      * encode the passed in string to be safe for xml if it is not null,
      * otherwise simply return the null parameter.
      * @param  mixed  $value
+     * @param string $name
      * @return string | null
      */
     abstract protected function serializeOptionalXmlEncodedValue($name, $value);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Checkout;
 

Spacing +6 added lines, -6 removed lines

@@ -91,12 +91,12 @@ 
      */
     protected function serializePhysicalAddress()
     {
-        $lines = [];
+        $lines = [ ];
         $idx = 0;
-        $addressLines = is_array($this->lines) ? $this->lines : [];
+        $addressLines = is_array($this->lines) ? $this->lines : [ ];
         foreach ($addressLines as $line) {
             $idx++;
-            $lines[] = sprintf(
+            $lines[ ] = sprintf(
                 '<Line%d>%s</Line%1$d>',
                 $idx,
                 $this->xmlEncode($line)
@@ -143,14 +143,14 @@ 
             $trimmed = trim($lines);
             $addressLines = preg_split("/\n/", $trimmed, null, PREG_SPLIT_NO_EMPTY);
 
-            $newLines = [];
+            $newLines = [ ];
             foreach ($addressLines as $line) {
-                $newLines[] = $this->cleanString($line, 70);
+                $newLines[ ] = $this->cleanString($line, 70);
             }
 
             if (count($newLines) > 4) {
                 // concat lines beyond the four allowed down into the last line
-                $newLines[3] = $this->cleanString(implode(' ', array_slice($newLines, 3)), 70);
+                $newLines[ 3 ] = $this->cleanString(implode(' ', array_slice($newLines, 3)), 70);
             }
 
             $finalLines = array_slice($newLines, 0, 4);

src/eBayEnterprise/RetailOrderManagement/Payload/Customer/OrderSearch.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class OrderSearch implements IOrderSearch
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Customer;