eBayEnterprise / RetailOrderManagement-SDK

src/eBayEnterprise/RetailOrderManagement/Api/HttpApi.php

Doc Comments +5 added lines, -2 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function post()
@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @return \Requests_Response
+     * @return boolean
      * @throws \Requests_Exception
      */
     protected function get()
@@ -204,6 +204,9 @@ 
      * @param  string
      * @param  string
      * @param  string
+     * @param string $xmlPayload
+     * @param string $logMessage
+     * @param string $key
      * @return self
      */
     protected function logPayloadMessage($xmlPayload, $logMessage, $key)

Spacing +2 added lines, -2 removed lines

@@ -187,8 +187,8 @@
     protected function getRequestUrlLogData()
     {
         $context = $this->getContext();
-        $logData = ['rom_request_url' => $this->config->getEndpoint()];
-        return $context ? $context->getMetaData(__CLASS__, $logData) : [];
+        $logData = [ 'rom_request_url' => $this->config->getEndpoint() ];
+        return $context ? $context->getMetaData(__CLASS__, $logData) : [ ];
     }
 
     protected function logRequestUrl()

src/eBayEnterprise/RetailOrderManagement/Api/TLogger.php

Unused Use Statements -3 removed lines

@@ -15,9 +15,6 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Api;
 
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
-
 /**
  * Common logger utility methods.
  *

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Customer/OrderSummary.php

Doc Comments +4 added lines

@@ -432,6 +432,8 @@ 
 
     /**
      * Serialize the chain order node.
+     * @param string $node
+     * @param string|null $value
      * @return string | null
      */
     protected function serializeChainedOrder($node, $value)
@@ -445,6 +447,8 @@ 
 
     /**
      * Serialize the derived order node.
+     * @param string $node
+     * @param string|null $value
      * @return string | null
      */
     protected function serializeDerivedOrder($node, $value)

Indentation +25 added lines, -25 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Customer;
 
@@ -162,7 +162,7 @@ 
         return $this;
     }
 
-   /**
+    /**
      * @see IOrderSummary::getTestType()
      */
     public function getTestType()
@@ -170,7 +170,7 @@ 
         return $this->testType;
     }
 
-   /**
+    /**
      * @see IOrderSummary::setTestType()
      * @codeCoverageIgnore
      */
@@ -180,7 +180,7 @@ 
         return $this;
     }
 
-   /**
+    /**
      * @see IOrderSummary::getModifiedTime()
      */
     public function getModifiedTime()
@@ -188,7 +188,7 @@ 
         return $this->modifiedTime;
     }
 
-   /**
+    /**
      * @see IOrderSummary::setModifiedTime()
      * @codeCoverageIgnore
      */
@@ -224,17 +224,17 @@ 
         return $this->customerId;
     }
 
-     /**
-     * @see IOrderSummary::setCustomerId()
-     * @codeCoverageIgnore
-     */
+        /**
+         * @see IOrderSummary::setCustomerId()
+         * @codeCoverageIgnore
+         */
     public function setCustomerId($customerId)
     {
         $this->customerId = $customerId;
         return $this;
     }
 
-   /**
+    /**
      * @see IOrderSummary::getCustomerOrderId()
      */
     public function getCustomerOrderId()
@@ -296,7 +296,7 @@ 
         return $this->status;
     }
 
-   /**
+    /**
      * @see IOrderSummary::setStatus()
      * @codeCoverageIgnore
      */
@@ -314,7 +314,7 @@ 
         return $this->orderTotal;
     }
 
-   /**
+    /**
      * @see IOrderSummary::setOrderTotal()
      * @codeCoverageIgnore
      */
@@ -332,7 +332,7 @@ 
         return $this->source;
     }
 
-   /**
+    /**
      * @see IOrderSummary::setSource()
      * @codeCoverageIgnore
      */
@@ -360,7 +360,7 @@ 
         return $this;
     }
 
-   /**
+    /**
      * @see IOrderSummary::getType()
      */
     public function getType()

Spacing +6 added lines, -6 removed lines

@@ -481,12 +481,12 @@
         $testType = $this->getTestType();
         $cancellable = $this->getCancellable();
         return array_merge(
-            ['id' => $this->getId()],
-            $orderType ? ['orderType' => $orderType] : [],
-            $orderPurpose ? ['orderPurpose' => $orderPurpose] : [],
-            $testType ? ['testType' => $testType] : [],
-            ['modifiedTime' => $this->getModifiedTime()->format('c')],
-            $cancellable ? ['cancellable' => $cancellable] : []
+            [ 'id' => $this->getId() ],
+            $orderType ? [ 'orderType' => $orderType ] : [ ],
+            $orderPurpose ? [ 'orderPurpose' => $orderPurpose ] : [ ],
+            $testType ? [ 'testType' => $testType ] : [ ],
+            [ 'modifiedTime' => $this->getModifiedTime()->format('c') ],
+            $cancellable ? [ 'cancellable' => $cancellable ] : [ ]
         );
     }
 }

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedPriceGroup implements ITaxedPriceGroup
 {

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/AllocatedItem.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
     /**
      * @see eBayEnterprise\RetailOrderManagement\Payload\TPayload::getXmlNamespace
      * @param string
-     * @return self
+     * @return string
      */
     protected function getXmlNamespace()
     {

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
      */
     protected function getRootAttributes()
     {
-        return ['lineId' => $this->getId(), 'itemId' => $this->getItemId()];
+        return [ 'lineId' => $this->getId(), 'itemId' => $this->getItemId() ];
     }
 
     /**

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TTopLevelPayload;
 use Psr\Log\LoggerInterface;
 

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/AllocatedItemIterable.php

Unused Use Statements -2 removed lines

@@ -15,13 +15,11 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Inventory;
 
-use eBayEnterprise\RetailOrderManagement\Payload\IIterablePayload;
 use eBayEnterprise\RetailOrderManagement\Payload\TIterablePayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use Psr\Log\LoggerInterface;
 
 /**

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/AllocationRollbackRequest.php

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TTopLevelPayload;
 use Psr\Log\LoggerInterface;
 

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/DetailItem.php

Doc Comments +4 added lines

@@ -272,6 +272,10 @@
             . '</DeliveryEstimate>';
     }
 
+    /**
+     * @param string $nodeName
+     * @param DateTime $dateTime
+     */
     protected function serializeDateTime($nodeName, $dateTime)
     {
         return is_null($dateTime) ? "<{$nodeName}/>" :

Spacing +1 added lines, -2 removed lines

@@ -274,8 +274,7 @@
 
     protected function serializeDateTime($nodeName, $dateTime)
     {
-        return is_null($dateTime) ? "<{$nodeName}/>" :
-            "<{$nodeName}>{$dateTime->format('c')}</{$nodeName}>";
+        return is_null($dateTime) ? "<{$nodeName}/>" : "<{$nodeName}>{$dateTime->format('c')}</{$nodeName}>";
     }
 
     protected function deserializeExtra()

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/InStorePickUpItem.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\TIdentity;
 use eBayEnterprise\RetailOrderManagement\Payload\Checkout\TPhysicalAddress;
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use Psr\Log\LoggerInterface;

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Inventory/InventoryDetailsReply.php

Doc Comments +1 added lines

@@ -136,6 +136,7 @@
      * @param  DOMNodeList
      * @param  IItemIterable
      * @param  string
+     * @param string $subPayloadMethod
      * @return self
      */
     protected function deserializeItems(DOMNodeList $itemNodes, IItemIterable $iterable, $subPayloadMethod)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;