dzikismigol / barenote-cli

src/Command/Menu/Menu.php

<?php
namespace BarenoteCli\Command\Menu;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Exception\CommandNotFoundException;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;

abstract class Menu extends Command
{
    protected function configure()
    {
        $this
            ->setName("barenote:{$this->getSlug()}:menu")

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

            ->setDescription("Menu for {$this->getSlug()} endpoint")

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

            ->setHelp('Some basic menu help');
    }
    
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /** @var QuestionHelper $helper $helper */
        $helper = $this->getHelper('question');
        $question = new ChoiceQuestion(
            $this->getQuestion(),
            $this->getChoiceNames(),
            0
        );
        $question->setErrorMessage('Action %s is invalid.');
        
        while (true) {
            $choice = $helper->ask($input, $output, $question);
            $command = $this->getCommandForChoice($choice);
            if ($command === null) {
                return 0;
            } else {
                $command = $this->getApplication()->find($command);
                
                $command->run(new ArrayInput([]), $output);
            }
        }
        
        return 0;
    }
    
    /**
     * @return string
     */
    protected abstract function getSlug();

The abstract declaration must precede the visibility declaration

    
    /**
     * @return string
     */
    protected abstract function getQuestion();

The abstract declaration must precede the visibility declaration

    
    /**
     * @return Choice[]
     */
    protected abstract function getChoices();

The abstract declaration must precede the visibility declaration

    
    /**
     * @return string[]
     */
    private function getChoiceNames()
    {
        $names = [];
        foreach ($this->getChoices() as $choice) {
            $names[] = $choice->getOption();
        }
        return $names;
    }
    
    private function getCommandForChoice(string $option)
    {
        foreach ($this->getChoices() as $choice) {
            if ($choice->getOption() === $option) {
                return $choice->getCommand();
            }
        }
        throw new CommandNotFoundException("Command for $option not found");

As per coding-style, please use concatenation or sprintf for the variable $option instead of interpolation.

    }
}