Menu::getChoiceNames() - Code Metrics - Inspection of "basic menu and login behaviour" - dzikismigol/barenote-cli - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 6fca32...0b1cfb )

by Michał

created 2017-02-05 15:29 UTC

Menu::getChoiceNames() A

↳ Parent: Menu

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php
namespace BarenoteCli\Command\Menu;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Exception\CommandNotFoundException;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;

abstract class Menu extends Command
{
    protected function configure()
    {
        $this
            ->setName("barenote:{$this->getSlug()}:menu")
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            ->setDescription("Menu for {$this->getSlug()} endpoint")
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            ->setHelp('Some basic menu help');
    }
    
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /** @var QuestionHelper $helper $helper */
        $helper = $this->getHelper('question');
        $question = new ChoiceQuestion(
            $this->getQuestion(),
            $this->getChoiceNames(),
            0
        );
        $question->setErrorMessage('Action %s is invalid.');
        
        while (true) {
            $choice = $helper->ask($input, $output, $question);
            $command = $this->getCommandForChoice($choice);
            if ($command === null) {
                return 0;
            } else {
                $command = $this->getApplication()->find($command);
                
                $command->run(new ArrayInput([]), $output);
            }
        }
        
        return 0;
    }
    
    /**
     * @return string
     */
    protected abstract function getSlug();

    
    /**
     * @return string
     */
    protected abstract function getQuestion();

    
    /**
     * @return Choice[]
     */
    protected abstract function getChoices();

    
    /**
     * @return string[]
     */
    private function getChoiceNames()
    {
        $names = [];
        foreach ($this->getChoices() as $choice) {
            $names[] = $choice->getOption();
        }
        return $names;
    }
    
    private function getCommandForChoice(string $option)
    {
        foreach ($this->getChoices() as $choice) {
            if ($choice->getOption() === $option) {
                return $choice->getCommand();
            }
        }
        throw new CommandNotFoundException("Command for $option not found");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }
}

1			<?php
2			namespace BarenoteCli\Command\Menu;
3
4			use Symfony\Component\Console\Command\Command;
5			use Symfony\Component\Console\Exception\CommandNotFoundException;
6			use Symfony\Component\Console\Helper\QuestionHelper;
7			use Symfony\Component\Console\Input\ArrayInput;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Output\OutputInterface;
10			use Symfony\Component\Console\Question\ChoiceQuestion;
11
12			abstract class Menu extends Command
13			{
14			protected function configure()
15			{
16			$this
17			->setName("barenote:{$this->getSlug()}:menu")
			1 ignored issue – show Coding Style Best Practice introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
18			->setDescription("Menu for {$this->getSlug()} endpoint")
			1 ignored issue – show Coding Style Best Practice introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
19			->setHelp('Some basic menu help');
20			}
21
22			protected function execute(InputInterface $input, OutputInterface $output)
23			{
24			/** @var QuestionHelper $helper $helper */
25			$helper = $this->getHelper('question');
26			$question = new ChoiceQuestion(
27			$this->getQuestion(),
28			$this->getChoiceNames(),
29			0
30			);
31			$question->setErrorMessage('Action %s is invalid.');
32
33			while (true) {
34			$choice = $helper->ask($input, $output, $question);
35			$command = $this->getCommandForChoice($choice);
36			if ($command === null) {
37			return 0;
38			} else {
39			$command = $this->getApplication()->find($command);
40
41			$command->run(new ArrayInput([]), $output);
42			}
43			}
44
45			return 0;
46			}
47
48			/**
49			* @return string
50			*/
51			protected abstract function getSlug();
			1 ignored issue – show Coding Style introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report The abstract declaration must precede the visibility declaration Loading history...
52
53			/**
54			* @return string
55			*/
56			protected abstract function getQuestion();
			1 ignored issue – show Coding Style introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report The abstract declaration must precede the visibility declaration Loading history...
57
58			/**
59			* @return Choice[]
60			*/
61			protected abstract function getChoices();
			1 ignored issue – show Coding Style introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report The abstract declaration must precede the visibility declaration Loading history...
62
63			/**
64			* @return string[]
65			*/
66			private function getChoiceNames()
67			{
68			$names = [];
69			foreach ($this->getChoices() as $choice) {
70			$names[] = $choice->getOption();
71			}
72			return $names;
73			}
74
75			private function getCommandForChoice(string $option)
76			{
77			foreach ($this->getChoices() as $choice) {
78			if ($choice->getOption() === $option) {
79			return $choice->getCommand();
80			}
81			}
82			throw new CommandNotFoundException("Command for $option not found");
			1 ignored issue – show Coding Style Best Practice introduced 2017-02-05 15:31 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$option` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
83			}
84			}

dzikismigol / barenote-cli

Push — master ( 6fca32...0b1cfb )

Menu::getChoiceNames() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like