Dynamic\Salsify\TypeHandler\Relation\HasOneHandler::handleHasOneType()

Complexity

Conditions	7
Paths	7

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handleHasOneType($class, $data, $dataField, $config, $dbField)

The parameter $dataField is not used and could be removed.

    {
        if (!array_key_exists('relation', $config) || !is_array($config['relation'])) {
            return preg_match('/ID$/', $dbField) ? 0 : null;
        }

        $relationConfig = $config['relation'];
        $relatedClass = array_key_first($relationConfig);

        foreach ($this->owner->yieldKeyVal($relationConfig[$relatedClass]) as $dbField => $salsifyField) {

The method yieldKeyVal() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

$dbField is overwriting one of the parameters of this function.

            if ($this->owner->handleShouldSkip($class, $dbField, $salsifyField, $data)) {

The method handleShouldSkip() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

                return false;

The expression return false returns the type false which is incompatible with the documented return type SilverStripe\ORM\DataObject|integer.

            }
        }

        $object = $this->owner->mapToObject($relatedClass, $relationConfig[$relatedClass], $data);

The method mapToObject() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

        return preg_match('/ID$/', $dbField) ? $object->ID : $object;
    }