Dynamic\Salsify\TypeHandler\Relation\HasOneHandler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	handleHasOneType()	0	17	7

<?php

namespace Dynamic\Salsify\TypeHandler\Relation;

use SilverStripe\Core\Extension;
use SilverStripe\ORM\DataObject;

/**
 * Class HasOneRelationHandler
 *
 * @property-read \Dynamic\Salsify\Model\Mapper|HasOneHandler $owner
 */
class HasOneHandler extends Extension
{
    /**
     * @var array
     */
    private static $field_types = [

The private property $field_types is not used, and could be removed.

        'HasOne',
    ];

    /**
     * @param string|DataObject $class
     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     *
     * @return int|DataObject
     * @throws \Exception
     */
    public function handleHasOneType($class, $data, $dataField, $config, $dbField)

The parameter $dataField is not used and could be removed.

    {
        if (!array_key_exists('relation', $config) || !is_array($config['relation'])) {
            return preg_match('/ID$/', $dbField) ? 0 : null;
        }

        $relationConfig = $config['relation'];
        $relatedClass = array_key_first($relationConfig);

        foreach ($this->owner->yieldKeyVal($relationConfig[$relatedClass]) as $dbField => $salsifyField) {

The method yieldKeyVal() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

$dbField is overwriting one of the parameters of this function.

            if ($this->owner->handleShouldSkip($class, $dbField, $salsifyField, $data)) {

The method handleShouldSkip() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

                return false;

The expression return false returns the type false which is incompatible with the documented return type SilverStripe\ORM\DataObject|integer.

            }
        }

        $object = $this->owner->mapToObject($relatedClass, $relationConfig[$relatedClass], $data);

The method mapToObject() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

        return preg_match('/ID$/', $dbField) ? $object->ID : $object;
    }
}