Dynamic\Wishlist\Extensions\ProductControllerExtension::WishListForm()

Complexity

Conditions	6
Paths	7

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function WishListForm($productID = 0)
    {
        if (!Security::getCurrentUser()) {
            return false;
        }

        if (!$productID) {
            $productID = $this->owner->ID;
        } else if ($productID instanceof HTTPRequest) {
            $productID = $productID->postVar('ProductID');
        }

        /** @var ProductWishList $list */
        $list = ProductWishList::get()->filter([
            'MemberID' => Security::getCurrentUser()->ID,
        ])->first();

        if (!$list || !$list->Products()->byID($productID)) {

$list is of type Dynamic\Wishlist\Model\ProductWishList, thus it always evaluated to true.

The method Products() does not exist on Dynamic\Wishlist\Model\ProductWishList. Since you implemented __call, consider adding a @method annotation.

            return AddToWishListForm::create($this->owner, __FUNCTION__, $productID);
        }

        return RemoveFromWishListForm::create($this->owner, __FUNCTION__, $productID);
    }