Dynamic\Wishlist\Extensions\ProductControllerExtension

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	WishListForm()	0	22	6

<?php

namespace Dynamic\Wishlist\Extensions;

use Dynamic\Wishlist\Form\AddToWishListForm;
use Dynamic\Wishlist\Form\RemoveFromWishListForm;
use Dynamic\Wishlist\Model\ProductWishList;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Extension;
use SilverStripe\Security\Security;

/**
 * Class ProductExtension
 * @package Dynamic\Wishlist\Extensions
 *
 * @property-read \SilverStripe\Control\Controller $owner
 */
class ProductControllerExtension extends Extension
{
    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'WishListForm',
    ];

    /**
     * @param int|HTTPRequest $productID
     * @return \Dynamic\Wishlist\Form\AddToWishListForm|\Dynamic\Wishlist\Form\RemoveFromWishListForm|bool
     */
    public function WishListForm($productID = 0)
    {
        if (!Security::getCurrentUser()) {
            return false;
        }

        if (!$productID) {
            $productID = $this->owner->ID;
        } else if ($productID instanceof HTTPRequest) {
            $productID = $productID->postVar('ProductID');
        }

        /** @var ProductWishList $list */
        $list = ProductWishList::get()->filter([
            'MemberID' => Security::getCurrentUser()->ID,
        ])->first();

        if (!$list || !$list->Products()->byID($productID)) {

$list is of type Dynamic\Wishlist\Model\ProductWishList, thus it always evaluated to true.

The method Products() does not exist on Dynamic\Wishlist\Model\ProductWishList. Since you implemented __call, consider adding a @method annotation.

            return AddToWishListForm::create($this->owner, __FUNCTION__, $productID);
        }

        return RemoveFromWishListForm::create($this->owner, __FUNCTION__, $productID);
    }
}