Completed
Push — 1.0 ( fd78e0...1a03ed )
by Jason
15:56 queued 11:43
created
code/pages/CatalogCategory.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
         return $this->product;
78 78
     }
79 79
     /**
80
-     * @param null $request
80
+     * @param null|SS_HTTPRequest $request
81 81
      * @return DataObject|void
82 82
      * @throws SS_HTTPResponse_Exception
83 83
      */
@@ -96,6 +96,7 @@  discard block
 block discarded – undo
96 96
     }
97 97
     /**
98 98
      * @param $event
99
+     * @param DataObject|null $product
99 100
      * @return $this
100 101
      */
101 102
     public function setProduct($product)
Please login to merge, or discard this patch.
code/dataobjects/CatalogProduct.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
             $i = 0;
116 116
             foreach ($this->Categories()->sort('SortOrder') as $category) {
117 117
                 $list .= $category->Title;
118
-                if(++$i !== $this->Categories()->Count()) {
118
+                if (++$i !== $this->Categories()->Count()) {
119 119
                     $list .= ", ";
120 120
                 }
121 121
             }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@
 block discarded – undo
259 259
     /**
260 260
      * set ParentPage for ViewableDataobject
261 261
      *
262
-     * @return string
262
+     * @return CatalogCategory
263 263
      */
264 264
     public function getParentPage()
265 265
     {
Please login to merge, or discard this patch.
code/extensions/ProductDocCollectionDataExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
             $products = $category->Products();
41 41
             $docs = new ArrayList();
42 42
 
43
-            foreach($products as $product) {
43
+            foreach ($products as $product) {
44 44
                 $records = $class::get()->filter(['Products.ID' => $product->ID]);
45 45
                 foreach ($records as $record) {
46 46
                     $docs->push($record);
Please login to merge, or discard this patch.
code/docs/ProductDocDataExtension.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@
 block discarded – undo
47 47
 
48 48
         if ($this->owner->Products()->exists()) {
49 49
             $i = 0;
50
-            foreach($this->owner->Products() as $product) {
50
+            foreach ($this->owner->Products() as $product) {
51 51
                 $list .= $product->Title;
52
-                if(++$i !== $this->owner->Products()->Count()) {
52
+                if (++$i !== $this->owner->Products()->Count()) {
53 53
                     $list .= ", ";
54 54
                 }
55 55
             }
Please login to merge, or discard this patch.