dynamic / silverstripe-product-catalog

code/dataobjects/CatalogProduct.php

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
             $i = 0;
             foreach ($this->Categories()->sort('SortOrder') as $category) {
                 $list .= $category->Title;
-                if(++$i !== $this->Categories()->Count()) {
+                if (++$i !== $this->Categories()->Count()) {
                     $list .= ", ";
                 }
             }

Doc Comments +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
     /**
      * set ParentPage for ViewableDataobject
      *
-     * @return string
+     * @return CatalogCategory
      */
     public function getParentPage()
     {

code/extensions/ProductDocCollectionDataExtension.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
             $products = $category->Products();
             $docs = new ArrayList();
 
-            foreach($products as $product) {
+            foreach ($products as $product) {
                 $records = $class::get()->filter(['Products.ID' => $product->ID]);
                 foreach ($records as $record) {
                     $docs->push($record);

code/docs/ProductDocDataExtension.php

Spacing +2 added lines, -2 removed lines

@@ -47,9 +47,9 @@
 
         if ($this->owner->Products()->exists()) {
             $i = 0;
-            foreach($this->owner->Products() as $product) {
+            foreach ($this->owner->Products() as $product) {
                 $list .= $product->Title;
-                if(++$i !== $this->owner->Products()->Count()) {
+                if (++$i !== $this->owner->Products()->Count()) {
                     $list .= ", ";
                 }
             }

code/pages/CatalogCategory.php

Doc Comments +2 added lines, -1 removed lines

@@ -112,7 +112,7 @@ 
     }
 
     /**
-     * @param null $request
+     * @param null|SS_HTTPRequest $request
      *
      * @return DataObject|void
      * @throws SS_HTTPResponse_Exception
@@ -135,6 +135,7 @@ 
 
     /**
      * @param $event
+     * @param DataObject|null $product
      *
      * @return $this
      */

tests/CatalogProductTest.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     public function testCategoryList()
     {
         $object = $this->objFromFixture('CatalogProduct', 'one');
-        $expected = $this->objFromFixture('CatalogCategory', 'default')->Title . ", " . $this->objFromFixture('CatalogCategory', 'two');
+        $expected = $this->objFromFixture('CatalogCategory', 'default')->Title.", ".$this->objFromFixture('CatalogCategory', 'two');
         $this->assertEquals($expected, $object->CategoryList());
     }