Inspection of "SilverStripe 4 upgrade" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Jason

created 2017-07-13 00:42 UTC

Status

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -171,7 +171,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
     /**
      * set ParentPage for ViewableDataobject
      *
-     * @return string
+     * @return CatalogCategory
      */
     public function getParentPage()
     {
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canEdit($member = null, $context = [])
     {
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canDelete($member = null, $context = [])
     {
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {

Please login to merge, or discard this patch.

code/docs/CareCleaningDoc.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canEdit($member = null, $context = [])
     {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canDelete($member = null, $context = [])
     {

Please login to merge, or discard this patch.

code/docs/OperationManual.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
     private static $table_name = 'OperationManual';
 
     /**
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canEdit($member = null, $context = [])
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canDelete($member = null, $context = [])
     {

Please login to merge, or discard this patch.

code/docs/SpecSheet.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
     private static $table_name = 'SpecSheet';
 
     /**
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canEdit($member = null, $context = [])
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canDelete($member = null, $context = [])
     {

Please login to merge, or discard this patch.

code/docs/Warranty.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
     private static $table_name = 'Warranty';
 
     /**
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canEdit($member = null, $context = [])
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     /**
      * @param null $member
      *
-     * @return bool|int
+     * @return boolean|string
      */
     public function canDelete($member = null, $context = [])
     {

Please login to merge, or discard this patch.

		@@ -171,7 +171,7 @@ discard block
		block discarded – undo
171	171	}
172	172
173	173	/**
174		- * @return FieldList
	174	+ * @return \SilverStripe\Forms\FieldList
175	175	*/
176	176	public function getCMSFields()
177	177	{
		@@ -276,7 +276,7 @@ discard block
		block discarded – undo
276	276	/**
277	277	* set ParentPage for ViewableDataobject
278	278	*
279		- * @return string
	279	+ * @return CatalogCategory
280	280	*/
281	281	public function getParentPage()
282	282	{
		@@ -316,7 +316,7 @@ discard block
		block discarded – undo
316	316	/**
317	317	* @param null $member
318	318	*
319		- * @return bool\|int
	319	+ * @return boolean\|string
320	320	*/
321	321	public function canEdit($member = null, $context = [])
322	322	{
		@@ -326,7 +326,7 @@ discard block
		block discarded – undo
326	326	/**
327	327	* @param null $member
328	328	*
329		- * @return bool\|int
	329	+ * @return boolean\|string
330	330	*/
331	331	public function canDelete($member = null, $context = [])
332	332	{
		@@ -336,7 +336,7 @@ discard block
		block discarded – undo
336	336	/**
337	337	* @param null $member
338	338	*
339		- * @return bool\|int
	339	+ * @return boolean\|string
340	340	*/
341	341	public function canCreate($member = null, $context = [])
342	342	{

		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	/**
46	46	* @param null $member
47	47	*
48		- * @return bool\|int
	48	+ * @return boolean\|string
49	49	*/
50	50	public function canCreate($member = null, $context = [])
51	51	{
		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	/**
56	56	* @param null $member
57	57	*
58		- * @return bool\|int
	58	+ * @return boolean\|string
59	59	*/
60	60	public function canEdit($member = null, $context = [])
61	61	{
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	/**
66	66	* @param null $member
67	67	*
68		- * @return bool\|int
	68	+ * @return boolean\|string
69	69	*/
70	70	public function canDelete($member = null, $context = [])
71	71	{

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	private static $table_name = 'OperationManual';
24	24
25	25	/**
26		- * @return FieldList
	26	+ * @return \SilverStripe\Forms\FieldList
27	27	*/
28	28	public function getCMSFields()
29	29	{
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	/**
50	50	* @param null $member
51	51	*
52		- * @return bool\|int
	52	+ * @return boolean\|string
53	53	*/
54	54	public function canCreate($member = null, $context = [])
55	55	{
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	/**
60	60	* @param null $member
61	61	*
62		- * @return bool\|int
	62	+ * @return boolean\|string
63	63	*/
64	64	public function canEdit($member = null, $context = [])
65	65	{
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	/**
70	70	* @param null $member
71	71	*
72		- * @return bool\|int
	72	+ * @return boolean\|string
73	73	*/
74	74	public function canDelete($member = null, $context = [])
75	75	{

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	private static $table_name = 'SpecSheet';
24	24
25	25	/**
26		- * @return FieldList
	26	+ * @return \SilverStripe\Forms\FieldList
27	27	*/
28	28	public function getCMSFields()
29	29	{
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	/**
50	50	* @param null $member
51	51	*
52		- * @return bool\|int
	52	+ * @return boolean\|string
53	53	*/
54	54	public function canCreate($member = null, $context = [])
55	55	{
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	/**
60	60	* @param null $member
61	61	*
62		- * @return bool\|int
	62	+ * @return boolean\|string
63	63	*/
64	64	public function canEdit($member = null, $context = [])
65	65	{
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	/**
70	70	* @param null $member
71	71	*
72		- * @return bool\|int
	72	+ * @return boolean\|string
73	73	*/
74	74	public function canDelete($member = null, $context = [])
75	75	{

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	private static $table_name = 'Warranty';
24	24
25	25	/**
26		- * @return FieldList
	26	+ * @return \SilverStripe\Forms\FieldList
27	27	*/
28	28	public function getCMSFields()
29	29	{
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	/**
50	50	* @param null $member
51	51	*
52		- * @return bool\|int
	52	+ * @return boolean\|string
53	53	*/
54	54	public function canCreate($member = null, $context = [])
55	55	{
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	/**
60	60	* @param null $member
61	61	*
62		- * @return bool\|int
	62	+ * @return boolean\|string
63	63	*/
64	64	public function canEdit($member = null, $context = [])
65	65	{
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	/**
70	70	* @param null $member
71	71	*
72		- * @return bool\|int
	72	+ * @return boolean\|string
73	73	*/
74	74	public function canDelete($member = null, $context = [])
75	75	{

dynamic / silverstripe-product-catalog

Pull Request — master (#24)

Status

Category

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch