Completed
Pull Request — 1.0 (#27)
by Nic
11:46 queued 01:10
created
code/extensions/ProductDocCollectionDataExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
             $products = $category->Products();
41 41
             $docs = new ArrayList();
42 42
 
43
-            foreach($products as $product) {
43
+            foreach ($products as $product) {
44 44
                 $records = $class::get()->filter(['Products.ID' => $product->ID]);
45 45
                 foreach ($records as $record) {
46 46
                     $docs->push($record);
Please login to merge, or discard this patch.
code/docs/ProductDocDataExtension.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@
 block discarded – undo
47 47
 
48 48
         if ($this->owner->Products()->exists()) {
49 49
             $i = 0;
50
-            foreach($this->owner->Products() as $product) {
50
+            foreach ($this->owner->Products() as $product) {
51 51
                 $list .= $product->Title;
52
-                if(++$i !== $this->owner->Products()->Count()) {
52
+                if (++$i !== $this->owner->Products()->Count()) {
53 53
                     $list .= ", ";
54 54
                 }
55 55
             }
Please login to merge, or discard this patch.
code/dataobjects/CatalogProduct.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@
 block discarded – undo
259 259
     /**
260 260
      * set ParentPage for ViewableDataobject
261 261
      *
262
-     * @return string
262
+     * @return CatalogCategory
263 263
      */
264 264
     public function getParentPage()
265 265
     {
Please login to merge, or discard this patch.
code/pages/CatalogCategory.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     }
113 113
 
114 114
     /**
115
-     * @param null $request
115
+     * @param null|SS_HTTPRequest $request
116 116
      *
117 117
      * @return DataObject|void
118 118
      * @throws SS_HTTPResponse_Exception
@@ -135,6 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
     /**
137 137
      * @param $event
138
+     * @param DataObject|null $product
138 139
      *
139 140
      * @return $this
140 141
      */
Please login to merge, or discard this patch.