Completed
Pull Request — master (#24)
by Jason
13:57
created
code/dataobjects/CatalogProduct.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
             $i = 0;
116 116
             foreach ($this->Categories()->sort('SortOrder') as $category) {
117 117
                 $list .= $category->Title;
118
-                if(++$i !== $this->Categories()->Count()) {
118
+                if (++$i !== $this->Categories()->Count()) {
119 119
                     $list .= ", ";
120 120
                 }
121 121
             }
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 
173 173
     /**
174
-     * @return FieldList
174
+     * @return \SilverStripe\Forms\FieldList
175 175
      */
176 176
     public function getCMSFields()
177 177
     {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     /**
277 277
      * set ParentPage for ViewableDataobject
278 278
      *
279
-     * @return string
279
+     * @return CatalogCategory
280 280
      */
281 281
     public function getParentPage()
282 282
     {
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
     /**
317 317
      * @param null $member
318 318
      *
319
-     * @return bool|int
319
+     * @return boolean|string
320 320
      */
321 321
     public function canEdit($member = null, $context = [])
322 322
     {
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
     /**
327 327
      * @param null $member
328 328
      *
329
-     * @return bool|int
329
+     * @return boolean|string
330 330
      */
331 331
     public function canDelete($member = null, $context = [])
332 332
     {
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
     /**
337 337
      * @param null $member
338 338
      *
339
-     * @return bool|int
339
+     * @return boolean|string
340 340
      */
341 341
     public function canCreate($member = null, $context = [])
342 342
     {
Please login to merge, or discard this patch.
code/extensions/ProductDocCollectionDataExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
             $products = $category->Products();
41 41
             $docs = new ArrayList();
42 42
 
43
-            foreach($products as $product) {
43
+            foreach ($products as $product) {
44 44
                 $records = $class::get()->filter(['Products.ID' => $product->ID]);
45 45
                 foreach ($records as $record) {
46 46
                     $docs->push($record);
Please login to merge, or discard this patch.
code/docs/ProductDocDataExtension.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@
 block discarded – undo
47 47
 
48 48
         if ($this->owner->Products()->exists()) {
49 49
             $i = 0;
50
-            foreach($this->owner->Products() as $product) {
50
+            foreach ($this->owner->Products() as $product) {
51 51
                 $list .= $product->Title;
52
-                if(++$i !== $this->owner->Products()->Count()) {
52
+                if (++$i !== $this->owner->Products()->Count()) {
53 53
                     $list .= ", ";
54 54
                 }
55 55
             }
Please login to merge, or discard this patch.
code/docs/CareCleaningDoc.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     /**
46 46
      * @param null $member
47 47
      *
48
-     * @return bool|int
48
+     * @return boolean|string
49 49
      */
50 50
     public function canCreate($member = null, $context = [])
51 51
     {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     /**
56 56
      * @param null $member
57 57
      *
58
-     * @return bool|int
58
+     * @return boolean|string
59 59
      */
60 60
     public function canEdit($member = null, $context = [])
61 61
     {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     /**
66 66
      * @param null $member
67 67
      *
68
-     * @return bool|int
68
+     * @return boolean|string
69 69
      */
70 70
     public function canDelete($member = null, $context = [])
71 71
     {
Please login to merge, or discard this patch.
code/docs/OperationManual.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     private static $plural_name = 'OperationManuals';
19 19
 
20 20
     /**
21
-     * @return FieldList
21
+     * @return \SilverStripe\Forms\FieldList
22 22
      */
23 23
     public function getCMSFields()
24 24
     {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     /**
45 45
      * @param null $member
46 46
      *
47
-     * @return bool|int
47
+     * @return boolean|string
48 48
      */
49 49
     public function canCreate($member = null, $context = [])
50 50
     {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     /**
55 55
      * @param null $member
56 56
      *
57
-     * @return bool|int
57
+     * @return boolean|string
58 58
      */
59 59
     public function canEdit($member = null, $context = [])
60 60
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     /**
65 65
      * @param null $member
66 66
      *
67
-     * @return bool|int
67
+     * @return boolean|string
68 68
      */
69 69
     public function canDelete($member = null, $context = [])
70 70
     {
Please login to merge, or discard this patch.
code/docs/SpecSheet.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     private static $plural_name = 'Spec Sheets';
19 19
 
20 20
     /**
21
-     * @return FieldList
21
+     * @return \SilverStripe\Forms\FieldList
22 22
      */
23 23
     public function getCMSFields()
24 24
     {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     /**
45 45
      * @param null $member
46 46
      *
47
-     * @return bool|int
47
+     * @return boolean|string
48 48
      */
49 49
     public function canCreate($member = null, $context = [])
50 50
     {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     /**
55 55
      * @param null $member
56 56
      *
57
-     * @return bool|int
57
+     * @return boolean|string
58 58
      */
59 59
     public function canEdit($member = null, $context = [])
60 60
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     /**
65 65
      * @param null $member
66 66
      *
67
-     * @return bool|int
67
+     * @return boolean|string
68 68
      */
69 69
     public function canDelete($member = null, $context = [])
70 70
     {
Please login to merge, or discard this patch.
code/docs/Warranty.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     private static $plural_name = 'Warranties';
19 19
 
20 20
     /**
21
-     * @return FieldList
21
+     * @return \SilverStripe\Forms\FieldList
22 22
      */
23 23
     public function getCMSFields()
24 24
     {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     /**
45 45
      * @param null $member
46 46
      *
47
-     * @return bool|int
47
+     * @return boolean|string
48 48
      */
49 49
     public function canCreate($member = null, $context = [])
50 50
     {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     /**
55 55
      * @param null $member
56 56
      *
57
-     * @return bool|int
57
+     * @return boolean|string
58 58
      */
59 59
     public function canEdit($member = null, $context = [])
60 60
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     /**
65 65
      * @param null $member
66 66
      *
67
-     * @return bool|int
67
+     * @return boolean|string
68 68
      */
69 69
     public function canDelete($member = null, $context = [])
70 70
     {
Please login to merge, or discard this patch.