PageControllerExtension::updateAddToCartForm() - Code Metrics - Inspection of "FEATURE apply discounts to products" - dynamic/silverstripe-foxy-discounts - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

by Jason

created 2019-07-20 03:42 UTC

PageControllerExtension::updateAddToCartForm() A

↳ Parent: PageControllerExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	2
b	0
f	0
nc	2
nop	1
dl	0
loc	11
rs	9.9666

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Form\AddToCartForm;
use Dynamic\Foxy\Model\FoxyHelper;
use SilverStripe\Core\Extension;
use SilverStripe\Forms\HiddenField;

class PageControllerExtension extends Extension
{
    /**
     * @param $form
     */
    public function updateAddToCartForm(&$form)
    {
        if ($this->owner->data()->getActiveDiscount()) {
            $code = $this->owner->data()->Code;
            $fields = $form->Fields();
            $fields->push(
                HiddenField::create(AddToCartForm::getGeneratedValue(
                    $code,
                    'discount_quantity_percentage',
                    $this->getDiscountFieldValue()
                ))->setValue($this->getDiscountFieldValue())
            );
        }
    }

    /**
     * @return string
     */
    public function getDiscountFieldValue()
    {
        if ($discount = $this->owner->data()->getActiveDiscount()) {
            $string = "|{$discount->Quantity}-{$discount->Percentage}";
            return "{$discount->Title}{allunits{$string}}";
        }
        return false;

    }
}


1			<?php
2
3			namespace Dynamic\Foxy\Discounts\Extension;
4
5			use Dynamic\Foxy\Form\AddToCartForm;
6			use Dynamic\Foxy\Model\FoxyHelper;
7			use SilverStripe\Core\Extension;
8			use SilverStripe\Forms\HiddenField;
9
10			class PageControllerExtension extends Extension
11			{
12			/**
13			* @param $form
14			*/
15			public function updateAddToCartForm(&$form)
16			{
17			if ($this->owner->data()->getActiveDiscount()) {
18			$code = $this->owner->data()->Code;
19			$fields = $form->Fields();
20			$fields->push(
21			HiddenField::create(AddToCartForm::getGeneratedValue(
22			$code,
23			'discount_quantity_percentage',
24			$this->getDiscountFieldValue()
25			))->setValue($this->getDiscountFieldValue())
26			);
27			}
28			}
29
30			/**
31			* @return string
32			*/
33			public function getDiscountFieldValue()
34			{
35			if ($discount = $this->owner->data()->getActiveDiscount()) {
36			$string = "\|{$discount->Quantity}-{$discount->Percentage}";
37			return "{$discount->Title}{allunits{$string}}";
38			}
39			return false;
			0 ignored issues – show Bug Best Practice introduced 2019-07-20 03:28 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the documented return type `string`. Loading history...
40			}
41			}
42

dynamic / silverstripe-foxy-discounts

Pull Request — master (#5)

PageControllerExtension::updateAddToCartForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like